refactor: inline single use constants

The variable name does not provide any benefit

Author: EdJoPaTo

source/lib/all-events.ts

@@ -3,8 +3,6 @@ import {EVENT_FILES_DIR, pullEventFiles} from './git.ts';
 import {typedEntries} from './javascript-helper.ts';
 import type {EventDirectory, EventId} from './types.ts';
 
-const DIRECTORY_FILE = `${EVENT_FILES_DIR}/directory.json`;
-
 let directory: EventDirectory = {};
 let namesOfEvents: Readonly<Record<EventId, string>> = {};
 
@@ -14,7 +12,10 @@ console.log(new Date(), 'eventfiles loaded');
 
 async function update() {
 	await pullEventFiles();
-	const directoryString = await readFile(DIRECTORY_FILE, 'utf8');
+	const directoryString = await readFile(
+		`${EVENT_FILES_DIR}/directory.json`,
+		'utf8',
+	);
 	directory = JSON.parse(directoryString) as EventDirectory;
 	namesOfEvents = await generateMapping();
 }

source/lib/change-helper.ts

@@ -71,7 +71,10 @@ export function generateShortChangeText(
 
 export async function loadEvents(eventId: EventId): Promise<EventEntry[]> {
 	try {
-		const content = await readFile(`${EVENT_FILES_DIR}/events/${eventId}.json`, 'utf8');
+		const content = await readFile(
+			`${EVENT_FILES_DIR}/events/${eventId}.json`,
+			'utf8',
+		);
 		return JSON.parse(content) as EventEntry[];
 	} catch (error) {
 		console.error('ERROR while loading events for change date picker', error);

source/menu/events/add.ts

@@ -19,9 +19,6 @@ import {BACK_BUTTON_TEXT} from '../../lib/inline-menu.ts';
 import {typedEntries} from '../../lib/javascript-helper.ts';
 import type {EventId, MyContext} from '../../lib/types.ts';
 
-const MAX_RESULT_ROWS = 10;
-const RESULT_COLUMNS = 1;
-
 export const bot = new Composer<MyContext>();
 export const menu = new MenuTemplate<MyContext>(ctx => {
 	ctx.session.eventAdd ??= {path: []};
@@ -102,8 +99,8 @@ menu.interact('filter-clear', {
 });
 
 menu.choose('list', {
-	maxRows: MAX_RESULT_ROWS,
-	columns: RESULT_COLUMNS,
+	maxRows: 10,
+	columns: 1,
 	choices(ctx) {
 		try {
 			ctx.session.eventAdd ??= {path: []};