Replace jshint with eslint

Author: rxaviers

.eslintrc

@@ -0,0 +1,17 @@
+{
+  "env": {
+    "browser": true,
+    "mocha": true,
+    "node": true
+  },
+  "extends": [
+    "defaults"
+  ],
+  "rules": {
+    "no-console": 0,
+    "no-trailing-spaces": "warn",
+    "quotes": ["warn", "double"],
+    "semi": "warn",
+    "indent": ["warn", "tab"]
+  }
+}

.jscsrc

@@ -9,61 +9,61 @@ var pkg = require( "../package.json" );
 var bundle, cldr, extracts, extraOptions, input, locale, messages, opts, output, requiredOpts;
 
 function help() {
-  var out = [
-    "Usage: globalize-compiler -l LOCALE [-m MESSAGES_FILE] -o DEST_FILE SRC_FILES...",
-    "Example: globalize-compiler -l en -o app-en.js src/*.js",
-    "",
-    "Extracts formatters and parsers statically from the SRC_FILES and generates",
-    "a precompiled bundle into DEST_FILE using LOCALE.",
-    "",
-    "General options:",
-    "  -h, --help                     # Print options and usage.",
-    "  -v, --version                  # Print the version number.",
-    "  -l, --locale LOCALE            # Specify a LOCALE to use in compilation.",
-    "  -c, --cldr CLDR_FILE           # Optional. All necessary CLDR data for given locale (JSON format).",
-    "  -m, --messages MESSAGES_FILE   # Optional. Translation messages for given locale (JSON format).",
-    "  -o, --output DEST_FILE         # Destination JS file, e.g., `app-en.js`.",
-    ""
-  ];
+	var out = [
+		"Usage: globalize-compiler -l LOCALE [-m MESSAGES_FILE] -o DEST_FILE SRC_FILES...",
+		"Example: globalize-compiler -l en -o app-en.js src/*.js",
+		"",
+		"Extracts formatters and parsers statically from the SRC_FILES and generates",
+		"a precompiled bundle into DEST_FILE using LOCALE.",
+		"",
+		"General options:",
+		"  -h, --help                     # Print options and usage.",
+		"  -v, --version                  # Print the version number.",
+		"  -l, --locale LOCALE            # Specify a LOCALE to use in compilation.",
+		"  -c, --cldr CLDR_FILE           # Optional. All necessary CLDR data for given locale (JSON format).",
+		"  -m, --messages MESSAGES_FILE   # Optional. Translation messages for given locale (JSON format).",
+		"  -o, --output DEST_FILE         # Destination JS file, e.g., `app-en.js`.",
+		""
+	];
 
-  return out.join( "\n" );
+	return out.join( "\n" );
 }
 
 opts = nopt( {
-  help: Boolean,
-  version: Boolean,
-  locale: String,
-  cldr: path,
-  messages: path,
-  output: path
+	help: Boolean,
+	version: Boolean,
+	locale: String,
+	cldr: path,
+	messages: path,
+	output: path
 }, {
-  h: "--help",
-  v: "--version",
-  l: "--locale",
-  c: "--cldr",
-  m: "--messages",
-  o: "--output"
+	h: "--help",
+	v: "--version",
+	l: "--locale",
+	c: "--cldr",
+	m: "--messages",
+	o: "--output"
 });
 requiredOpts = true;
 
 if ( opts.version ) {
-  return console.log( pkg.version );
+	return console.log( pkg.version );
 }
 
 if ( !opts.locale || !opts.output ) {
-  requiredOpts = false;
+	requiredOpts = false;
 }
 
 extraOptions = Object.keys( opts ).filter(function( option ) {
-  return !/help|version|locale|cldr|messages|output|argv/.test( option );
+	return !/help|version|locale|cldr|messages|output|argv/.test( option );
 });
 
 if ( extraOptions.length ) {
-  console.log( "Invalid options:", extraOptions.join( ", " ), "\n" );
+	console.log( "Invalid options:", extraOptions.join( ", " ), "\n" );
 }
 
 if ( opts.help || !requiredOpts || extraOptions.length ) {
-  return console.log( help() );
+	return console.log( help() );
 }
 
 input = opts.argv.remain;
@@ -76,14 +76,14 @@ cldr = cldr ? JSON.parse( fs.readFileSync( cldr ) ) : null;
 messages = messages ? JSON.parse( fs.readFileSync( messages ) ) : null;
 
 extracts = input.map(function( input ) {
-  return GlobalizeCompiler.extract( input );
+	return GlobalizeCompiler.extract( input );
 });
 
 bundle = GlobalizeCompiler.compileExtracts({
-  defaultLocale: locale,
-  cldr: cldr,
-  messages: messages,
-  extracts: extracts
+	defaultLocale: locale,
+	cldr: cldr,
+	messages: messages,
+	extracts: extracts
 });
 
 fs.writeFileSync( output, bundle );

bin/globalize-compiler.js

@@ -1,5 +1,5 @@
 var COMPILED_ORDER, DEPENDENCIES, DEPENDENCIES_VARS, fnPlaceholder, fnPlaceholderRe,
-	regexpPlaceholder, regexpPlaceholderRe, slice, template, undefinedPlaceholder,
+	regexpPlaceholder, regexpPlaceholderRe, template, undefinedPlaceholder,
 	undefinedPlaceholderRe,
 	extend = require( "util" )._extend,
 	fs = require( "fs" );
@@ -31,7 +31,7 @@ DEPENDENCIES = {
 	numberParser: { number: true },
 	pluralGenerator: { plural: true },
 	relativeTimeFormatter: { number: true, plural: true, "relative-time": true },
-	unitFormatter: { number: true, plural: true, unit: true },
+	unitFormatter: { number: true, plural: true, unit: true }
 };
 
 DEPENDENCIES_VARS = {
@@ -89,7 +89,6 @@ DEPENDENCIES_VARS = {
 	}
 };
 
-slice = [].slice;
 template = fs.readFileSync( __dirname + "/compile.template" ).toString( "utf-8" );
 
 function functionName( fn ) {

lib/compile.js

@@ -13,7 +13,7 @@
     "globalize-compiler": "./bin/globalize-compiler"
   },
   "scripts": {
-    "test": "jshint index.js lib/**/*.js test/*.js && mocha"
+    "test": "eslint --ignore-path .gitignore --ext .js index.js lib test bin && mocha"
   },
   "repository": {
     "type": "git",
@@ -41,6 +41,8 @@
     "babel": "^5.6.14",
     "chai": "1.10.x",
     "cldr-data": ">=25",
+    "eslint": "^3.19.0",
+    "eslint-config-defaults": "^9.0.0",
     "globalize": ">=1.3.0-a <2.0.0",
     "jshint": "2.6.x",
     "mocha": "2.1.0"

package.json

@@ -4,36 +4,36 @@ var expect = require("chai").expect;
 var globalizeCompiler = require("../index");
 
 var fixtures = {
-  //babel: esprima.parse(babel.transform(fs.readFileSync(__dirname + "/fixtures/es6.js")).code),
-  basic: esprima.parse(fs.readFileSync(__dirname + "/fixtures/basic.js"))
+	//babel: esprima.parse(babel.transform(fs.readFileSync(__dirname + "/fixtures/es6.js")).code),
+	basic: esprima.parse(fs.readFileSync(__dirname + "/fixtures/basic.js"))
 };
 
 describe("Extract Formatters & Parsers", function() {
-  var compiledString, extract;
+	var compiledString, extract;
 
-  it("should extract formatters and parsers from basic code", function() {
-    extract = globalizeCompiler.extract(fixtures.basic);
-    expect(extract).to.be.a("function");
-  });
+	it("should extract formatters and parsers from basic code", function() {
+		extract = globalizeCompiler.extract(fixtures.basic);
+		expect(extract).to.be.a("function");
+	});
 
-  it("should compile extracts from basic code", function() {
-    compiledString = globalizeCompiler.compileExtracts({
-      defaultLocale: "en",
-      messages: {
-        en: {
-          like: "Foo"
-        }
-      },
-      extracts: extract
-    });
+	it("should compile extracts from basic code", function() {
+		compiledString = globalizeCompiler.compileExtracts({
+			defaultLocale: "en",
+			messages: {
+				en: {
+					like: "Foo"
+				}
+			},
+			extracts: extract
+		});
 
-    expect(compiledString).to.be.a("string");
-  });
+		expect(compiledString).to.be.a("string");
+	});
 
-  describe("compile.js", function() {
-    it("should handle runtimeArgs regexps", function() {
-      expect(compiledString).to.have.string("numberParserFn([{\".\":\".\",\",\":\",\",\"%\":\"%\",\"+\":\"+\",\"-\":\"-\",\"E\":\"E\",\"‰\":\"‰\"},,{\"infinity\":/^∞/,\"nan\":/^NaN/,\"negativePrefix\":/^-/,\"negativeSuffix\":/^/,\"number\":/^((\\d{1,3}(,\\d{3})+|\\d+))?(\\.\\d+)?/,\"prefix\":/^/,\"suffix\":/^/}]);");
-    });
-  });
+	describe("compile.js", function() {
+		it("should handle runtimeArgs regexps", function() {
+			expect(compiledString).to.have.string("numberParserFn([{\".\":\".\",\",\":\",\",\"%\":\"%\",\"+\":\"+\",\"-\":\"-\",\"E\":\"E\",\"‰\":\"‰\"},,{\"infinity\":/^∞/,\"nan\":/^NaN/,\"negativePrefix\":/^-/,\"negativeSuffix\":/^/,\"number\":/^((\\d{1,3}(,\\d{3})+|\\d+))?(\\.\\d+)?/,\"prefix\":/^/,\"suffix\":/^/}]);");
+		});
+	});
 
 });