Skip to content

Commit 4202ae8

Browse files
authored
Adjust HDF5Examples HDF5 version var to correct version check issue for 2.0 (#5926)
Adjusts H5_LIBVER_DIR in CMakeLists.txt to include release version for major versions above 1, fixing #5925.
1 parent f981c9c commit 4202ae8

File tree

2 files changed

+34
-11
lines changed

2 files changed

+34
-11
lines changed

CMakeLists.txt

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -512,8 +512,15 @@ set (HDF5_PACKAGE_BUGREPORT "[email protected]")
512512
set (HDF5_VERSION_STRING ${HDF5_PACKAGE_VERSION})
513513
set (HDF5_VERSION_MAJOR ${HDF5_PACKAGE_VERSION_MAJOR})
514514
set (HDF5_VERSION_MINOR ${HDF5_PACKAGE_VERSION_MINOR})
515-
set (H5_LIBVER_DIR ${H5_VERS_MAJOR}${H5_VERS_MINOR})
516-
515+
if (H5_VERS_MAJOR GREATER 1)
516+
if (H5_VERS_MINOR GREATER 9)
517+
set (H5_LIBVER_DIR ${H5_VERS_MAJOR}${H5_VERS_MINOR})
518+
else ()
519+
set (H5_LIBVER_DIR ${H5_VERS_MAJOR}0${H5_VERS_MINOR})
520+
endif()
521+
else ()
522+
set (H5_LIBVER_DIR ${H5_VERS_MAJOR}${H5_VERS_MINOR})
523+
endif()
517524
#-----------------------------------------------------------------------------
518525
# Include some macros for reusable code
519526
#-----------------------------------------------------------------------------

HDF5Examples/config/cmake/HDFExampleMacros.cmake

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -304,13 +304,22 @@ macro (HDF5_SUPPORT)
304304
if (H5EXAMPLE_BUILD_JAVA AND HDF5_Java_FOUND)
305305
if (${HDF5_PROVIDES_JAVA})
306306
set (CMAKE_JAVA_INCLUDE_PATH "${CMAKE_JAVA_INCLUDE_PATH};${HDF5_JAVA_INCLUDE_DIRS}")
307-
get_target_property (libsoname ${HDF5_JAVA_LIBRARY} IMPORTED_SONAME${UPPER_BUILD_TYPE})
308-
get_filename_component (libname ${libsoname} NAME_WE)
309-
string (REGEX REPLACE "^lib" "" libname ${libname})
310-
message (STATUS "HDF5 lib:${HDF5_JAVA_LIBRARY} OR ${libsoname} OR ${libname}")
311-
set (H5EXAMPLE_JAVA_LIBRARY ${libname})
312-
set (H5EXAMPLE_JAVA_LIBRARIES ${HDF5_JAVA_LIBRARY})
313-
message (STATUS "HDF5 lib:${H5EXAMPLE_JAVA_LIBRARY} jars:${HDF5_JAVA_INCLUDE_DIRS}}")
307+
if (HDF5_PROVIDES_JNI AND HDF5_Java_FOUND)
308+
get_target_property (libsoname ${HDF5_JAVA_LIBRARY} IMPORTED_SONAME${UPPER_BUILD_TYPE})
309+
get_filename_component (libname ${libsoname} NAME_WE)
310+
string (REGEX REPLACE "^lib" "" libname ${libname})
311+
message (STATUS "HDF5 java lib:${HDF5_JAVA_LIBRARY} OR ${libsoname} OR ${libname}")
312+
set (H5EXAMPLE_JAVA_LIBRARY ${libname})
313+
set (H5EXAMPLE_JAVA_LIBRARIES ${HDF5_JAVA_LIBRARY})
314+
else ()
315+
get_target_property (libsoname ${HDF5_C_SHARED_LIBRARY} IMPORTED_SONAME${UPPER_BUILD_TYPE})
316+
get_filename_component (libname ${libsoname} NAME_WE)
317+
string (REGEX REPLACE "^lib" "" libname ${libname})
318+
message (STATUS "HDF5 java lib:${HDF5_C_SHARED_LIBRARY} OR ${libsoname} OR ${libname}")
319+
set (H5EXAMPLE_JAVA_LIBRARY ${HDF5_C_SHARED_LIBRARY})
320+
set (H5EXAMPLE_JAVA_LIBRARIES ${HDF5_JAVA_LIBRARY})
321+
endif ()
322+
message (STATUS "HDF5 java lib:${H5EXAMPLE_JAVA_LIBRARY} jars:${HDF5_JAVA_INCLUDE_DIRS}}")
314323
else ()
315324
set (H5EXAMPLE_BUILD_JAVA OFF CACHE BOOL "Build Java support" FORCE)
316325
message (STATUS "HDF5 Java libs not found - disable build of Java examples")
@@ -384,8 +393,15 @@ macro (APIVersion version xyapi)
384393
if (NOT ${rem} STREQUAL "0")
385394
math (EXPR minor "${minor} + 1")
386395
endif ()
387-
388-
set (${xyapi} "${major}${minor}")
396+
if (major GREATER 1)
397+
if (minor GREATER 9)
398+
set (${xyapi} ${major}${minor})
399+
else ()
400+
set (${xyapi} ${major}0${minor})
401+
endif()
402+
else ()
403+
set (${xyapi} ${major}${minor})
404+
endif()
389405

390406
#-----------------------------------------------------------------------------
391407
# Option to use 1.6.x API

0 commit comments

Comments
 (0)