Remove checks for sys/types.h (#5821)

This is present on all systems we support, including Windows. There is
no reason to check for it or hide its inclusion behind ifdefs.

Author: derobins

config/ConfigureChecks.cmake

@@ -134,7 +134,6 @@ CHECK_INCLUDE_FILE_CONCAT ("sys/resource.h"  ${HDF_PREFIX}_HAVE_SYS_RESOURCE_H)
 CHECK_INCLUDE_FILE_CONCAT ("sys/socket.h"    ${HDF_PREFIX}_HAVE_SYS_SOCKET_H)
 CHECK_INCLUDE_FILE_CONCAT ("sys/stat.h"      ${HDF_PREFIX}_HAVE_SYS_STAT_H)
 CHECK_INCLUDE_FILE_CONCAT ("sys/time.h"      ${HDF_PREFIX}_HAVE_SYS_TIME_H)
-CHECK_INCLUDE_FILE_CONCAT ("sys/types.h"     ${HDF_PREFIX}_HAVE_SYS_TYPES_H)
 CHECK_INCLUDE_FILE_CONCAT ("dirent.h"        ${HDF_PREFIX}_HAVE_DIRENT_H)
 CHECK_INCLUDE_FILE_CONCAT ("unistd.h"        ${HDF_PREFIX}_HAVE_UNISTD_H)
 CHECK_INCLUDE_FILE_CONCAT ("pwd.h"           ${HDF_PREFIX}_HAVE_PWD_H)
@@ -196,7 +195,6 @@ macro (HDF_FUNCTION_TEST OTHER_TEST)
     foreach (def
         HAVE_SYS_TIME_H
         HAVE_UNISTD_H
-        HAVE_SYS_TYPES_H
         HAVE_SYS_SOCKET_H
     )
       if ("${${HDF_PREFIX}_${def}}")

config/H5pubconf.h.in

@@ -304,9 +304,6 @@
 /* Define to 1 if you have the <sys/time.h> header file. */
 #cmakedefine H5_HAVE_SYS_TIME_H @H5_HAVE_SYS_TIME_H@
 
-/* Define to 1 if you have the <sys/types.h> header file. */
-#cmakedefine H5_HAVE_SYS_TYPES_H @H5_HAVE_SYS_TYPES_H@
-
 /* Define to 1 if you have the <szlib.h> header file. */
 #cmakedefine H5_HAVE_SZLIB_H @H5_HAVE_SZLIB_H@
 

config/HDFTests.c

@@ -84,12 +84,10 @@ int main(void)
 
 #include <stdio.h>
 #include <stdlib.h>
+#include <sys/types.h>
 #ifdef HAVE_UNISTD_H
 #   include <unistd.h>
 #endif
-#ifdef HAVE_SYS_TYPES_H
-#   include <sys/types.h>
-#endif
 #ifdef HAVE_SYS_SOCKET_H
 #   include <sys/socket.h>
 #endif

src/H5public.h

@@ -38,9 +38,7 @@
  * on Windows, though it doesn't necessarily contain all the POSIX types
  * we need for HDF5 (e.g. ssize_t).
  */
-#ifdef H5_HAVE_SYS_TYPES_H
 #include <sys/types.h>
-#endif
 
 #ifdef H5_HAVE_PARALLEL
 /* Don't link against MPI C++ bindings */

tools/test/perform/direct_write_perf.c

@@ -33,6 +33,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <time.h>
+#include <sys/types.h>
 
 #ifdef H5_HAVE_SYS_STAT_H
 #include <sys/stat.h>
@@ -42,10 +43,6 @@
 #include <sys/time.h>
 #endif
 
-#ifdef H5_HAVE_SYS_TYPES_H
-#include <sys/types.h>
-#endif
-
 #ifdef H5_HAVE_UNISTD_H
 #include <unistd.h>
 #endif