Skip to content

Commit ef171e0

Browse files
authored
Remove NEWSLETTER files. (#5859)
* Remove NEWSLETTER files. Update tarball.yml and release-files.yml to upload description for snapshots and releases. * Add path to CHANGELOG.md in tarball.yml.
1 parent 507d7ce commit ef171e0

File tree

7 files changed

+19
-69
lines changed

7 files changed

+19
-69
lines changed

.github/workflows/release-files.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,11 @@ jobs:
208208
run: |
209209
echo "${{ steps.get-file-base.outputs.FILE_BASE }}" > ./last-file.txt
210210
211-
- name: Create description for release/snapshot from "Executive Summary" section of CHANGELOG.md
212-
run: |
213-
sed -n '/^# .* Executive Summary: HDF5 Version .*/,/^# .* Breaking Changes/p' CHANGELOG.md | sed '$d' > description.txt
211+
- name: Get description.txt for release/snapshot
212+
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
213+
with:
214+
name: description.txt
215+
path: ${{ github.workspace }}
214216

215217
- name: PreRelease tag
216218
id: create_prerelease

.github/workflows/tarball.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,9 +193,18 @@ jobs:
193193
path: hdf5.zip
194194
if-no-files-found: error # 'warn' or 'ignore' are also available, defaults to `warn`
195195

196-
- name: Save NEWSLETTER
196+
- name: Create description for release/snapshot from "Executive Summary" section of CHANGELOG.md
197+
run: |
198+
sed -n '/^# .* Executive Summary: HDF5 Version .*/,/^# .* Breaking Changes/p' ./hdfsrc/release_docs/CHANGELOG.md | sed '$d' > description.txt
199+
200+
- name: List files in the repository
201+
run: |
202+
ls -l ${{ github.workspace }}
203+
ls $GITHUB_WORKSPACE
204+
205+
- name: Upload description.txt
197206
uses: actions/upload-artifact@v4
198207
with:
199-
name: NEWSLETTER
200-
path: ./hdfsrc/release_docs/NEWSLETTER.txt
208+
name: description.txt
209+
path: ./description.txt
201210
if-no-files-found: error # 'warn' or 'ignore' are also available, defaults to `warn`

bin/h5vers

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -187,10 +187,6 @@ die "unable to read file: $README\n" unless -r $file;
187187
my $RELEASE = $file;
188188
$RELEASE =~ s/[^\/]*$/..\/release_docs\/RELEASE.txt/;
189189
die "unable to read file: $RELEASE\n" unless -r $file;
190-
# release_docs/NEWSLETTER.txt
191-
my $NEWS = $file;
192-
$NEWS =~ s/[^\/]*$/..\/release_docs\/NEWSLETTER.txt/;
193-
die "unable to read file: $NEWS\n" unless -r $file;
194190
my $H5_JAVA = $file;
195191
$H5_JAVA =~ s/[^\/]*$/..\/java\/src\/hdf\/hdf5lib\/H5.java/;
196192
die "unable to read file: $H5_JAVA\n" unless -r $file;
@@ -246,7 +242,6 @@ if ($set) {
246242
# Nothing to do but print result
247243
$README = "";
248244
$RELEASE = "";
249-
$NEWS = "";
250245
$LT_VERS = "";
251246
$HDF5CONFIGCMAKE = "";
252247
$HDF5EXCONFCMAKE = "";
@@ -328,20 +323,6 @@ if ($RELEASE) {
328323
close FILE;
329324
}
330325

331-
# Update the release_docs/NEWSLETTER.txt file
332-
if ($NEWS) {
333-
open FILE, $NEWS or die "$NEWS: $!\n";
334-
my @contents = <FILE>;
335-
close FILE;
336-
$contents[0] = sprintf("HDF5 version %d.%d.%d%s %s",
337-
@newver[0,1,2],
338-
$newver[3] eq "" ? "" : "-".$newver[3],
339-
"currently under development\n");
340-
open FILE, ">$NEWS" or die "$NEWS: $!\n";
341-
print FILE @contents;
342-
close FILE;
343-
}
344-
345326
# Update the config/cmake/scripts/HDF5config.cmake file
346327
if ($HDF5CONFIGCMAKE) {
347328
my $data = read_file($HDF5CONFIGCMAKE);

bin/release

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ ln -s `pwd` $tmpdir/$HDF5_IN_VERS || exit 1
261261

262262
# Update README.md and release_docs/RELEASE.txt with release information in
263263
# line 1.
264-
for f in README.md release_docs/RELEASE.txt release_docs/NEWSLETTER.txt; do
264+
for f in README.md release_docs/RELEASE.txt; do
265265
echo "HDF5 version $VERS released on $release_date" >$f.x
266266
sed -e 1d $f >>$f.x
267267
mv $f.x $f

release_docs/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ HDF5 release, platforms tested, and known problems in this release.
3030

3131
## Significant Advancements:
3232

33-
- Full [UTF-8](https://github.com/HDFGroup/hdf5/blob/develop/release_docs/CHANGELOG.md#utf8) filename support on Windows, resolving encoding issues from previous versions.
33+
- Full [UTF-8](https://github.com/HDFGroup/hdf5/blob/develop/release_docs/CHANGELOG.md#utf-8) filename support on Windows, resolving encoding issues from previous versions.
3434
- Introduction of bfloat16 predefined datatypes for efficient machine learning conversions.
3535
- First-class support for [complex numbers](https://github.com/HDFGroup/hdf5/blob/develop/release_docs/CHANGELOG.md#complex), eliminating manual workarounds in scientific applications.
3636

release_docs/NEWSLETTER.txt

Lines changed: 0 additions & 17 deletions
This file was deleted.

release_docs/NEWSLETTER_README.txt

Lines changed: 0 additions & 25 deletions
This file was deleted.

0 commit comments

Comments
 (0)