Skip to content

h5diff report mode should indicate when there is a diff due to a missing dataset in one file #6102

@jeremy-rifkin

Description

@jeremy-rifkin

Hello,
When running h5diff -r foo.hdf5 bar.hdf5 I get an output like

group  : </> and </>
0 differences found
group  : </data> and </data>
0 differences found
dataset: </data/foo> and </data/foo>
0 differences found
dataset: </data/bar> and </data/bar>
0 differences found
dataset: </data/foofoo> and </data/foofoo>
0 differences found
dataset: </data/boo> and </data/boo>
0 differences found
dataset: </data/baz> and </data/baz>
0 differences found
dataset: </data/biz> and </data/biz>
0 differences found

Which looks like it's reporting no diffs, however, the return code is non-zero. I find this very confusing and if I was using a shell configuration that didn't provide any visual indicators for non-zero return codes I wouldn't know any better.

-v can be used to show

file1     file2
---------------------------------------
    x      x    /              
    x      x    /data          
    x      x    /data/foo   
    x      x    /data/bar   
    x      x    /data/foofoo
    x      x    /data/boo     
           x    /data/booboo
    x      x    /data/baz        
    x      x    /data/biz     

But it would be nice if there was some indication from report mode about this situation, e.g. at the end "Missing datasets detected, run with -v to view"

Metadata

Metadata

Assignees

Labels

Component - ToolsCommand-line tools like h5dump, includes high-level tools

Projects

Status

In progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions