fix np.frombuffer error

Author: jreadey

hsds/attr_sn.py

@@ -851,11 +851,7 @@ async def PUT_AttributeValue(request):
             msg += f"but got {len(binary_data)}"
             log.warn(msg)
             raise HTTPBadRequest(reason=msg)
-        arr = np.fromstring(binary_data, dtype=np_dtype)
-        if attr_shape["class"] == "H5S_SCALAR":
-            arr = arr.reshape([])
-        else:
-            arr = arr.reshape(np_shape)  # conform to selection shape
+        arr = bytesToArray(binary_data, np_dtype, np_shape)
         log.debug(f"got array {arr} from binary data")
     else:
         try:

hsds/chunk_sn.py

@@ -657,7 +657,7 @@ async def PUT_Value(request):
                 log.warn(f"bytesToArray value error: {ve}")
                 raise HTTPBadRequest()
         else:
-            # fixed item size
+            # fixed item size - check against number of bytes
             if len(input_data) % item_size != 0:
                 msg = f"Expected request size to be a multiple of {item_size}, "
                 msg += f"but {len(input_data)} bytes received"
@@ -668,8 +668,7 @@ async def PUT_Value(request):
                 msg = f"expected {item_size * num_elements} bytes but got {len(input_data)}"
                 log.warn(msg)
                 raise HTTPBadRequest(reason=msg)
-
-            arr = np.fromstring(input_data, dtype=dset_dtype)
+            arr = np.frombuffer(input_data, dtype=dset_dtype)
             log.debug(f"read fixed type array: {arr}")
 
         if bc_shape:
@@ -1166,7 +1165,7 @@ async def POST_Value(request):
             log.warn(msg)
             raise HTTPBadRequest(reason=msg)
         num_points = request.content_length // point_dt.itemsize
-        points = np.fromstring(binary_data, dtype=point_dt)
+        points = np.frombuffer(binary_data, dtype=point_dt)
         # reshape the data based on the rank (num_points x rank)
         if rank > 1:
             if len(points) % rank != 0: