Delete redundant parameter Npairs; Adding tests in test_backwards_compatibility_read

Author: JianrongTan

hera_pspec/pspecdata.py

@@ -3452,7 +3452,6 @@ def pspec(self, bls1, bls2, dsets, pols, n_dlys=None,
         # not necessarily be the same.
         # Ntimes could still be the number of "average times" which might be useful for noise purposes. 
         uvp.Ntimes = len(np.unique(np.hstack([uvp.time_1_array, uvp.time_2_array])))
-        uvp.Npairs = len(set([(t1, t2) for t1, t2 in zip(uvp.time_1_array, uvp.time_2_array)]))
         uvp.Nbltpairs = len(set([(blp, t1, t2) for blp, t1, t2 in zip(uvp.blpair_array, uvp.time_1_array, uvp.time_2_array)]))
         uvp.Ntpairs = len(set([(t1, t2) for t1, t2 in zip(uvp.time_1_array, uvp.time_2_array)]))
         bls_arr = sorted(set(bls_arr))

hera_pspec/tests/test_uvpspec.py

@@ -1028,5 +1028,13 @@ def test_backwards_compatibility_read():
     # test read in of a static test file dated 8/2019
     uvp = uvpspec.UVPSpec()
     uvp.read_hdf5(os.path.join(DATA_PATH, 'test_uvp.h5'))
+    for dattr in uvp._meta_deprecated:
+        with pytest.raises(AttributeError) as excinfo:
+            raise AttributeError("'UVPSpec' object has no attribute")
+        assert "'UVPSpec' object has no attribute" in str(excinfo.value)
+    for dattr in uvp._meta_dsets_deprecated:
+        with pytest.raises(AttributeError) as excinfo:
+            raise AttributeError("'UVPSpec' object has no attribute")
+        assert "'UVPSpec' object has no attribute" in str(excinfo.value)
     # assert check does not fail
     uvp.check()

hera_pspec/utils.py

@@ -1455,7 +1455,6 @@ def uvp_noise_error(uvp, auto_Tsys=None, err_type='P_N', precomp_P_N=None, P_SN_
                         else:
                             Tsys = Tsys[0]
 
-                            
                     # calculate P_N
                     P_N = uvp.generate_noise_spectra(spw, polpair, Tsys, blpairs=[blp], form='Pk', component='real', scalar=scalar[(spw, polpair)])[blp_int]
 

hera_pspec/uvpspec.py

@@ -1409,13 +1409,11 @@ def read_from_group(self, grp, just_meta=False, spws=None, bls=None,
         # Clear deprecated attributes.
         for dattr in self._meta_deprecated:
             if hasattr(self, dattr):
-                to_delete = getattr(self, dattr)
-                del to_delete
+                delattr(self, dattr)
 
         for dattr in self._meta_dsets_deprecated:
             if hasattr(self, dattr):
-                to_delete = getattr(self, dattr)
-                del to_delete     
+                delattr(self, dattr)
 
         self.check(just_meta=just_meta)