Fix spurious failures for macos packages#901
Merged
Conversation
Sometimes, between fetching an index and downloading the actual package, there's an update to a package, which causes a checksum mismatch. This has been causing macos build failures. Clearing the package cache before `conda build` helps prevent this failure from happening. We also add retry logic so that if the upstream race condition occurs during the actual build, it will hopefully succeed the next time. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Collaborator
Author
|
I'm gonna try running the CI 3 times to verify the spurious error doesn't happen again, at least in this PR. It's running the first time now. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #901 +/- ##
=======================================
Coverage 69.41% 69.41%
=======================================
Files 148 148
Lines 22590 22590
=======================================
Hits 15680 15680
Misses 6910 6910 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Strangely, the code coverage is reduced, even though only CI code was modified 🙂 |
Collaborator
Author
|
First time passed. Rerunning. |
Collaborator
Author
|
Second time passed. It succeeded during its second attempt (first attempt had the error). |
This will *really* ensure it won't fail. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
ZackAttack614
approved these changes
Mar 3, 2026
Collaborator
ZackAttack614
left a comment
ZackAttack614
left a comment
There was a problem hiding this comment.
This is an improvement, but I hope we can figure out how to resolve the core of the issue soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Sometimes, between fetching an index and downloading the actual package, there's an update to a package, which causes a checksum mismatch. This has been causing macos build failures.
Clearing the package cache before
conda buildhelps prevent this failure from happening. We also add retry logic so that if the upstream race condition occurs during the actual build, it will hopefully succeed the next time.I think it is mainly happening for mac because we include a cross-compile, and thus build 10 packages in one CI run. I think
conda buildcaches the hashsum values early on in the process, and if the packages get updated upstream during the 10 builds, the hashsum no longer matches and it fails.Affected Workflows
None
Documentation Changes
None