Skip to content

Commit 6779d71

Browse files
committed
Don't change presentation on menu update
Signed-off-by: Brianna Major <brianna.major@kitware.com>
1 parent 67f42cb commit 6779d71

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

hexrdgui/masking/mask_manager_dialog.py

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -437,22 +437,23 @@ def apply_changes(self):
437437
self.ui.apply_changes.setEnabled(False)
438438

439439
def selected_changed(self):
440-
selected = self.ui.masks_tree.selectedItems()
441-
self.ui.presentation_selector.setEnabled(len(selected) > 1)
442-
self.ui.export_selected.setEnabled(len(selected) > 1)
443-
self.ui.remove_selected.setEnabled(len(selected) > 1)
444-
if len(selected) == 0:
445-
return
440+
with block_signals(self.ui.presentation_selector):
441+
selected = self.ui.masks_tree.selectedItems()
442+
self.ui.presentation_selector.setEnabled(len(selected) > 1)
443+
self.ui.export_selected.setEnabled(len(selected) > 1)
444+
self.ui.remove_selected.setEnabled(len(selected) > 1)
445+
if len(selected) == 0:
446+
return
446447

447-
boundary_masks = [MaskType.region, MaskType.polygon, MaskType.pinhole]
448-
masks_from_names = [MaskManager().get_mask_by_name(i.text(0)) for i in selected]
449-
vis_only = any(mask.type not in boundary_masks for mask in masks_from_names)
450-
self.ui.presentation_selector.clear()
451-
self.ui.presentation_selector.addItem('None')
452-
self.ui.presentation_selector.addItem('Visible')
453-
if not vis_only:
454-
self.ui.presentation_selector.addItem('Boundary Only')
455-
self.ui.presentation_selector.addItem('Visible + Boundary')
448+
boundary_masks = [MaskType.region, MaskType.polygon, MaskType.pinhole]
449+
masks_from_names = [MaskManager().get_mask_by_name(i.text(0)) for i in selected]
450+
vis_only = any(mask.type not in boundary_masks for mask in masks_from_names)
451+
self.ui.presentation_selector.clear()
452+
self.ui.presentation_selector.addItem('None')
453+
self.ui.presentation_selector.addItem('Visible')
454+
if not vis_only:
455+
self.ui.presentation_selector.addItem('Boundary Only')
456+
self.ui.presentation_selector.addItem('Visible + Boundary')
456457

457458
def change_presentation_for_selected(self, text):
458459
if len(self.ui.masks_tree.selectedItems()) <= 1:

0 commit comments

Comments
 (0)