imp: use display categories for modrinth tag display #5160
Merged
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Modrinth integration to use display_categories instead of categories for tag display in the download page. According to the PR description, this change addresses an issue where too many categories were being shown, making the tag display cluttered and difficult to read. Modrinth's own platform uses display categories, which are a curated subset of all categories.
Changes:
- Added
displayCategoriesfield toProjectSearchResultclass to capture Modrinth's curated category list - Updated the
toMod()method to usedisplayCategoriesinstead ofcategoriesfor search results
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modrinth/ModrinthRemoteModRepository.java
Show resolved
Hide resolved
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modrinth/ModrinthRemoteModRepository.java
Show resolved
Hide resolved
Glavo
approved these changes
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
主要是 categories 太多了，下载页面的 tag 显示经常糊成一团啥也看不见，不如用 modrinth 自己也在用的 display categories 作为展示