Polishing

- Cleaned up header (no login shell, portable, abort on error)
- Keeps error codes and messages from the actual command, which is more
  clear in this case
- Mentions Apache Subversion (SVN) dependency; directly available on
  probably all HPC systems, but may need to be installed on laptop

Author: mvhulten

README.md

@@ -151,8 +151,8 @@ There are two possible ways to download the grids
 wget --no-check-certificate -i clm_mappingfiles.txt
 ```
 
-2. Run `download_grids.sh` after adapting inputs (in particular the
-   path `myraw`).
+2. Run `download_grids.sh` after adapting inputs (in particular the path `myraw`).
+   You need Subversion (`svn`) for this.
 ```
 ./download_grids.sh
 ```

mkmapdata/download_grids.sh

@@ -1,9 +1,10 @@
-#!/bin/bash -l
+#!/usr/bin/env bash
+set -e
 
 ### URL base for the grids
 SVNBASE="https://svn-ccsm-inputdata.cgd.ucar.edu/trunk/inputdata/lnd/clm2/mappingdata/grids"
 
-### Local directory 
+### Local directory
 myraw="$PWD/download_grids"
 mkdir -p "$myraw"
 
@@ -34,8 +35,7 @@ for file in "${files[@]}"; do
   url="${SVNBASE}/${file}"
   if [ ! -f "$localf" ]; then
     echo "Downloading $file ..."
-    # wget -O "$localf" "$url" || { echo "ERROR downloading $url"; exit 1; }
-    svn export "$url" "$localf" || { echo "ERROR exporting $url"; exit 1; }
+    svn export "$url" "$localf"
   else
     echo "File $file already exists — skipping download."
   fi