Merge pull request #787 from remo-lab/fix/dispose-intermediate-geometries

Fix GPU memory leak when loading Box-type hits

Author: EdwardMoyse

packages/phoenix-event-display/src/loaders/objects/phoenix-objects.ts

@@ -487,6 +487,10 @@ export class PhoenixObjects {
       geometries.push(boxGeometry);
     }
     const geometry = mergeGeometries(geometries);
+    // Dispose intermediate geometries to free GPU memory
+    for (const geom of geometries) {
+      geom.dispose();
+    }
     geometry.computeBoundingSphere();
     // material
     const material = new MeshPhongMaterial({
@@ -738,10 +742,13 @@ export class PhoenixObjects {
       color: caloCells[0].color ?? EVENT_DATA_TYPE_COLORS.PlanarCaloCells,
     });
 
-    const outerBox = new Mesh(
-      BufferGeometryUtils.mergeGeometries(geoms),
-      material,
-    );
+    const mergedGeometry = BufferGeometryUtils.mergeGeometries(geoms);
+    // Dispose intermediate geometries to free GPU memory
+    for (const geom of geoms) {
+      geom.dispose();
+    }
+
+    const outerBox = new Mesh(mergedGeometry, material);
 
     outerBox.userData = Object.assign({}, caloCells[0]);
     outerBox.name = 'PlanarCaloCell';