Raise errors early and more verbose when trying to run only last iteration or use a precalculated transit cost matrix without matrices defined

Author: s-hiitola

Scripts/helmet.py

@@ -15,18 +15,30 @@
 
 
 def main(args):
+    # Set up filepaths
+    base_zonedata_path: str = os.path.join(args.baseline_data_path, "2023_zonedata")
+    base_matrices_path: str = os.path.join(args.baseline_data_path, "base_matrices")
+    forecast_zonedata_path: str = args.forecast_data_path
+    results_path: str = args.results_path
+    emme_project_path: str = args.emme_path
+
     if args.end_assignment_only:
+        # Raise error if there is no demand matrix in results folder
+        matrix_path = os.path.join(results_path, args.scenario_name, "Matrices")
+        demand_matrix_path = os.path.join(results_path, args.scenario_name, "Matrices", "demand_aht.omx")
+        if not os.path.exists(demand_matrix_path):
+            msg = "Matrices not found for this scenario. Please uncheck the " \
+            + "'Aja vain loppusijoittelu' option in Helmet UI's scenario settings, " \
+            + f"or copy the demand matrices from base scenario to [{matrix_path}]."
+            log.error(msg)
+            raise FileNotFoundError(msg)
+        # Else set iterations to 0, so that only the last iteration is run
         iterations = 0
     elif args.iterations > 0:
         iterations = args.iterations
     else:
         raise ArgumentTypeError(
             "Iteration number {} not valid".format(args.iterations))
-    base_zonedata_path: str = os.path.join(args.baseline_data_path, "2023_zonedata")
-    base_matrices_path: str = os.path.join(args.baseline_data_path, "base_matrices")
-    forecast_zonedata_path: str = args.forecast_data_path
-    results_path: str = args.results_path
-    emme_project_path: str = args.emme_path
     log_extra = {
         "status": {
             "name": args.scenario_name,
@@ -115,6 +127,16 @@ def main(args):
             estimation_data_path)
     log_extra["status"]["results"] = model.mode_share
 
+    if args.use_fixed_transit_cost:
+        # Raise error if there is no cost matrix in results folder
+        cost_matrix_path = os.path.join(results_path, args.scenario_name, "Matrices", "cost_aht.omx")
+        if not os.path.exists(cost_matrix_path):
+            msg = "Precalculated transit cost matrix not found. " \
+            + "Please uncheck the 'Käytä esilaskettua joukkoliikenteen kustannusmatriisia' " \
+            + "option in Helmet UI's scenario settings to calculate transit cost."
+            log.error(msg)
+            raise FileNotFoundError(msg)
+
     # Run traffic assignment simulation for N iterations,
     # on last iteration model-system will save the results
     log_extra["status"]["state"] = "preparing"

Scripts/helmet_validate_inputfiles.py

@@ -163,9 +163,12 @@ def main(args):
                     attr_space)
                 log.error(msg)
                 raise ValueError(msg)
+            scenarios_with_different_zones = 0
             for scen in emmebank.scenarios():
                 if scen.zone_numbers != zone_numbers:
-                    log.warn("Scenarios with different zones found in EMME bank!")
+                    scenarios_with_different_zones += 1
+            if scenarios_with_different_zones > 0:
+                log.warn(f"{scenarios_with_different_zones} Scenarios with different zones found in EMME bank! Matrices will not be compatible between scenarios with different zones.")
             scen = emmebank.scenario(first_scenario_ids[i])
             if scen is None:
                 msg = "Project {} has no scenario {}".format(emp_path, first_scenario_ids[i])