Skip to content

Commit 97b88f8

Browse files
committed
Fix route description in export.
Use the name of Jore3 route direction as the source instead of route. Resolves HSLdevcom/jore4#1604
1 parent 56ee716 commit 97b88f8

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
SELECT
2-
r.network_route_name AS name,
32
r.network_route_number AS route_number,
43
r.network_route_hidden_variant AS hidden_variant,
54
rd.network_route_direction_id AS direction_id,
65
rd.network_route_direction_type AS direction_type,
6+
rd.network_route_direction_name AS name,
77
l.network_line_jore4_id AS line_jore4_id,
88
rd.network_route_direction_valid_date_range AS valid_date_range,
99
r.network_route_legacy_hsl_municipality_code AS legacy_hsl_municipality_code
1010
FROM network.network_routes r
11-
JOIN network.network_route_directions rd ON (rd.network_route_id = r.network_route_id)
12-
JOIN network.network_lines l ON (l.network_line_id = r.network_line_id)
13-
WHERE isempty(rd.network_route_direction_valid_date_range * '[2021-01-01, 2050-01-01)'::daterange) = false
11+
JOIN network.network_route_directions rd USING (network_route_id)
12+
JOIN network.network_lines l USING (network_line_id)
13+
WHERE NOT isempty(rd.network_route_direction_valid_date_range * '[2021-01-01, 2050-01-01)'::daterange)
1414
ORDER BY rd.network_route_direction_valid_date_range DESC

src/test/java/fi/hsl/jore/importer/config/jobs/ExportRouteStepTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public class ExportRouteStepTest extends BatchIntegrationTest {
5353
private final String EXPECTED_DIRECTION = Jore4RouteDirection.INBOUND.getValue();
5454
private final UUID EXPECTED_LINE_JORE4_ID = UUID.fromString("5aa7d9fc-2cf9-466d-8ac0-f442d60c261f");
5555
private static final String EXPECTED_LABEL = "1";
56-
private static final String EXPECTED_DESCRIPTION = "{\"fi_FI\":\"Keskustori - Etelä-Hervanta vanha\",\"sv_SE\":\"Central torget - Södra Hervanta gamla\"}";
56+
private static final String EXPECTED_DESCRIPTION = "{\"fi_FI\":\"Keskustori - Kaleva - Etelä-Hervanta vanha\",\"sv_SE\":\"Central torget - Kaleva - Södra Hervanta gamla\"}";
5757
private static final int EXPECTED_PRIORITY = 10;
5858
private static final LegacyHslMunicipalityCode EXPECTED_LEGACY_HSL_MUNICIPALITY_CODE = LegacyHslMunicipalityCode.HELSINKI;
5959

src/test/java/fi/hsl/jore/importer/feature/batch/route/RouteExportReaderTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ class WhenSourceTableHasOneRoute {
7676
private final DirectionType EXPECTED_DIRECTION_TYPE = DirectionType.INBOUND;
7777
private final UUID EXPECTED_LINE_JORE4_ID = UUID.fromString("5aa7d9fc-2cf9-466d-8ac0-f442d60c261f");
7878
private static final String EXPECTED_ROUTE_NUMBER = "1";
79-
private static final String EXPECTED_FINNISH_NAME = "Keskustori - Etelä-Hervanta vanha";
80-
private static final String EXPECTED_SWEDISH_NAME = "Central torget - Södra Hervanta gamla";
79+
private static final String EXPECTED_FINNISH_NAME = "Keskustori - Kaleva - Etelä-Hervanta vanha";
80+
private static final String EXPECTED_SWEDISH_NAME = "Central torget - Kaleva - Södra Hervanta gamla";
8181

8282
private final LocalDate EXPECTED_VALID_DATE_RANGE_START = LocalDate.of(2021, 1, 1);
8383
private final LocalDate EXPECTED_VALID_DATE_RANGE_END = LocalDate.of(2022, 1, 1);

0 commit comments

Comments
 (0)