Skip to content

Commit cc40297

Browse files
author
Janne Rönkkö
committed
Do not use durations as input when updating durations
1 parent a4dec70 commit cc40297

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

.github/workflows/shared-run-e2e.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,16 @@ jobs:
190190
# longer present.
191191
# Therefore to only include existing spects and use the actual test duration, the durations are not given as input
192192
# for cypress-split when durations are going to be updated
193-
if: ${{ inputs.update-e2e-test-durations }}
193+
#
194+
# The following describe where you can find the implementation details so you can check if the details have changed
195+
#
196+
# You can find the cypress-split-merge from https://github.com/bahmutov/cypress-split/blob/0ba18be998f9d21eee27c1d78a06c33bc60a6d05/bin/merge.js
197+
# which is calling mergeSplitTimings function (https://github.com/bahmutov/cypress-split/blob/0ba18be998f9d21eee27c1d78a06c33bc60a6d05/src/timings.js#L111)
198+
# to merge durations.
199+
#
200+
# The implementation keeping all durations from the input duration files can be found from
201+
# https://github.com/bahmutov/cypress-split/blob/0ba18be998f9d21eee27c1d78a06c33bc60a6d05/src/index.js#L213
202+
if: ${{ ! inputs.update-e2e-test-durations }}
194203
shell: bash
195204
run: |
196205
curl \

0 commit comments

Comments
 (0)