Get update history data for terminals

Author: suvikankare

cypress/e2e/stop-registry/terminals.cy.ts

@@ -239,6 +239,12 @@ describe('Terminal details', () => {
         .validityPeriod()
         .should('contain', '1.1.2020-1.1.2050');
 
+      terminalDetailsPage.versioningRow
+        .getChangeHistoryLink()
+        .shouldBeVisible()
+        .invoke('text')
+        .should('match', /\d{2}\.\d{2}\.\d{4}\s+\d{2}:\d{2}/); // Matches format: DD.MM.YYYY HH:mm
+
       verifyInitialBasicDetails();
     });
 

cypress/pageObjects/stop-registry/terminals/TerminalVersioningRow.ts

@@ -4,4 +4,7 @@ export class TerminalVersioningRow {
 
   getEditValidityButton = () =>
     cy.getByTestId('TerminalVersioningRow::editTerminalValidityButton');
+
+  getChangeHistoryLink = () =>
+    cy.getByTestId('TerminalVersioningRow::changeHistoryLink');
 }

ui/src/components/stop-registry/terminals/components/terminal-versions/TerminalVersioningRow.tsx

@@ -1,12 +1,15 @@
 import { FC } from 'react';
 import { useTranslation } from 'react-i18next';
+import { Link } from 'react-router';
 import { twMerge } from 'tailwind-merge';
-import { mapToShortDate } from '../../../../../time';
+import { Path, routeDetails } from '../../../../../router/routeDetails';
+import { mapToShortDate, mapUTCToDateTime } from '../../../../../time';
 import { TerminalComponentProps } from '../../types';
 import { EditTerminalValidityButton } from './EditTerminalValidityButton';
 
 const testIds = {
   validityPeriod: 'TerminalVersioningRow::validityPeriod',
+  changeHistoryLink: 'TerminalVersioningRow::changeHistoryLink',
 };
 
 export const TerminalVersioningRow: FC<TerminalComponentProps> = ({
@@ -16,7 +19,7 @@ export const TerminalVersioningRow: FC<TerminalComponentProps> = ({
   const { t } = useTranslation();
 
   return (
-    <div className={twMerge('flex items-center gap-2', className)}>
+    <div className={twMerge('my-4 flex items-center gap-2', className)}>
       <h2>{t('terminalDetails.title')}</h2>
 
       <div
@@ -29,6 +32,18 @@ export const TerminalVersioningRow: FC<TerminalComponentProps> = ({
       </div>
 
       <EditTerminalValidityButton terminal={terminal} />
+
+      <Link
+        to={routeDetails[Path.terminalDetails].getLink(
+          terminal.privateCode?.value,
+        )}
+        className="ml-auto flex items-center text-base text-tweaked-brand hover:underline"
+        data-testid={testIds.changeHistoryLink}
+      >
+        {mapUTCToDateTime(terminal.changed)} |{' '}
+        {terminal.changedByUserName ?? 'HSL'}{' '}
+        <i className="icon-history text-xl" aria-hidden />
+      </Link>
     </div>
   );
 };

ui/src/components/stop-registry/terminals/hooks/useGetParentStopPlaceChangeHistory.ts

@@ -0,0 +1,76 @@
+import { gql } from '@apollo/client';
+import {
+  StopsDatabaseStopPlaceBoolExp,
+  useGetLatestParentStopPlaceChangeQuery,
+  useGetParentStopPlaceChangeHistoryQuery,
+} from '../../../../generated/graphql';
+
+const GQL_GET_PARENT_STOP_PLACE_CHANGE_HISTORY = gql`
+  query GetParentStopPlaceChangeHistory(
+    $where: stops_database_stop_place_bool_exp!
+  ) {
+    stopsDb: stops_database {
+      stopPlace: stops_database_stop_place(
+        where: $where
+        order_by: { version: desc }
+      ) {
+        changed
+        changed_by
+        private_code_value
+        version
+        version_comment
+      }
+    }
+  }
+`;
+
+const GQL_GET_LATEST_PARENT_STOP_PLACE_CHANGE = gql`
+  query GetLatestParentStopPlaceChange(
+    $where: stops_database_stop_place_bool_exp!
+  ) {
+    stopsDb: stops_database {
+      stopPlace: stops_database_stop_place(
+        where: $where
+        order_by: { version: desc }
+        limit: 1
+      ) {
+        changed
+        changed_by
+        private_code_value
+      }
+    }
+  }
+`;
+
+export function useGetParentStopPlaceChangeHistory(
+  where: StopsDatabaseStopPlaceBoolExp,
+) {
+  const { data, ...rest } = useGetParentStopPlaceChangeHistoryQuery({
+    variables: { where },
+  });
+
+  const parentStopPlaceVersions = data?.stopsDb?.stopPlace ?? [];
+
+  return {
+    ...rest,
+    parentStopPlaceVersions,
+  };
+}
+
+export function useGetLatestParentStopPlaceChange(
+  where: StopsDatabaseStopPlaceBoolExp,
+) {
+  const { data, ...rest } = useGetLatestParentStopPlaceChangeQuery({
+    variables: { where },
+  });
+
+  const latestParentStopPlace = data?.stopsDb?.stopPlace?.[0];
+
+  const latestParentStopPlaceChangeData = {
+    changed: latestParentStopPlace?.changed ?? null,
+    changedBy: latestParentStopPlace?.changed_by ?? null,
+    privateCode: latestParentStopPlace?.private_code_value ?? null,
+  };
+
+  return { ...rest, latestParentStopPlaceChangeData };
+}

ui/src/components/stop-registry/terminals/hooks/useGetTerminalDetails.ts

@@ -7,6 +7,7 @@ import {
   useGetParentStopPlaceDetailsQuery,
 } from '../../../../generated/graphql';
 import {
+  useGetUserNames,
   useObservationDateQueryParam,
   useRequiredParams,
 } from '../../../../hooks';
@@ -15,6 +16,7 @@ import {
   getParentStopPlaceDetailsForEnrichment,
   getParentStopPlacesFromQueryResult,
 } from '../../../../utils';
+import { useGetLatestParentStopPlaceChange } from './useGetParentStopPlaceChangeHistory';
 
 const GQL_GET_PARENT_STOP_PLACE_DETAILS = gql`
   query getParentStopPlaceDetails(
@@ -169,21 +171,37 @@ const GQL_GET_PARENT_STOP_PLACE_DETAILS = gql`
 
 export function getEnrichedParentStopPlace(
   parentStopPlace: ParentStopPlaceDetailsFragment | null | undefined,
+  getUserNameById?: (userId: string | null | undefined) => string | null,
+  parentStopPlaceChangeData?: {
+    changed: string | null;
+    changedBy: string | null;
+  },
 ): EnrichedParentStopPlace | null {
   if (!parentStopPlace) {
     return null;
   }
 
+  const changeData = parentStopPlaceChangeData;
+  const changedByUserName = getUserNameById?.(changeData?.changedBy);
+
   return {
     ...parentStopPlace,
     ...getParentStopPlaceDetailsForEnrichment(
       parentStopPlace as StopRegistryParentStopPlace,
     ),
+    changed: changeData?.changed,
+    changedBy: changeData?.changedBy,
+    changedByUserName,
   } as EnrichedParentStopPlace;
 }
 
 function useGetParentStopPlaceDetailsByWhere(
   where: StopsDatabaseStopPlaceNewestVersionBoolExp | null,
+  getUserNameById: (userId: string | null | undefined) => string | null,
+  parentStopPlaceChangeData?: {
+    changed: string | null;
+    changedBy: string | null;
+  },
 ) {
   const { data, ...rest } = useGetParentStopPlaceDetailsQuery(
     where ? { variables: { where } } : { skip: true },
@@ -194,8 +212,13 @@ function useGetParentStopPlaceDetailsByWhere(
       data?.stopsDb?.newestVersion.at(0)?.TiamatStopPlace,
     ).at(0);
   const parentStopPlaceDetails = useMemo(
-    () => getEnrichedParentStopPlace(rawParentStopPlace),
-    [rawParentStopPlace],
+    () =>
+      getEnrichedParentStopPlace(
+        rawParentStopPlace,
+        getUserNameById,
+        parentStopPlaceChangeData,
+      ),
+    [rawParentStopPlace, getUserNameById, parentStopPlaceChangeData],
   );
 
   return { ...rest, parentStopPlaceDetails };
@@ -229,12 +252,22 @@ function useGetParentStopPlaceDetailsWhereConditionsWithDate(): StopsDatabaseSto
 }
 
 export function useGetParentStopPlaceDetails() {
+  const { getUserNameById } = useGetUserNames();
+
+  const { latestParentStopPlaceChangeData } = useGetLatestParentStopPlaceChange(
+    useGetParentStopPlaceDetailsWhereConditions(),
+  );
+
   const validResult = useGetParentStopPlaceDetailsByWhere(
     useGetParentStopPlaceDetailsWhereConditionsWithDate(),
+    getUserNameById,
+    latestParentStopPlaceChangeData,
   );
 
   const fallbackResult = useGetParentStopPlaceDetailsByWhere(
     useGetParentStopPlaceDetailsWhereConditions(),
+    getUserNameById,
+    latestParentStopPlaceChangeData,
   );
 
   const hasValidData = !!validResult.parentStopPlaceDetails;