StopSearch: Make municipality filter more robust

Instead of using hard coded mapping of municiplaity name to database
ID, perform the search with a join to actual DB entity witht a proper
name.

Author: Huulivoide

ui/src/components/stop-registry/search/by-stop/filtersToQueryVariables.ts

@@ -1,9 +1,6 @@
 import isEmpty from 'lodash/isEmpty';
 import { StopsDatabaseQuayNewestVersionBoolExp } from '../../../../generated/graphql';
-import {
-  StopRegistryMunicipality,
-  knownPriorityValues,
-} from '../../../../types/enums';
+import { knownPriorityValues } from '../../../../types/enums';
 import {
   AllOptionEnum,
   NullOptionEnum,
@@ -63,15 +60,8 @@ function buildSearchStopsMunicipalityFilter({
 
   return {
     stop_place: {
-      topographic_place_id: {
-        _in: municipalities.map(
-          (name) =>
-            (
-              StopRegistryMunicipality as unknown as Readonly<
-                Record<StringMunicipality, number>
-              >
-            )[name as StringMunicipality],
-        ),
+      topographic_place: {
+        name_value: { _in: municipalities },
       },
     },
   };

ui/src/components/stop-registry/search/types/StringMunicipality.ts

@@ -1,8 +1,13 @@
-import { StopRegistryMunicipality } from '../../../../types/enums';
-import { numberEnumKeys } from '../../../../utils';
+export const knownMunicipalities = [
+  'Helsinki',
+  'Vantaa',
+  'Espoo',
+  'Kauniainen',
+  'Siuntio',
+  'Kirkkonummi',
+  'Sipoo',
+  'Kerava',
+  'Tuusula',
+] as const;
 
-export const knownMunicipalities = Object.freeze(
-  numberEnumKeys(StopRegistryMunicipality),
-);
-
-export type StringMunicipality = keyof typeof StopRegistryMunicipality;
+export type StringMunicipality = (typeof knownMunicipalities)[number];

ui/src/types/enums.ts

@@ -72,18 +72,6 @@ export enum DayType {
   SU = 9, // Sunday
 }
 
-export enum StopRegistryMunicipality {
-  Helsinki = 3,
-  Vantaa = 4,
-  Espoo = 5,
-  Kauniainen = 6,
-  Siuntio = 7,
-  Kirkkonummi = 8,
-  Sipoo = 9,
-  Kerava = 10,
-  Tuusula = 11,
-}
-
 export const knownMunicipalityPrefixes = {
   Helsinki: 'H',
   Vantaa: 'V',