A couple of ideas - JSplitPane and Menus?

[lawson89]

I'm happy to take a crack at adding some items but wanted to run these by you and see if you had any pointers?

[gk-brown]

Sounds good. I can definitely see a case for menus and tool bars - less so for split and tabbed panes, since they are not difficult to construct programmatically and often contain dynamic content.

[lawson89]

Ok so this is definitely the way to go and I opened a PR.

But I think maybe we should go further in letting UILoader be the source of truth.
For example - common properties like ->
@OverRide
public void write(Void value, Writer writer) throws IOException {
startEntityDeclaration(UILoader.class, null, writer);

        appendAttributeDeclaration(NAME, CDATA, writer);
        appendAttributeDeclaration(GROUP, CDATA, writer);

        appendAttributeDeclaration(BORDER, CDATA, writer);
        appendAttributeDeclaration(PADDING, CDATA, writer);
        appendAttributeDeclaration(WEIGHT, CDATA, writer);
        appendAttributeDeclaration(SIZE, CDATA, writer);

        appendAttributeDeclaration(TAB_TITLE, CDATA, writer);
        appendAttributeDeclaration(TAB_ICON, CDATA, writer);

        appendAttributeDeclaration(STYLE, CDATA, writer);
        appendAttributeDeclaration(STYLE_CLASS, CDATA, writer);

And the UILoader already walks the class hierarchy I believe.

Anyway - take a look and let me know

[gk-brown]

I think it's OK for now. Longer term, it would probably make sense to put both DTDEncoder and the previewer app into a single "tools" project where we could also put any shared logic.

The latest version of the app looks great!

[gk-brown]

I created a PR for discussion - let me know what you think.

[gk-brown]

This is a separate bug fix PR: https://github.com/HTTP-RPC/Sierra/pull/37/files?w=1

[gk-brown]

I made these changes and merged the v3.5 branch into master. I also made a couple minor changes that resolved Intellij warnings.

[gk-brown]

I ended up adding support for JSplitPane and JTabbedPane. It wasn't terribly difficult and will probably be useful in some cases.