Skip to content

Conversation

@lawson89
Copy link
Contributor

Pull in RTextScrollPane and configure so gutter shows with line numbers and code folding (hover over gutter)

Copilot AI review requested due to automatic review settings November 20, 2025 20:45
* limitations under the License.
*/
package org.httprpc.sierra.tools.previewer;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you configure your editor so it doesn't reorder imports?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem, will do!

Copilot finished reviewing on behalf of lawson89 November 20, 2025 20:48
editorPane.setCodeFoldingEnabled(true);
editorPane.setAntiAliasingEnabled(true);
editorPane.setEditable(true); // Ensure it's editable
editorPane.setEditable(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it editable by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep good catch, I'll remove

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the Sierra UI Previewer by replacing the standard JScrollPane with RTextScrollPane from the RSyntaxTextArea library, enabling line numbers and code folding indicators in the editor gutter. This improves the developer experience when editing Sierra XML files.

Key Changes:

  • Reorganized imports to follow Java conventions (java., javax., org.* in alphabetical order)
  • Changed editorScrollPane from a UI-injected component (@outlet) to a manually created RTextScrollPane
  • Configured RTextScrollPane with line numbers and fold indicator support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

public MainFrame() {
super("Sierra UI Previewer");

Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Trailing whitespace should be removed for consistency with the rest of the codebase.

Suggested change

Copilot uses AI. Check for mistakes.
@gk-brown gk-brown merged commit 2c6ea23 into HTTP-RPC:master Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants