More updates

Author: tunetheweb

.github/linters/.eslintrc.yml

@@ -15,6 +15,7 @@ globals:
   $WPT_REQUESTS: readonly
   $WPT_TEST_URL: readonly
   httparchive_enable_observations: writable
+  CSSUnparsedValue: readonly
   LaunchParams: readonly
 
 ignorePatterns:
@@ -25,6 +26,9 @@ plugins:
   - n
   - prettier
 
+rules:
+  no-inner-declarations: off
+
 overrides:
   # JSON files
   - files:

bin/create-fugu-apis.js

@@ -16,7 +16,7 @@ const checkURLConditions = (where, url, mimeType, responseBody) => {
   // (https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types#textjavascript).
   if (
     where === "JavaScript" &&
-    /\.m?js/.test(url) &&
+    /\\.m?js/.test(url) &&
     mimeType.toLowerCase().endsWith("script")
   ) {
     return true;

dist/Images.js

@@ -33,7 +33,9 @@ var wptImages = function (win) {
           if (im && im.length) {
             images = images.concat(im);
           }
-        } catch (e) {}
+        } catch (e) {
+          // continue regardless of error
+        }
       }
       if (images.length > 10000) break;
     }

dist/a11y.js

@@ -83,7 +83,7 @@ return JSON.stringify({
       // HEIF
       'heif', 'heic',
     ];
-    const extension_regex = new RegExp(`\.(${image_file_extensions.join('|')})$`, 'i');
+    const extension_regex = new RegExp(`\\.(${image_file_extensions.join('|')})$`, 'i');
 
     let total_elements_with_non_empty_alt = 0;
     let total_with_file_extension = 0;

dist/ads.js

@@ -1,6 +1,5 @@
 //[ads]
 
-const ACCOUNT_TYPES = ['direct', 'reseller'];
 const SELLER_TYPES = ['publisher', 'intermediary', 'both'];
 
 const isPresent = (response, endings) => response.ok && endings.some(ending => response.url.endsWith(ending));
@@ -86,7 +85,7 @@ const parseAdsTxt = async (response) => {
         }
         result.account_count += 1;
       }
-    };
+    }
 
     // Count unique and remove domain Sets for now
     for (let accountType of Object.values(result.account_types)) {
@@ -173,7 +172,7 @@ const parseSellersJSON = async (response) => {
       seller_type.domain_count = seller_type.domains.size;
       seller_type.domains = Array.from(seller_type.domains); // delete seller_type.domains;
     }
-  };
+  }
 
   return result;
 }

dist/almanac.js

@@ -268,12 +268,13 @@ return JSON.stringify({
           // json+ld
           try {
             var content = JSON.parse(node.textContent);
-            var contentLoop = [];
             if (content instanceof Object || content instanceof Array) {
               // nested lookup
               nestedLookup(content, 0);
             }
-          } catch (e) {}
+          } catch (e) {
+            // continue regardless of error
+          }
         }
       }
     }
@@ -313,7 +314,9 @@ return JSON.stringify({
                 } else {
                   navigateHash++;
                 }
-              } catch (e) {}
+              } catch (e) {
+                // continue regardless of error
+              }
             }
           } else if (document.location.hostname !== link.hostname) {
             external++;
@@ -373,7 +376,6 @@ return JSON.stringify({
       wordsCount = 0;
       wordElements = 0;
       var n,
-        nodes = [],
         walk = document.createTreeWalker(
           body,
           NodeFilter.SHOW_ALL,
@@ -471,7 +473,7 @@ return JSON.stringify({
     };
   })(),
   '09.27': (() => {
-    // Returns a JSON array of nodes with a tabindex and their key/value attributes.
+    // Returns a JSON array of nodes with a tabindex and their key/value attributes.
     // We acknowledge that attribute selectors are expensive to query.
     var nodes = document.querySelectorAll('body [tabindex]');
     return parseNodes(nodes, {
@@ -569,10 +571,6 @@ return JSON.stringify({
       max_prop_length: 255,
     };
 
-    const parsed_pictures = parseNodes(pictures, filter_options);
-    const parsed_imgs = parseNodes(imgs, filter_options);
-    const parsed_sources = parseNodes(sources, filter_options);
-
     return {
       pictures: parseNodes(pictures, filter_options),
       imgs: parseNodes(imgs, filter_options),

dist/avg_dom_depth.js

@@ -12,7 +12,8 @@ function avgDomDepth() {
 function numParents(elem) {
   var n = 0;
   if ( elem.parentNode ) {
-    while ( elem = elem.parentNode) {
+    /* eslint-disable-next-line no-cond-assign */
+    while (elem = elem.parentNode) {
       n++;
     }
   }

dist/cms.js

@@ -32,7 +32,9 @@ function getWordPressTheme() {
       theme.child_theme = childTheme.replace( 'wp-child-theme-', '' );
     }
 
-  } catch ( e ) {}
+  } catch ( e ) {
+    // continue regardless of error
+  }
   return theme;
 }
 
@@ -179,7 +181,9 @@ function getWordPressContentType() {
         }
       }
     }
-  } catch ( e ) {}
+  } catch ( e ) {
+    // continue regardless of error
+  }
   return content;
 }
 

dist/crawl_links.js

@@ -15,6 +15,7 @@ const sameOrigin = function(uri1, uri2){
         uri2 = new URL(uri2);
         return uri1.origin == uri2.origin;
     } catch(e) {
+      // continue regardless of error
     }
     return false;
 }
@@ -56,6 +57,7 @@ const getLinks = function(visibleOnly){
                     }
                 }
             } catch (e) {
+              // continue regardless of error
             }
         }
     }

dist/css-variables.js

@@ -214,7 +214,9 @@ function analyzeVariables() {
     try {
       var rules = stylesheet.cssRules;
     }
-    catch (e) { }
+    catch (e) {
+      // continue regardless of error
+    }}
 
     if (rules) {
       for (let rule of rules) {
@@ -286,7 +288,7 @@ function analyzeVariables() {
 
   return { summary, computed };
 
-};
+}
 
 function serialize(data, separator) {
   return JSON.stringify(data, (key, value) => {