From c971865cfdff71a63e6f856bfddfc300e8ced379 Mon Sep 17 00:00:00 2001 From: Yu Tsuno Date: Wed, 15 Jan 2025 13:29:12 +0000 Subject: [PATCH 1/6] updated /.well-known/assetlinks.json parsing --- .github/workflows/wpt-test.yml | 7 +++++++ dist/well-known.js | 18 +++++++++++++++++- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/.github/workflows/wpt-test.yml b/.github/workflows/wpt-test.yml index c2bb5960..ef603da5 100644 --- a/.github/workflows/wpt-test.yml +++ b/.github/workflows/wpt-test.yml @@ -35,6 +35,13 @@ jobs: WPT_API_KEY: ${{ secrets.HA_API_KEY }} PR_BODY: ${{ github.event.pull_request.body }} + - name: Run WebPageTest for on.com + run: node tests/wpt.js + env: + WPT_SERVER: "on.com" + WPT_API_KEY: ${{ secrets.HA_API_KEY }} + PR_BODY: ${{ github.event.pull_request.body }} + - name: Add comment to PR uses: mshick/add-pr-comment@v2 if: always() diff --git a/dist/well-known.js b/dist/well-known.js index 64802a92..9bc4a155 100644 --- a/dist/well-known.js +++ b/dist/well-known.js @@ -81,7 +81,23 @@ function parseResponseWithRedirects(url, parser) { return Promise.all([ // ecommerce - parseResponse('/.well-known/assetlinks.json'), + parseResponse('/.well-known/assetlinks.json', r => { + return r.json().then(data => { + let hasDeepLinking = false; + let hasCredentialSharing = false; + data.forEach(statement => { + if (statement.relation === 'delegate_permission/common.handle_all_urls') { + hasDeepLinking = true; + } else if (statement.relation === 'delegate_permission/common.get_login_creds') { + hasCredentialSharing = true; + } + }); + return { + deep_linking: hasDeepLinking, + credential_sharing: hasCredentialSharing + }; + }); + }), parseResponse('/.well-known/apple-app-site-association'), // privacy sandbox parseResponse('/.well-known/related-website-set.json'), //Related Website Set From 395e4f1c4b83904ca42925b29f0c2dcc44405706 Mon Sep 17 00:00:00 2001 From: Yu Tsuno Date: Thu, 16 Jan 2025 13:19:19 +0000 Subject: [PATCH 2/6] updated /.well-known/assetlinks.json parsing and test URLs --- .github/pull_request_template.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3aa58daf..80e2a210 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -7,4 +7,7 @@ Description of the changes... **Test websites**: -- https://example.com/ +- https://www.on.com/ +- https://www.amazon.co.jp/ +- https://www.libero.it/ + From 6ee4f15c36cc0409af0464e520c3b89c4f69aa80 Mon Sep 17 00:00:00 2001 From: Barry Pollard Date: Thu, 16 Jan 2025 17:17:09 +0000 Subject: [PATCH 3/6] Update .markdown-lint.yml --- .github/linters/.markdown-lint.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/linters/.markdown-lint.yml b/.github/linters/.markdown-lint.yml index 41806ebe..780e06f4 100644 --- a/.github/linters/.markdown-lint.yml +++ b/.github/linters/.markdown-lint.yml @@ -17,6 +17,7 @@ ignores: - ".github/**/*.md" + - ".github/*.md" ############### # Rules by id # From c8ca4d2a63b5241655e92a72def1face476f4bdd Mon Sep 17 00:00:00 2001 From: Barry Pollard Date: Thu, 16 Jan 2025 18:52:17 +0000 Subject: [PATCH 4/6] Update pull_request_template.md --- .github/pull_request_template.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 80e2a210..29789daa 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -7,7 +7,4 @@ Description of the changes... **Test websites**: -- https://www.on.com/ -- https://www.amazon.co.jp/ -- https://www.libero.it/ - +- https://www.example.com/ From a9919fa5c8556aa2394b43c9b0aad7fd1cdc755e Mon Sep 17 00:00:00 2001 From: Barry Pollard Date: Thu, 16 Jan 2025 18:52:37 +0000 Subject: [PATCH 5/6] Update pull_request_template.md --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 29789daa..3aa58daf 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -7,4 +7,4 @@ Description of the changes... **Test websites**: -- https://www.example.com/ +- https://example.com/ From 13e6e91d18d1c4d3fd69ff808cae5cc5a86d6d78 Mon Sep 17 00:00:00 2001 From: Barry Pollard Date: Thu, 16 Jan 2025 18:53:28 +0000 Subject: [PATCH 6/6] Update wpt-test.yml --- .github/workflows/wpt-test.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/wpt-test.yml b/.github/workflows/wpt-test.yml index ef603da5..c2bb5960 100644 --- a/.github/workflows/wpt-test.yml +++ b/.github/workflows/wpt-test.yml @@ -35,13 +35,6 @@ jobs: WPT_API_KEY: ${{ secrets.HA_API_KEY }} PR_BODY: ${{ github.event.pull_request.body }} - - name: Run WebPageTest for on.com - run: node tests/wpt.js - env: - WPT_SERVER: "on.com" - WPT_API_KEY: ${{ secrets.HA_API_KEY }} - PR_BODY: ${{ github.event.pull_request.body }} - - name: Add comment to PR uses: mshick/add-pr-comment@v2 if: always()