Fix Clang and GCC compilation

Author: HUD-Software

interface/core/builtin.h

@@ -24,6 +24,7 @@
     #define HD_HAS_BUILTIN_ATOMIC_FETCH_SUB __has_builtin(__atomic_fetch_sub)
     #define HD_HAS_BUILTIN_DEBUGTRAP __has_builtin(__builtin_debugtrap)
     #define HD_HAS_BUILTIN_ASSUME __has_builtin(__builtin_assume)
+    #define HD_HAS_BUILTIN_UNREACHABLE __has_builtin(__builtin_unreachable)
     #define HD_HAS_BUILTIN_CLZS __has_builtin(__builtin_clzs)
     #define HD_HAS_BUILTIN_CLZ __has_builtin(__builtin_clz)
     #define HD_HAS_BUILTIN_CLZLL __has_builtin(__builtin_clzll)
@@ -49,6 +50,7 @@
     #define HD_HAS_BUILTIN_ATOMIC_FETCH_SUB __has_builtin(__atomic_fetch_sub)
     #define HD_HAS_BUILTIN_DEBUGTRAP __has_builtin(__builtin_debugtrap)
     #define HD_HAS_BUILTIN_ASSUME __has_builtin(__builtin_assume)
+    #define HD_HAS_BUILTIN_UNREACHABLE __has_builtin(__builtin_unreachable)
     #define HD_HAS_BUILTIN_CLZS __has_builtin(__builtin_clzs)
     #define HD_HAS_BUILTIN_CLZ __has_builtin(__builtin_clz)
     #define HD_HAS_BUILTIN_CLZLL __has_builtin(__builtin_clzll)
@@ -74,6 +76,7 @@
     #define HD_HAS_BUILTIN_ATOMIC_FETCH_SUB 0
     #define HD_HAS_BUILTIN_DEBUGTRAP 0
     #define HD_HAS_BUILTIN_ASSUME 1
+    #define HD_HAS_BUILTIN_UNREACHABLE 0
     #define HD_HAS_BUILTIN_CLZS 0
     #define HD_HAS_BUILTIN_CLZ 0
     #define HD_HAS_BUILTIN_CLZLL 0

interface/core/containers/hashset.h

@@ -423,7 +423,7 @@ namespace hud
                 : control_ptr_(control_ptr)
             {
                 hud::check(control_ptr != nullptr);
-                HD_ASSUME(control_ptr != nullptr);
+                HD_ASSUME((control_ptr != nullptr));
             }
 
             constexpr iterator(control_type *control_ptr, slot_type *slot_ptr)

interface/core/defines.h

@@ -47,9 +47,28 @@
         #define HD_RESTRICT __restrict__ // Indicates that a symbol is not aliased in the current scope.
         #define __STDC_WANT_LIB_EXT1__ 1 // Enable bounds-checked functions ( ISO C Safe Array Functions : memcpy_s, strcpy_s, snwprintf_s, etc... )
 
-        #if defined(HD_HAS_BUILTIN_ASSUME)
+        #if !defined(HD_RELEASE)
+
+        #endif
+        #if defined(HD_COMPILER_CLANG) && defined(HD_HAS_BUILTIN_ASSUME)
             #define HD_ASSUME(cond) __builtin_assume(cond)
+        #else
+            #if defined(HD_HAS_BUILTIN_UNREACHABLE)
+                #define HD_ASSUME(cond)              \
+                    do                               \
+                    {                                \
+                        if (!(cond))                 \
+                            __builtin_unreachable(); \
+                    } while (false)
+            #else
+                #define HD_ASSUME                           \
+                    do                                      \
+                    {                                       \
+                        static_cast<void>(false && (cond)); \
+                    } while (false)
+            #endif
         #endif
+
         #if defined(HD_COMPILER_CLANG)
             #if __has_feature(address_sanitizer)
                 #define HD_USE_ADDRESS_SANITIZER 1

interface/core/i128/i128_portable.h

@@ -1002,10 +1002,12 @@ namespace hud
             {
                 if (u64 hi = n.high_)
                 {
+                    hud::check(hi != 0);
                     HD_ASSUME(hi != 0);
                     return 127 - hud::bits::leading_zero(hi);
                 }
                 const u64 low = n.low_;
+                hud::check(low != 0);
                 HD_ASSUME(low != 0);
                 return 63 - hud::bits::leading_zero(low);
             };

interface/core/os_linux/bits.h

@@ -168,6 +168,7 @@ namespace hud::os::linux
             return value == 0 ? 64 : os::common::bits::trailing_zero(value);
 #endif
         }
-    }; // namespace hud::os::linux
+    };
+} // namespace hud::os::linux
 
 #endif // HD_INC_CORE_OS_LINUX_BITS_H

src/CMakeLists.txt

@@ -5,7 +5,6 @@ cmake_minimum_required(VERSION 3.24)
 # source_files variable is a list all files in Implementation and Interface directory
 set( src
 	hash/crc32.cpp
-	containers/hashset.cpp
 )
 #Linux implementations
 if(UNIX AND NOT APPLE)

src/containers/hashmap.cpp

@@ -1,5 +1,7 @@
 #ifndef HD_PRECOMPILED
 #define HD_PRECOMPILED
+#include <stdarg.h>
+#include <memory>
 #include <core/minimal.h>
 
 #endif // HD_PRECOMPILED