Fix memory corruption and enable sanitizer for debug debugrelease

Author: HUD-Software

interface/core/memory/memory.h

@@ -538,6 +538,7 @@ namespace hud
             return set_memory(buffer, buffer_size * sizeof(type_t), value);
         }
 
+    private:
         /**
          * Sets the first `size` bytes of the block of memory pointed to by `destination` to the specified `value`.
          * This safe version ensures that the operation is not removed by the compiler due to optimization.
@@ -561,6 +562,7 @@ namespace hud
             // return destination;
         }
 
+    public:
         /**
          * Sets the first `size` bytes of the block of memory pointed to by `destination` to the specified `value`.
          * This safe version ensures that the operation is not removed by the compiler due to optimization.
@@ -715,19 +717,6 @@ namespace hud
             return static_cast<type_t *>(set_memory_zero(buffer, buffer_size * sizeof(type_t)));
         }
 
-        /**
-         * Sets the first `size` bytes of the block of memory pointed by `destination` to zero.
-         * This safe version ensures that the operation is not removed by the compiler due to optimization.
-         * `destination` is volatile to prevent memset to be remove by the compiler optimisation
-         * @param destination Pointer to the buffer. Must not be null.
-         * @param size Number of bytes to set to zero
-         * @return Pointer to the buffer `destination`.
-         */
-        static HD_FORCEINLINE void *set_memory_zero_safe(void *destination, const usize size) noexcept
-        {
-            return set_memory_safe(destination, size, 0);
-        }
-
         /**
          * Sets the first `size` bytes of the block of memory pointed by `destination` to zero.
          * This safe version ensures that the operation is not removed by the compiler due to optimization.
@@ -751,7 +740,7 @@ namespace hud
          * @return Pointer to the buffer `destination`.
          */
         template<typename type_t>
-        requires(!hud::is_integral_v<type_t> && !hud::is_pointer_v<type_t>)
+        requires(!hud::is_integral_v<type_t> && !hud::is_pointer_v<type_t> && hud::is_trivially_copyable_v<type_t>)
         static HD_FORCEINLINE type_t *set_memory_zero_safe(type_t *destination, const usize size) noexcept
         {
             return set_memory_safe(destination, size, 0);
@@ -782,7 +771,7 @@ namespace hud
             // LCOV_EXCL_STOP
             else
             {
-                return static_cast<type_t *>(set_memory_safe(static_cast<void *>(destination), size, 0));
+                return static_cast<type_t *>(set_memory_safe(destination, size, 0));
             }
         }
 
@@ -811,7 +800,7 @@ namespace hud
             // LCOV_EXCL_STOP
             else
             {
-                return static_cast<type_t *>(set_memory_zero_safe(static_cast<void *>(destination), size));
+                return static_cast<type_t *>(set_memory_safe(destination, size, 0));
             }
         }
 
@@ -825,9 +814,10 @@ namespace hud
          * @return Pointer to the `buffer`.
          */
         template<typename type_t, usize buffer_size>
+        requires(hud::is_trivially_copyable_v<type_t>)
         static HD_FORCEINLINE constexpr type_t *set_memory_zero_safe(type_t (&buffer)[buffer_size]) noexcept
         {
-            return static_cast<type_t *>(set_memory_zero_safe(buffer, buffer_size * sizeof(type_t)));
+            return static_cast<type_t *>(set_memory_safe(buffer, buffer_size * sizeof(type_t), 0));
         }
 
         /**

test/CMakeLists.txt

@@ -441,7 +441,7 @@ else()
 	add_test(NAME ${lib_name} COMMAND ${test_project_name} --gtest_output=xml:${test_project_name}_report.xml --extra-verbose --gtest_break_on_failure)
 endif()
 
-if(SANITIZER)
+if( CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo" OR SANITIZER)
 	include(../sanitizer.cmake)
 	enable_sanitizer(${test_project_name} ${lib_name})
 endif()

test/memory/memory_set_zero.cpp

@@ -109,8 +109,16 @@ GTEST_TEST(memory, set_memory_zero_safe_c_array)
 
 GTEST_TEST(memory, set_memory_zero_safe_object_to_buffer)
 {
-    hud_test::non_bitwise_type buf[3] = {2, 4, 8};
-    const u8 zero_buffer[sizeof(hud_test::non_bitwise_type) * 3] = {0};
-    hud::memory::set_memory_zero_safe(buf, 3 * sizeof(hud_test::non_bitwise_type));
-    hud_assert_true(hud::memory::is_memory_compare_equal(buf, zero_buffer, sizeof(hud_test::non_bitwise_type) * 3));
+    struct bitwise
+    {
+        u32 a;
+        u8 b;
+        f32 c;
+    };
+
+    bitwise buf[3];
+
+    const u8 zero_buffer[sizeof(bitwise) * 3] = {0};
+    hud::memory::set_memory_zero_safe(buf);
+    hud_assert_true(hud::memory::is_memory_compare_equal(buf, zero_buffer, sizeof(bitwise) * 3));
 }