As slice on cstring_view and wstring_view

Author: Julian LALU

interface/core/slice.h

@@ -54,8 +54,7 @@ namespace hud
         /** Move assign the slice. */
         HD_FORCEINLINE constexpr slice &operator=(slice &&other) noexcept
         {
-            if (this != &other)
-            {
+            if (this != &other) {
                 begin_ptr = other.begin_ptr;
                 other.begin_ptr = nullptr;
                 count_element = other.count_element;
@@ -188,9 +187,9 @@ namespace hud
         }
 
     private:
-        /** Pointer to the first element */
+        /** Pointer to the first element. */
         type_t *begin_ptr = nullptr;
-        /** Count of elements */
+        /** Count of elements. */
         usize count_element = 0u;
     };
 

interface/core/string/cstring_view.h

@@ -232,10 +232,21 @@ namespace hud
          * @return A slice representing all characters of this string.
          */
         [[nodiscard]]
-        constexpr hud::slice<char_type> slice() const noexcept
+        constexpr const hud::slice<char_type> as_slice() const noexcept
         {
             return hud::slice<char_type> {ptr_, length()};
         }
+
+        /**
+         * Returns a slice view of the string.
+         * @return A slice representing all characters of this string.
+         */
+        [[nodiscard]]
+        constexpr hud::slice<char_type> as_slice() noexcept
+        {
+            return hud::slice<char_type> {ptr_, length()};
+        }
+
         /**
          * Provides read-only access to a character at a given index.
          * @param i Index of the character to access.

interface/core/string/wstring_view.h

@@ -250,7 +250,17 @@ namespace hud
          * @return A slice representing all characters of this string.
          */
         [[nodiscard]]
-        constexpr hud::slice<char_type> slice() const noexcept
+        constexpr const hud::slice<char_type> as_slice() const noexcept
+        {
+            return hud::slice<char_type> {ptr_, length()};
+        }
+
+        /**
+         * Returns a slice view of the string.
+         * @return A slice representing all characters of this string.
+         */
+        [[nodiscard]]
+        constexpr hud::slice<char_type> as_slice() noexcept
         {
             return hud::slice<char_type> {ptr_, length()};
         }

test/string/cstring_view.cpp

@@ -563,3 +563,45 @@ GTEST_TEST(cstring_view, to_lowercase_partial)
     v.to_lowercase_partial(2);
     hud_assert_true(txt[0] == 'a' && txt[1] == 'b' && txt[2] == 'C' && txt[3] == '1' && txt[4] == '2' && txt[5] == '3' && txt[6] == ',' && txt[7] == ';' && txt[8] == ':' && txt[9] == '!' && txt[10] == '\0');
 }
+
+GTEST_TEST(cstring_view, slice)
+{
+    hud::cstring_view const_v {"ABC"};
+    auto const_s = const_v.as_slice();
+    auto const_begin = const_s.begin();
+    hud_assert_true(*const_begin == 'A');
+    const_begin++;
+    hud_assert_true(*const_begin == 'B');
+    const_begin++;
+    hud_assert_true(*const_begin == 'C');
+    const_begin++;
+    hud_assert_true(const_begin == const_s.end());
+
+    ansichar txt[] = "ABC";
+    hud::cstring_view v {txt};
+    auto s = v.as_slice();
+    auto begin = s.begin();
+    hud_assert_true(*begin == 'A');
+    begin++;
+    hud_assert_true(*begin == 'B');
+    begin++;
+    hud_assert_true(*begin == 'C');
+    begin++;
+    hud_assert_true(begin == s.end());
+
+    auto const_s_1 = v.as_slice().sub_slice(0, 2);
+    auto const_begin_1 = const_s_1.begin();
+    hud_assert_true(*const_begin_1 == 'A');
+    const_begin_1++;
+    hud_assert_true(*const_begin_1 == 'B');
+    const_begin_1++;
+    hud_assert_true(const_begin_1 == const_s_1.end());
+
+    s = v.as_slice().sub_slice(0, 2);
+    begin = s.begin();
+    hud_assert_true(*begin == 'A');
+    begin++;
+    hud_assert_true(*begin == 'B');
+    begin++;
+    hud_assert_true(begin == s.end());
+}

test/string/wstring_view.cpp

@@ -562,4 +562,46 @@ GTEST_TEST(wstring_view, to_lowercase_partial)
     hud::wstring_view v(txt);
     v.to_lowercase_partial(2);
     hud_assert_true(txt[0] == L'a' && txt[1] == L'b' && txt[2] == L'C' && txt[3] == L'1' && txt[4] == L'2' && txt[5] == L'3' && txt[6] == L',' && txt[7] == L';' && txt[8] == L':' && txt[9] == L'!' && txt[10] == '\0');
+}
+
+GTEST_TEST(wstring_view, slice)
+{
+    hud::wstring_view const_v {L"ABC"};
+    auto const_s = const_v.as_slice();
+    auto const_begin = const_s.begin();
+    hud_assert_true(*const_begin == L'A');
+    const_begin++;
+    hud_assert_true(*const_begin == L'B');
+    const_begin++;
+    hud_assert_true(*const_begin == L'C');
+    const_begin++;
+    hud_assert_true(const_begin == const_s.end());
+
+    wchar txt[] = L"ABC";
+    hud::wstring_view v {txt};
+    auto s = v.as_slice();
+    auto begin = s.begin();
+    hud_assert_true(*begin == L'A');
+    begin++;
+    hud_assert_true(*begin == L'B');
+    begin++;
+    hud_assert_true(*begin == L'C');
+    begin++;
+    hud_assert_true(begin == s.end());
+
+    auto const_s_1 = v.as_slice().sub_slice(0, 2);
+    auto const_begin_1 = const_s_1.begin();
+    hud_assert_true(*const_begin_1 == L'A');
+    const_begin_1++;
+    hud_assert_true(*const_begin_1 == L'B');
+    const_begin_1++;
+    hud_assert_true(const_begin_1 == const_s_1.end());
+
+    s = v.as_slice().sub_slice(0, 2);
+    begin = s.begin();
+    hud_assert_true(*begin == L'A');
+    begin++;
+    hud_assert_true(*begin == L'B');
+    begin++;
+    hud_assert_true(begin == s.end());
 }