Skip to content

Commit e1295ac

Browse files
author
Julian LALU
committed
Improve comments
1 parent fd5d52b commit e1295ac

13 files changed

+223
-337
lines changed

‎test/shared_pointer/multi_thread/shared_pointer_multi_thread_assignments.cpp‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ GTEST_TEST(shared_pointer_safe, copy_assignement_same_type)
5353
}
5454

5555
// Constant is not available with thread safe SharedPointer
56-
// Not working under with msvc
57-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
5856
/* #if !defined(HD_COMPILER_MSVC)
5957
{
6058
constexpr auto result = test(123);
@@ -132,8 +130,6 @@ GTEST_TEST(shared_pointer_safe, copy_assignement_different_type)
132130
}
133131

134132
// Constant is not available with thread safe SharedPointer
135-
// Not working under with msvc
136-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
137133
/*#if !defined(HD_COMPILER_MSVC)
138134
{
139135
constexpr auto result = test(123);
@@ -183,8 +179,6 @@ GTEST_TEST(shared_pointer_safe, copy_assignement_an_empty_same_type)
183179
}
184180

185181
// Constant is not available with thread safe SharedPointer
186-
// Not working under with msvc
187-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
188182
/* #if !defined(HD_COMPILER_MSVC)
189183
{
190184
constexpr auto result = test(123);
@@ -219,8 +213,6 @@ GTEST_TEST(shared_pointer_safe, copy_assignement_nullptr)
219213
}
220214

221215
// Constant is not available with thread safe SharedPointer
222-
// Not working under with msvc
223-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
224216
/*#if !defined(HD_COMPILER_MSVC)
225217
{
226218
constexpr auto result = test(123);
@@ -272,8 +264,6 @@ GTEST_TEST(shared_pointer_safe, move_assignement_same_type)
272264
}
273265

274266
// Constant is not available with thread safe SharedPointer
275-
// Not working under with msvc
276-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
277267
/*#if !defined(HD_COMPILER_MSVC)
278268
{
279269
constexpr auto result = test(123);
@@ -333,8 +323,6 @@ GTEST_TEST(shared_pointer_safe, move_assignement_different_type)
333323
}
334324

335325
// Constant is not available with thread safe SharedPointer
336-
// Not working under with msvc
337-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
338326
/*#if !defined(HD_COMPILER_MSVC)
339327
{
340328
constexpr auto result = test(123);
@@ -378,8 +366,6 @@ GTEST_TEST(shared_pointer_safe, move_assignement_an_empty_same_type)
378366
}
379367

380368
// Constant is not available with thread safe SharedPointer
381-
// Not working under with msvc
382-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
383369
/* #if !defined(HD_COMPILER_MSVC)
384370
{
385371
constexpr auto result = test(123);
@@ -414,8 +400,6 @@ GTEST_TEST(shared_pointer_safe, move_assignement_nullptr)
414400
}
415401

416402
// Constant is not available with thread safe SharedPointer
417-
// Not working under with msvc
418-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
419403
/* #if !defined(HD_COMPILER_MSVC)
420404
{
421405
constexpr auto result = test(123);
@@ -450,8 +434,6 @@ GTEST_TEST(shared_pointer_safe, copy_assignement_same_shared_pointer)
450434
}
451435

452436
// Constant is not available with thread safe SharedPointer
453-
// Not working under with msvc
454-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
455437
/*#if !defined(HD_COMPILER_MSVC)
456438
{
457439
constexpr auto result = test(123);
@@ -486,8 +468,6 @@ GTEST_TEST(shared_pointer_safe, move_assignement_same_shared_pointer)
486468
}
487469

488470
// Constant is not available with thread safe SharedPointer
489-
// Not working under with msvc
490-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
491471
/* #if !defined(HD_COMPILER_MSVC)
492472
{
493473
constexpr auto result = test(123);

‎test/shared_pointer/multi_thread/shared_pointer_multi_thread_comparison.cpp‎

Lines changed: 33 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ GTEST_TEST(shared_pointer_safe, equal_operator)
4141
}
4242

4343
// Constant is not available with thread safe SharedPointer
44-
// Not working under with msvc
45-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
4644
/*#if !defined(HD_COMPILER_MSVC)
4745
{
4846
constexpr auto result = test();
@@ -100,23 +98,21 @@ GTEST_TEST(shared_pointer_safe, not_equal_operator)
10098
}
10199

102100
// Constant is not available with thread safe SharedPointer
103-
// Not working under with msvc
104-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
105101
/* #if !defined(HD_COMPILER_MSVC)
106-
{
107-
constexpr auto result = test();
108-
hud_assert_false(std::get<0>(result));
109-
hud_assert_true(std::get<1>(result));
110-
hud_assert_false(std::get<2>(result));
111-
hud_assert_false(std::get<3>(result));
112-
hud_assert_true(std::get<4>(result));
113-
hud_assert_true(std::get<5>(result));
114-
hud_assert_false(std::get<6>(result));
115-
hud_assert_true(std::get<7>(result));
116-
hud_assert_false(std::get<8>(result));
117-
hud_assert_true(std::get<9>(result));
118-
}
119-
#endif*/
102+
{
103+
constexpr auto result = test();
104+
hud_assert_false(std::get<0>(result));
105+
hud_assert_true(std::get<1>(result));
106+
hud_assert_false(std::get<2>(result));
107+
hud_assert_false(std::get<3>(result));
108+
hud_assert_true(std::get<4>(result));
109+
hud_assert_true(std::get<5>(result));
110+
hud_assert_false(std::get<6>(result));
111+
hud_assert_true(std::get<7>(result));
112+
hud_assert_false(std::get<8>(result));
113+
hud_assert_true(std::get<9>(result));
114+
}
115+
#endif*/
120116
}
121117

122118
GTEST_TEST(shared_pointer_safe, less_operator)
@@ -189,8 +185,6 @@ GTEST_TEST(shared_pointer_safe, less_operator)
189185

190186
// Constant
191187
// Not testable due to lack of pointer sort at compile time
192-
// Not working under with msvc
193-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
194188
/*#if !defined(HD_COMPILER_MSVC)
195189
{
196190
constexpr auto result = test();
@@ -283,28 +277,26 @@ GTEST_TEST(shared_pointer_safe, less_equal_operator)
283277

284278
// Constant
285279
// Not testable due to lack of pointer sort at compile time
286-
// Not working under with msvc
287-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
288280
/*#if !defined(HD_COMPILER_MSVC)
289-
{
290-
constexpr auto result = test();
291-
hud_assert_true(std::get<0>(result));
292-
hud_assert_true(std::get<1>(result));
293-
hud_assert_true(std::get<2>(result));
294-
hud_assert_false(std::get<3>(result));
295-
hud_assert_true(std::get<4>(result));
296-
hud_assert_true(std::get<5>(result));
297-
hud_assert_false(std::get<6>(result));
298-
hud_assert_false(std::get<7>(result));
299-
hud_assert_true(std::get<8>(result));
300-
hud_assert_true(std::get<9>(result));
301-
hud_assert_false(std::get<10>(result));
302-
hud_assert_false(std::get<11>(result));
303-
hud_assert_true(std::get<12>(result));
304-
hud_assert_true(std::get<13>(result));
305-
hud_assert_true(std::get<14>(result));
306-
}
307-
#endif*/
281+
{
282+
constexpr auto result = test();
283+
hud_assert_true(std::get<0>(result));
284+
hud_assert_true(std::get<1>(result));
285+
hud_assert_true(std::get<2>(result));
286+
hud_assert_false(std::get<3>(result));
287+
hud_assert_true(std::get<4>(result));
288+
hud_assert_true(std::get<5>(result));
289+
hud_assert_false(std::get<6>(result));
290+
hud_assert_false(std::get<7>(result));
291+
hud_assert_true(std::get<8>(result));
292+
hud_assert_true(std::get<9>(result));
293+
hud_assert_false(std::get<10>(result));
294+
hud_assert_false(std::get<11>(result));
295+
hud_assert_true(std::get<12>(result));
296+
hud_assert_true(std::get<13>(result));
297+
hud_assert_true(std::get<14>(result));
298+
}
299+
#endif*/
308300
}
309301

310302
GTEST_TEST(shared_pointer_safe, greater_operator)
@@ -377,8 +369,6 @@ GTEST_TEST(shared_pointer_safe, greater_operator)
377369

378370
// Constant
379371
// Not testable due to lack of pointer sort at compile time
380-
// Not working under with msvc
381-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
382372
/*#if !defined(HD_COMPILER_MSVC)
383373
{
384374
constexpr auto result = test();
@@ -471,8 +461,6 @@ GTEST_TEST(shared_pointer_safe, greater_equal_operator)
471461

472462
// Constant
473463
// Not testable due to lack of pointer sort at compile time
474-
// Not working under with msvc
475-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
476464
/*#if !defined(HD_COMPILER_MSVC)
477465
{
478466
constexpr auto result = test();

‎test/shared_pointer/multi_thread/shared_pointer_multi_thread_constructors.cpp‎

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ GTEST_TEST(shared_pointer_safe, default_constructor)
88
hud::shared_pointer<hud_test::non_bitwise_type, hud::thread_safety_e::safe> shared_ptr;
99
return std::tuple {
1010
shared_ptr.pointer() == nullptr,
11-
shared_ptr.shared_count()};
11+
shared_ptr.shared_count()
12+
};
1213
};
1314

1415
// Non constant
@@ -34,7 +35,8 @@ GTEST_TEST(shared_pointer_safe, param_constructor_nullptr)
3435
hud::shared_pointer<hud_test::non_bitwise_type, hud::thread_safety_e::safe> shared_ptr(nullptr);
3536
return std::tuple {
3637
shared_ptr.pointer() == nullptr,
37-
shared_ptr.shared_count()};
38+
shared_ptr.shared_count()
39+
};
3840
};
3941

4042
// Non constant
@@ -64,7 +66,8 @@ GTEST_TEST(shared_pointer_safe, param_constructor_same_type)
6466
shared_ptr.pointer() == type,
6567
shared_ptr.shared_count(),
6668
shared_ptr.pointer()->id(),
67-
dtor_count};
69+
dtor_count
70+
};
6871
};
6972

7073
// Non constant
@@ -77,8 +80,6 @@ GTEST_TEST(shared_pointer_safe, param_constructor_same_type)
7780
}
7881

7982
// Constant is not available with thread safe SharedPointer
80-
// Not working under with msvc
81-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
8283
/*#if !defined(HD_COMPILER_MSVC)
8384
{
8485
constexpr auto result = test(123);
@@ -102,7 +103,8 @@ GTEST_TEST(shared_pointer_safe, param_constructor_different_type)
102103
shared_ptr.pointer() == type,
103104
shared_ptr.shared_count(),
104105
shared_ptr.pointer()->id(),
105-
dtor_count};
106+
dtor_count
107+
};
106108
};
107109

108110
// Non constant
@@ -115,8 +117,6 @@ GTEST_TEST(shared_pointer_safe, param_constructor_different_type)
115117
}
116118

117119
// Constant is not available with thread safe SharedPointer
118-
// Not working under with msvc
119-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
120120
/* #if !defined(HD_COMPILER_MSVC)
121121
{
122122
constexpr auto result = test(123);
@@ -155,7 +155,8 @@ GTEST_TEST(shared_pointer_safe, copy_constructor_same_type)
155155
shared_ptr.pointer()->move_assign_count(),
156156
shared_ptr.pointer()->copy_constructor_count(),
157157
shared_ptr.pointer()->move_constructor_count(),
158-
dtor_count};
158+
dtor_count
159+
};
159160
};
160161

161162
// Non constant
@@ -181,8 +182,6 @@ GTEST_TEST(shared_pointer_safe, copy_constructor_same_type)
181182
}
182183

183184
// Constant is not available with thread safe SharedPointer
184-
// Not working under with msvc
185-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
186185
/*#if !defined(HD_COMPILER_MSVC)
187186
{
188187
constexpr auto result = test(123);
@@ -235,7 +234,8 @@ GTEST_TEST(shared_pointer_safe, copy_constructor_different_type)
235234
shared_ptr.pointer()->move_assign_count(),
236235
shared_ptr.pointer()->copy_constructor_count(),
237236
shared_ptr.pointer()->move_constructor_count(),
238-
dtor_count};
237+
dtor_count
238+
};
239239
};
240240

241241
// Non constant
@@ -261,8 +261,6 @@ GTEST_TEST(shared_pointer_safe, copy_constructor_different_type)
261261
}
262262

263263
// Constant is not available with thread safe SharedPointer
264-
// Not working under with msvc
265-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
266264
/*#if !defined(HD_COMPILER_MSVC)
267265
{
268266
constexpr auto result = test(123);
@@ -308,7 +306,8 @@ GTEST_TEST(shared_pointer_safe, move_constructor_same_type)
308306
shared_ptr.pointer()->move_constructor_count(),
309307
shared_ptr_to_move.pointer() == nullptr,
310308
shared_ptr_to_move.shared_count(),
311-
dtor_count};
309+
dtor_count
310+
};
312311
};
313312

314313
// Non constant
@@ -328,8 +327,6 @@ GTEST_TEST(shared_pointer_safe, move_constructor_same_type)
328327
}
329328

330329
// Constant is not available with thread safe SharedPointer
331-
// Not working under with msvc
332-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
333330
/* #if !defined(HD_COMPILER_MSVC)
334331
{
335332
constexpr auto result = test(123);
@@ -369,7 +366,8 @@ GTEST_TEST(shared_pointer_safe, move_constructor_different_type)
369366
shared_ptr.pointer()->move_constructor_count(),
370367
shared_ptr_to_move.pointer() == nullptr,
371368
shared_ptr_to_move.shared_count(),
372-
dtor_count};
369+
dtor_count
370+
};
373371
};
374372

375373
// Non constant
@@ -389,8 +387,6 @@ GTEST_TEST(shared_pointer_safe, move_constructor_different_type)
389387
}
390388

391389
// Constant is not available with thread safe SharedPointer
392-
// Not working under with msvc
393-
// https://developercommunity.visualstudio.com/t/constant-evaluation-with-do-not-works-wi/10058244
394390
/*#if !defined(HD_COMPILER_MSVC)
395391
{
396392
constexpr auto result = test(123);

0 commit comments

Comments
 (0)