refactor(@typed-storage/core): fix all linting errors

Author: Haberkamp

packages/core/src/define-storage.test-d.ts

@@ -1,6 +1,6 @@
 import { z } from "zod"
 import { defineStorage } from "./define-storage.js"
-import { test, assertType, expectTypeOf } from "vitest"
+import { test, assertType } from "vitest"
 
 test("it's not possible to set a value that violates the schema", () => {
   // ARRANGE

packages/core/src/define-storage.test.ts

@@ -1,4 +1,4 @@
-import { beforeEach, test, expect, describe } from "vitest"
+import { beforeEach, test, expect } from "vitest"
 import { defineStorage } from "./define-storage.js"
 import { z } from "zod"
 

packages/core/src/define-storage.ts

@@ -34,11 +34,14 @@ export function defineStorage<T extends Record<string, StandardSchemaV1>>(
         let parsedValue: unknown
         try {
           parsedValue = JSON.parse(item)
-        } catch (e) {
+        } catch {
           if (item === "true") parsedValue = true
           else if (item === "false") parsedValue = false
-          else if (!isNaN(Number(item))) parsedValue = Number(item)
-          else parsedValue = item
+          else if (Number.isNaN(Number(item))) {
+            parsedValue = item
+          } else {
+            parsedValue = Number(item)
+          }
         }
 
         try {
@@ -65,12 +68,10 @@ export function defineStorage<T extends Record<string, StandardSchemaV1>>(
           const schemaForKey = schema[key] as StandardSchemaV1
           const validatedValue = standardValidate(schemaForKey, value)
 
-          let stringifiedValue: string
-          if (typeof validatedValue === "object" && validatedValue !== null) {
-            stringifiedValue = JSON.stringify(validatedValue)
-          } else {
-            stringifiedValue = String(validatedValue)
-          }
+          const stringifiedValue =
+            typeof validatedValue === "object" && validatedValue !== null
+              ? JSON.stringify(validatedValue)
+              : String(validatedValue)
 
           localStorage.setItem(key as string, stringifiedValue)
         }