Skip to content

Commit d15695b

Browse files
Copilotpethers
andauthored
fix: resolve release workflow warnings (tar failures, deprecated attest-sbom) (#990)
* Initial plan * fix: resolve all 7 release workflow warnings - Remove duplicate apt cache steps causing tar exit code 2 failures - Consolidate graphviz into initial apt-get install step - Replace deprecated actions/attest-sbom@v4.0.0 with actions/attest@v4.1.0 - Change pull_request_target to pull_request in labeler.yml Co-authored-by: pethers <1726836+pethers@users.noreply.github.com> * fix: revert labeler to pull_request_target and improve readability - Keep pull_request_target for fork PR labeling support - Break long apt-get install into readable multi-line format Co-authored-by: pethers <1726836+pethers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
1 parent e536a3c commit d15695b

File tree

1 file changed

+6
-25
lines changed

1 file changed

+6
-25
lines changed

.github/workflows/release.yml

Lines changed: 6 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -50,18 +50,12 @@ jobs:
5050
echo "version=${VERSION}" >> $GITHUB_OUTPUT
5151
echo "Version: ${VERSION}"
5252
53-
- name: Cache apt packages
54-
uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
55-
with:
56-
path: /var/cache/apt/archives
57-
key: ${{ runner.os }}-apt-${{ hashFiles('.github/workflows/release.yml') }}
58-
restore-keys: |
59-
${{ runner.os }}-apt-
60-
6153
- name: Setup display and dependencies
6254
run: |
6355
sudo apt-get update
64-
sudo apt-get install -y xvfb libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev libnss3 libxss1 libasound2t64 libxtst6 xauth
56+
sudo apt-get install -y \
57+
xvfb libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev \
58+
libnss3 libxss1 libasound2t64 libxtst6 xauth graphviz
6559
sudo mkdir -p /var/run/dbus
6660
sudo dbus-daemon --system --fork
6761
@@ -116,20 +110,6 @@ jobs:
116110
env:
117111
CYPRESS_VIDEO: false
118112

119-
- name: Cache GraphViz packages
120-
uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
121-
with:
122-
path: /var/cache/apt/archives
123-
key: ${{ runner.os }}-apt-graphviz-${{ hashFiles('.github/workflows/release.yml') }}
124-
restore-keys: |
125-
${{ runner.os }}-apt-graphviz-
126-
${{ runner.os }}-apt-
127-
128-
- name: Install GraphViz
129-
run: |
130-
sudo apt-get update
131-
sudo apt-get install -y graphviz
132-
133113
# Run tests with coverage
134114
- name: Run tests with coverage
135115
run: npm run coverage
@@ -271,10 +251,11 @@ jobs:
271251

272252
- name: Generate SBOM attestation
273253
id: attestsbom
274-
uses: actions/attest-sbom@07e74fc4e78d1aad915e867f9a094073a9f71527 # v4.0.0
254+
uses: actions/attest@59d89421af93a897026c735860bf21b6eb4f7b26 # v4.1.0
275255
with:
276256
subject-path: cia-compliance-manager-${{ needs.prepare.outputs.version }}.zip
277-
sbom-path: cia-compliance-manager-${{ needs.prepare.outputs.version }}.spdx.json
257+
predicate-type: 'https://spdx.dev/Document'
258+
predicate-path: cia-compliance-manager-${{ needs.prepare.outputs.version }}.spdx.json
278259

279260
- name: Copy SBOM attestation for zip
280261
run: cp ${{ steps.attestsbom.outputs.bundle-path }} cia-compliance-manager-${{ needs.prepare.outputs.version }}.spdx.json.intoto.jsonl

0 commit comments

Comments
 (0)