Feedback on HTML/CSS exercises

[NVedsted]

After having reviewed a few hand-ins for the HTML/CSS module, I have a few comments/suggestions:

1. Exercise 0
   1. We ask trainees to "bold" and "italizice" thus <b> and <i> seems right if your goal is literally just make a visual difference, but do we want them to use the more semantically meaningful ones? If so, we should probably tell them to "put emphasis" or "indicate importance" or something like that.
   2. We use the term "container tag" which does not seem to be a common term. What do we exactly mean by that? Any tag that can contain another tag? Or are we more specifically going into flow/phrasing content? I would suggest rephrasing this.
   3. The exercise seemingly aims to, among other things, teach about line breaks, but if you follow the instructions to the letter and opt for an alt tag and not a caption on your image, then I do not see how you could possibly encounter a line-break issue. Perhaps the caption part should not be optional to make it more likely they will encounter the classic text-and-image-on-same-line rite of passage. 😄
2. Exercise 3
   1. Why are we asking for the href be #.# and not just #? The seems illegal or at least odd to me. I have created Change suggested href to a valid value in HTML/CSS lesson plan #216 which addresses this. Merged.
   2. The focus of "Adding comments" is perhaps a bit too vague. As a trainee, I would not be entirely sure what to do. I think we should elaborate this point.
3. Exercise 4
   1. This is a bit hard to review as it might affect any of the other exercises at random. If we want them to hand these exercises in, I would suggest telling the trainees to apply the styling to a copy of another exercise and submit it individually.

Let me know if you want me to split this issue. 😄 I am up for contributing agreed-upon changes.

[adamblanchard]

1. 1. Agree
   2. As far as I understand, container means any markup that has an opening tag, middle content, and ending tag. e.g. <p>hello</p> vs something like <meta>. We can explain that if it's not clear.
   3. Alt and captions have different purposes right, so i think it's best to separate these into two requirements. Then "caption" is required, and will face the line break issue. Good catch!

2. ii. Agree! Maybe adding a simple example is enough to explain?

3. i. They are already submitting each exercise on a separate codepen? If so, i think that's the easy fix, yes, to copy and paste a previous one 👌

Since they are all quite "small" improvements, i think it's fine in one github issue :-) But separate PRs is a good idea!