Skip to content

Commit 5489754

Browse files
Copilotstasel
andauthored
Add new TestType enum values and update tests dropdown UI (#310)
* Initial plan * Add new TestType enum values to backend, frontend, and API docs Co-authored-by: stasel <2033301+stasel@users.noreply.github.com> * Address PR review comments: rename CoreEndInterview, fix api.yaml, show legacy types when editing old tests Co-authored-by: stasel <2033301+stasel@users.noreply.github.com> * Fix MUI Select bugs: use arrays instead of fragments for conditional MenuItems Co-authored-by: stasel <2033301+stasel@users.noreply.github.com> * Simplify dropdown: always show only new test types, remove legacy conditional logic Co-authored-by: stasel <2033301+stasel@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stasel <2033301+stasel@users.noreply.github.com>
1 parent 8979774 commit 5489754

File tree

4 files changed

+29
-8
lines changed

4 files changed

+29
-8
lines changed

client/src/data/types/Trainee.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,13 @@ export enum TestType {
9494
NodeJS = 'nodejs',
9595
ReactInterview = 'react-interview',
9696
FinalProjectInterview = 'final-project-interview',
97+
CoreMidTermInterview = 'core-mid-term-interview',
98+
CoreEndInterview = 'core-end-interview',
99+
FrontEndMidTermInterview = 'frontend-mid-term-interview',
100+
BackEndMidTermInterview = 'backend-mid-term-interview',
101+
CloudMidTermInterview = 'cloud-mid-term-interview',
102+
DataMidTermInterview = 'data-mid-term-interview',
103+
TesterMidTermInterview = 'tester-mid-term-interview',
97104
}
98105

99106
// interfaces

client/src/features/trainee-profile/education/tests/TestDetailsModal.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -134,13 +134,13 @@ export const TestDetailsModal = ({
134134
value={testFields.type ?? ''}
135135
onChange={handleTestSelectChange}
136136
>
137-
<MenuItem value={TestType.Presentation}>Presentation</MenuItem>
138-
<MenuItem value={TestType.JavaScript}>JavaScript</MenuItem>
139-
<MenuItem value={TestType.BrowsersInterview}>Browsers interview</MenuItem>
140-
<MenuItem value={TestType.UsingApisInterview}>Using APIs interview</MenuItem>
141-
<MenuItem value={TestType.NodeJS}>Node.js</MenuItem>
142-
<MenuItem value={TestType.ReactInterview}>React interview</MenuItem>
143-
<MenuItem value={TestType.FinalProjectInterview}>Final project interview</MenuItem>
137+
<MenuItem value={TestType.CoreMidTermInterview}>Core mid-term interview</MenuItem>
138+
<MenuItem value={TestType.CoreEndInterview}>Core end interview</MenuItem>
139+
<MenuItem value={TestType.FrontEndMidTermInterview}>Frontend mid-term interview</MenuItem>
140+
<MenuItem value={TestType.BackEndMidTermInterview}>Backend mid-term interview</MenuItem>
141+
<MenuItem value={TestType.CloudMidTermInterview}>Cloud mid-term interview</MenuItem>
142+
<MenuItem value={TestType.DataMidTermInterview}>Data mid-term interview</MenuItem>
143+
<MenuItem value={TestType.TesterMidTermInterview}>Tester mid-term interview</MenuItem>
144144
</Select>
145145
{typeError && <FormHelperText>Type is required</FormHelperText>}
146146
</FormControl>

server/api.yaml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1652,12 +1652,19 @@ components:
16521652
type: string
16531653
enum:
16541654
- presentation
1655-
- javaScript
1655+
- javascript
16561656
- browsers-interview
16571657
- using-apis-interview
16581658
- nodejs
16591659
- react-interview
16601660
- final-project-interview
1661+
- core-mid-term-interview
1662+
- core-end-interview
1663+
- frontend-mid-term-interview
1664+
- backend-mid-term-interview
1665+
- cloud-mid-term-interview
1666+
- data-mid-term-interview
1667+
- tester-mid-term-interview
16611668
score:
16621669
type: number
16631670
example: 8.6

server/src/models/Trainee.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,13 @@ export enum TestType {
8484
NodeJS = 'nodejs',
8585
ReactInterview = 'react-interview',
8686
FinalProjectInterview = 'final-project-interview',
87+
CoreMidTermInterview = 'core-mid-term-interview',
88+
CoreEndInterview = 'core-end-interview',
89+
FrontEndMidTermInterview = 'frontend-mid-term-interview',
90+
BackEndMidTermInterview = 'backend-mid-term-interview',
91+
CloudMidTermInterview = 'cloud-mid-term-interview',
92+
DataMidTermInterview = 'data-mid-term-interview',
93+
TesterMidTermInterview = 'tester-mid-term-interview',
8794
}
8895

8996
export interface Trainee {

0 commit comments

Comments
 (0)