Changed profileURL proeprty to profilePath. Fixed Slack notifications

stasel · stasel · commit 947829dc5698 · 2026-02-01T22:29:27.000+01:00
diff --git a/client/src/features/cohorts/Cohorts.ts b/client/src/features/cohorts/Cohorts.ts
@@ -8,7 +8,7 @@ export interface Cohort {
 export interface TraineeSummary {
   id: string;
   displayName: string;
-  profileURL: string;
+  profilePath: string;
   thumbnailURL: string | null;
   location?: string;
   hasWorkPermit?: boolean;
diff --git a/client/src/features/cohorts/components/CohortAccordion.tsx b/client/src/features/cohorts/components/CohortAccordion.tsx
@@ -72,7 +72,7 @@ const CohortAccordion = ({ cohortInfo }: CohortAccordionProps) => {
                   hover
                   sx={{ '&:last-child td, &:last-child th': { border: 0 }, cursor: 'pointer', textDecoration: 'none' }}
                   component={Link}
-                  to={trainee.profileURL}
+                  to={trainee.profilePath}
                 >
                   <TableCell component="th" scope="row">
                     <TraineeAvatar imageURL={trainee.thumbnailURL ?? ''} altText={trainee.displayName}></TraineeAvatar>
diff --git a/client/src/features/search/Search.ts b/client/src/features/search/Search.ts
@@ -2,6 +2,6 @@ export interface SearchResult {
   id: number;
   name: string;
   thumbnail: string | null;
-  profileURL: string;
+  profilePath: string;
   cohort: number | null;
 }
diff --git a/client/src/features/search/components/SearchResultsList.tsx b/client/src/features/search/components/SearchResultsList.tsx
@@ -39,7 +39,7 @@ const SearchResultsList = ({ isLoading, data }: SearchResultsListProps) => {
             return (
               <ListItem disablePadding key={trainee.id}>
                 <Link
-                  to={trainee.profileURL}
+                  to={trainee.profilePath}
                   style={{
                     textDecoration: 'none',
                     color: 'inherit',
diff --git a/server/api.yaml b/server/api.yaml
@@ -149,9 +149,9 @@ paths:
                             name:
                               type: string
                               example: John Doe
-                            profileURL:
+                            profilePath:
                               type: string
-                              example: https://example.com/trainee/Isaac-Pagaca_HpOjvmwX
+                              example: /trainee/Isaac-Pagaca_HpOjvmwX
                             thumbnailURL:
                               type: string
                               example: https://cdn.example.com/images/HpOjvmwX_thumb.jpeg
@@ -1280,9 +1280,9 @@ components:
         displayName:
           type: string
           example: Johnny Doe
-        profileURL:
+        profilePath:
           type: string
-          example: https://example.com/trainee/Isaac-Pagaca_HpOjvmwX
+          example: /trainee/Isaac-Pagaca_HpOjvmwX
         imageURL:
           type: string
           example: https://cdn.example.com/images/profile/HpOjvmwX.jpeg
diff --git a/server/scripts/setup/generators/traineeGenerator.ts b/server/scripts/setup/generators/traineeGenerator.ts
@@ -39,7 +39,7 @@ export const generateTrainee = (): Trainee => {
     displayName: '',
     createdAt: new Date(),
     updatedAt: new Date(),
-    profileURL: '',
+    profilePath: '',
     personalInfo,
     contactInfo,
     educationInfo,
diff --git a/server/src/controllers/CohortsController.ts b/server/src/controllers/CohortsController.ts
@@ -10,7 +10,7 @@ interface Cohort {
 interface TraineeSummary {
   id: string;
   displayName: string;
-  profileURL: string;
+  profilePath: string;
   thumbnailURL: string | null;
   location?: string;
   hasWorkPermit?: boolean;
@@ -65,7 +65,7 @@ export class CohortsController implements CohortsControllerType {
     return {
       id: trainee.id,
       displayName: trainee.displayName,
-      profileURL: trainee.profileURL,
+      profilePath: trainee.profilePath,
       thumbnailURL: trainee.thumbnailURL ?? null,
       location: trainee.personalInfo.location,
       hasWorkPermit: trainee.personalInfo.hasWorkPermit,
diff --git a/server/src/controllers/SearchController.ts b/server/src/controllers/SearchController.ts
@@ -16,7 +16,7 @@ interface SearchResult {
   id: string;
   name: string;
   thumbnail: string | null;
-  profileURL: string;
+  profilePath: string;
   cohort: number | null;
   searchScore: number;
 }
@@ -70,7 +70,6 @@ export class SearchController implements SearchControllerType {
     // In an ideal scenario we should have a complex query to filter on the DB side.
     // However, because our dataset is not large, we can get away with this for now.
     const trainees = await this.traineesRepository.getAllTrainees();
-
     // Process all trainees, calculate the search score and return the top N results
     return trainees
       .map((trainee) => {
@@ -79,7 +78,7 @@ export class SearchController implements SearchControllerType {
           name: `${trainee.displayName}`,
           thumbnail: trainee.thumbnailURL ?? null,
           cohort: trainee.educationInfo.currentCohort ?? null,
-          profileURL: trainee.profileURL,
+          profilePath: trainee.profilePath,
           searchScore: this.calculateScore(trainee, keywords),
         };
       })
diff --git a/server/src/models/Trainee.ts b/server/src/models/Trainee.ts
@@ -90,7 +90,7 @@ export interface Trainee {
   readonly id: string;
   readonly createdAt: Date;
   readonly updatedAt: Date;
-  profileURL: string;
+  profilePath: string;
   displayName: string;
   imageURL?: string;
   thumbnailURL?: string;
@@ -175,11 +175,17 @@ export const getDisplayName = (trainee: Trainee): string => {
   return `${name} ${lastName}`;
 };
 
-export const getProfileURL = (trainee: Trainee): string => {
+export const getProfilePath = (trainee: Trainee): string => {
   const normalizedName = removeAccents(getDisplayName(trainee).toLowerCase()).replaceAll(/\s/g, '-');
   return `/trainee/${normalizedName}_${trainee.id}`;
 };
 
+export const getProfileURL = (trainee: Trainee): string => {
+  const url = new URL(process.env.BASE_URL ?? 'https://localhost');
+  url.pathname = getProfilePath(trainee);
+  return url.toString();
+};
+
 // Validations
 export const validateTrainee = (trainee: Trainee): void => {
   validatePersonalInfo(trainee.personalInfo);
diff --git a/server/src/schemas/TraineeSchema.ts b/server/src/schemas/TraineeSchema.ts
@@ -23,7 +23,7 @@ import {
   TraineeEmploymentInfo,
   TraineePersonalInfo,
   getDisplayName,
-  getProfileURL,
+  getProfilePath,
 } from '../models';
 import { WithMongoID, jsonFormatting } from '../utils/database';
 
@@ -185,8 +185,8 @@ TraineeSchema.virtual('displayName').get(function () {
   return getDisplayName(this as Trainee);
 });
 
-TraineeSchema.virtual('profileURL').get(function () {
-  return getProfileURL(this as Trainee);
+TraineeSchema.virtual('profilePath').get(function () {
+  return getProfilePath(this as Trainee);
 });
 
 TraineeSchema.set('toJSON', jsonFormatting);
diff --git a/server/src/services/NotificationService.ts b/server/src/services/NotificationService.ts
@@ -17,10 +17,10 @@ export interface UpdateChange {
 }
 
 export interface NotificationService {
-  traineeUpdated(trainee: Trainee, changes: UpdateChange[], user: AuthenticatedUser): Promise<void>;
-  interactionCreated(trainee: Trainee, interaction: InteractionWithReporter): Promise<void>;
-  strikeCreated(trainee: Trainee, strike: StrikeWithReporter): Promise<void>;
-  testCreated(trainee: Trainee, test: Test): Promise<void>;
+  traineeUpdated(trainee: Trainee, changes: UpdateChange[], user: AuthenticatedUser): void;
+  interactionCreated(trainee: Trainee, interaction: InteractionWithReporter): void;
+  strikeCreated(trainee: Trainee, strike: StrikeWithReporter): void;
+  testCreated(trainee: Trainee, test: Test): void;
 }
 
 export interface SlackNotificationServiceConfig {
@@ -40,49 +40,49 @@ export class SlackNotificationService implements NotificationService {
       socketMode: false,
       deferInitialization: true,
     });
-    this.initializeSlack();
+    this.initializeSlack().catch(Sentry.captureException);
   }
 
   private async initializeSlack(): Promise<void> {
     try {
       await this.slack.init();
       await this.slack.start();
       this.initialized = true;
-    } catch (error) {
-      console.warn(`⚠️ Slack is not initialized. Slack notifications will not work. (${error}).`);
+    } catch (error: unknown) {
+      console.warn(`⚠️ Slack is not initialized. Slack notifications will not work. (${String(error)}).`);
       console.warn('If you do not need to use Slack notifications, you can ignore this warning.\n');
     }
   }
 
-  async traineeUpdated(trainee: Trainee, changes: UpdateChange[], user: AuthenticatedUser): Promise<void> {
+  traineeUpdated(trainee: Trainee, changes: UpdateChange[], user: AuthenticatedUser): void {
     const message = [`✏️ *New update* for <${getProfileURL(trainee)}|${trainee.displayName}>`, `*By:* ${user.name}`];
     changes.forEach((change) => {
       message.push(`> - *${change.fieldName}*: ${change.previousValue} → ${change.newValue}`);
     });
-    this.postMessageToSlack(message.join('\n'));
+    this.postMessageToSlack(message.join('\n')).catch(Sentry.captureException);
   }
 
-  async interactionCreated(trainee: Trainee, interaction: InteractionWithReporter): Promise<void> {
+  interactionCreated(trainee: Trainee, interaction: InteractionWithReporter): void {
     const message = [
       `📝 *New interaction* for <${getProfileURL(trainee)}|${trainee.displayName}>`,
       `*By:* ${interaction.reporter.name}`,
       `[${interaction.type}] *${interaction.title}*`,
     ].join('\n');
 
-    this.postMessageToSlack(message);
+    this.postMessageToSlack(message).catch(Sentry.captureException);
   }
 
-  async strikeCreated(trainee: Trainee, strike: StrikeWithReporter): Promise<void> {
+  strikeCreated(trainee: Trainee, strike: StrikeWithReporter): void {
     const message = [
       `🛑 *New strike* for <${getProfileURL(trainee)}|${trainee.displayName}>`,
       `*By:* ${strike.reporter.name}`,
       `*Reason:* ${strike.reason}`,
     ].join('\n');
 
-    this.postMessageToSlack(message);
+    this.postMessageToSlack(message).catch(Sentry.captureException);
   }
 
-  async testCreated(trainee: Trainee, test: Test): Promise<void> {
+  testCreated(trainee: Trainee, test: Test): void {
     let resultIcon = '';
     if (test.result === TestResult.Failed) {
       resultIcon = '❌';
@@ -96,14 +96,14 @@ export class SlackNotificationService implements NotificationService {
 
     let message = [
       `📊 *New test result* for <${getProfileURL(trainee)}|${trainee.displayName}>`,
-      `${test.type}`,
+      test.type,
       `${resultIcon} ${test.result}`,
     ].join('\n');
 
     if (test.score) {
       message += ` (Score: ${test.score})`;
     }
-    this.postMessageToSlack(message);
+    this.postMessageToSlack(message).catch(Sentry.captureException);
   }
 
   private async postMessageToSlack(message: string): Promise<void> {

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ const CohortAccordion = ({ cohortInfo }: CohortAccordionProps) => {`
`72`	`72`	`hover`
`73`	`73`	`sx={{ '&:last-child td, &:last-child th': { border: 0 }, cursor: 'pointer', textDecoration: 'none' }}`
`74`	`74`	`component={Link}`
`75`		`- to={trainee.profileURL}`
	`75`	`+ to={trainee.profilePath}`
`76`	`76`	`>`
`77`	`77`	`<TableCell component="th" scope="row">`
`78`	`78`	`<TraineeAvatar imageURL={trainee.thumbnailURL ?? ''} altText={trainee.displayName}></TraineeAvatar>`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,6 @@ export interface SearchResult {`
`2`	`2`	`id: number;`
`3`	`3`	`name: string;`
`4`	`4`	`thumbnail: string \| null;`
`5`		`- profileURL: string;`
	`5`	`+ profilePath: string;`
`6`	`6`	`cohort: number \| null;`
`7`	`7`	`}`