#193 - upgrade of several low risk package#296
Merged
Conversation
zalexa19
requested review from
Aya-Alabrash,
sima-milli and
stasel
as code owners
HackYourFutures
temporarily deployed
to
dojo-task-issue-193-upg-8yvfmx
zalexa19
force-pushed
the
task/issue-193-upgrade-client-packages
branch
from
1e89e85 to
1d0925e
Compare
HackYourFutures
temporarily deployed
to
dojo-task-issue-193-upg-8yvfmx
Contributor
There was a problem hiding this comment.
Pull request overview
This PR begins upgrading the client-side dependency stack (notably MUI X packages and related tooling) and updates the React components/configuration needed to accommodate upgrade-driven API/type changes.
Changes:
- Upgraded client dependencies (MUI X Charts/Date Pickers, Google OAuth, TypeScript/types, Vite plugin React, ESLint plugins) and regenerated
package-lock.json. - Updated MUI component props to newer patterns (e.g.,
slotPropsusage inEducationInfo). - Refactored several modal components to rely on key-based remounting for form state reset, and adjusted chart typing after the MUI X Charts upgrade.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| client/src/features/trainee-profile/interactions/components/InteractionDetailsModal.tsx | Refactors modal state initialization; removes effect/reset logic. |
| client/src/features/trainee-profile/interactions/InteractionsInfo.tsx | Adds modal remount key strategy for “add interaction” flow. |
| client/src/features/trainee-profile/education/tests/TestsComponent.tsx | Adds modal remount key strategy for “add test” flow. |
| client/src/features/trainee-profile/education/tests/TestDetailsModal.tsx | Refactors modal state initialization; removes effect/reset logic. |
| client/src/features/trainee-profile/education/strikes/StrikesComponent.tsx | Adds modal remount key strategy for strikes modal. |
| client/src/features/trainee-profile/education/strikes/StrikeDetailsModal.tsx | Refactors modal state initialization; removes effect/reset logic. |
| client/src/features/trainee-profile/education/EducationInfo.tsx | Migrates TextField props to slotProps for upgraded MUI APIs. |
| client/src/features/dashboard/components/DashboardPieChart.tsx | Adjusts PieChart data typing after MUI X Charts upgrade. |
| client/package.json | Bumps client dependencies/devDependencies for the upgrade. |
| client/package-lock.json | Lockfile updates reflecting new versions and transitive deps. |
| client/eslint.config.js | Updates ESLint flat config structure for upgraded plugins/config APIs. |
Files not reviewed (1)
- client/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
client/src/features/trainee-profile/education/strikes/StrikesComponent.tsx
Show resolved
Hide resolved
client/src/features/trainee-profile/interactions/components/InteractionDetailsModal.tsx
Outdated
Show resolved
Hide resolved
client/src/features/trainee-profile/education/tests/TestDetailsModal.tsx
Outdated
Show resolved
Hide resolved
client/src/features/trainee-profile/education/strikes/StrikesComponent.tsx
Outdated
Show resolved
Hide resolved
HackYourFutures
temporarily deployed
to
dojo-task-issue-193-upg-8yvfmx
zalexa19
force-pushed
the
task/issue-193-upgrade-client-packages
branch
from
ff43fe1 to
deb3ed5
Compare
HackYourFutures
temporarily deployed
to
dojo-task-issue-193-upg-8yvfmx
HackYourFutures
temporarily deployed
to
dojo-task-issue-193-upg-8yvfmx
stasel
approved these changes
Feb 7, 2026
Member
stasel
left a comment
stasel
left a comment
There was a problem hiding this comment.
Looks good, tested on the deployment - everything seems to be working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
started upgrading the client packages
This requires testing on adding/editing stikes, tests and interactions 😬