Skip to content

Commit ce8508f

Browse files
Balaji-Sridharan_NYULHBalaji-Sridharan_NYULH
authored andcommitted
🔨 Remove the "react-datepicker__week-number--keyboard-selected" class for the <WeekNumber /> component
- Removed as highlighting the first day of the week alone highlights the week number - Because we set the date prop of the <WeekNumber /> to first date of the week. As a result this highlight will work only for the first day of week
1 parent 30babb9 commit ce8508f

File tree

2 files changed

+0
-70
lines changed

2 files changed

+0
-70
lines changed

‎src/test/week_number_test.test.tsx‎

Lines changed: 0 additions & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -186,11 +186,6 @@ describe("WeekNumber", () => {
186186
) as HTMLDivElement;
187187
expect(weekNumber).not.toBeNull();
188188

189-
expect(
190-
weekNumber?.classList.contains(
191-
"react-datepicker__week-number--keyboard-selected",
192-
),
193-
).toBe(false);
194189
expect(weekNumber?.tabIndex).toBe(0);
195190
});
196191

@@ -212,11 +207,6 @@ describe("WeekNumber", () => {
212207
".react-datepicker__week-number",
213208
) as HTMLDivElement;
214209
expect(weekNumber).not.toBeNull();
215-
expect(
216-
weekNumber?.classList.contains(
217-
"react-datepicker__week-number--keyboard-selected",
218-
),
219-
).toBe(true);
220210
expect(weekNumber.tabIndex).toBe(0);
221211
});
222212

@@ -267,11 +257,6 @@ describe("WeekNumber", () => {
267257
const weekNumber = container.querySelector(
268258
".react-datepicker__week-number",
269259
) as HTMLDivElement;
270-
expect(
271-
weekNumber?.classList.contains(
272-
"react-datepicker__week-number--keyboard-selected",
273-
),
274-
).toBe(false);
275260
expect(weekNumber.tabIndex).toBe(-1);
276261
});
277262
});
@@ -383,59 +368,6 @@ describe("WeekNumber", () => {
383368
),
384369
).toBe(false);
385370
});
386-
387-
it("should have the class 'react-datepicker__week-number--selected' if selected is not current week and preselected is current week", () => {
388-
const currentWeekNumber = newDate("2023-10-22T13:09:53+02:00");
389-
const selected = addWeeks(currentWeekNumber, 1);
390-
const { container } = render(
391-
<WeekNumber
392-
weekNumber={1}
393-
date={currentWeekNumber}
394-
selected={selected}
395-
preSelection={currentWeekNumber}
396-
/>,
397-
);
398-
const weekNumber = container.querySelector(
399-
".react-datepicker__week-number",
400-
);
401-
expect(
402-
weekNumber?.classList.contains(
403-
"react-datepicker__week-number--selected",
404-
),
405-
).toBe(false);
406-
expect(
407-
weekNumber?.classList.contains(
408-
"react-datepicker__week-number--keyboard-selected",
409-
),
410-
).toBe(true);
411-
});
412-
413-
it("should have the class 'react-datepicker__week-number--selected' if selected is not current week and preselected is not current week", () => {
414-
const currentWeekNumber = newDate("2023-10-22T13:09:53+02:00");
415-
const selected = addWeeks(currentWeekNumber, 1);
416-
const preSelection = addWeeks(currentWeekNumber, 2);
417-
const { container } = render(
418-
<WeekNumber
419-
weekNumber={1}
420-
date={currentWeekNumber}
421-
selected={selected}
422-
preSelection={preSelection}
423-
/>,
424-
);
425-
const weekNumber = container.querySelector(
426-
".react-datepicker__week-number",
427-
);
428-
expect(
429-
weekNumber?.classList.contains(
430-
"react-datepicker__week-number--selected",
431-
),
432-
).toBe(false);
433-
expect(
434-
weekNumber?.classList.contains(
435-
"react-datepicker__week-number--keyboard-selected",
436-
),
437-
).toBe(false);
438-
});
439371
});
440372
});
441373

‎src/week_number.tsx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,6 @@ export default class WeekNumber extends Component<WeekNumberProps> {
120120
"react-datepicker__week-number--clickable": !!onClick,
121121
"react-datepicker__week-number--selected":
122122
!!onClick && isSameDay(this.props.date, this.props.selected),
123-
"react-datepicker__week-number--keyboard-selected":
124-
this.isKeyboardSelected(),
125123
};
126124
return (
127125
<div

0 commit comments

Comments
 (0)