fix: reset monthSelectedIn when changeMonth is called in custom header #6058
+106
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3829 When using monthsShown >= 2 with a custom header, calling changeMonth() would produce inconsistent results depending on which calendar panel the user last selected a date in. This was because the monthSelectedIn state (which tracks the offset for multi-month display) was not being reset when changeMonth was explicitly called. This fix: - Adds onMonthSelectedInChange callback prop to Calendar component - Resets monthSelectedIn to 0 when changeMonth is called, ensuring the target month always appears in the leftmost position - Adds test to verify the fix
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6058 +/- ##
==========================================
+ Coverage 99.13% 99.22% +0.08%
==========================================
Files 30 30
Lines 3586 3590 +4
Branches 1535 1519 -16
==========================================
+ Hits 3555 3562 +7
+ Misses 29 27 -2
+ Partials 2 1 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add test to verify that monthSelectedIn is reset to 0 when changeMonth is called from a custom header. This ensures the fix for issue #3829 has complete test coverage.
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3829
When using monthsShown >= 2 with a custom header, calling changeMonth() would produce inconsistent results depending on which calendar panel the user last selected a date in. This was because the monthSelectedIn state (which tracks the offset for multi-month display) was not being reset when changeMonth was explicitly called.
This fix: