Skip to content

Conversation

@asajjad2
Copy link
Contributor

@asajjad2 asajjad2 commented Nov 20, 2025

What are the relevant tickets?

#9097, #6036

Description (What does it do?)

This PR adds keyboard accessibility support for time-only pickers. When the time input is focused and the dropdown is open, ArrowUp/ArrowDown increment or decrement the selected time by the configured timeIntervals (default 30 minutes), update the input value in real-time, and automatically scroll the highlighted option into view in the dropdown. The Enter key commits the current typed value if it's valid, or falls back to the currently highlighted option in the dropdown if the input is invalid or empty. After committing, the dropdown closes and onChange is triggered with the selected time.

The implementation adds three new methods: handleTimeOnlyArrowKey for handling arrow key navigation, handleTimeOnlyEnterKey for parsing and committing the selected time, and scrollToTimeOption for finding and scrolling the matching time option into view.

Screencast

Screen.Recording.2025-11-11.at.3.38.55.PM.mov

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.21%. Comparing base (1122aba) to head (5517e0a).
⚠️ Report is 67 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6039      +/-   ##
==========================================
+ Coverage   98.91%   99.21%   +0.30%     
==========================================
  Files          30       30              
  Lines        3496     3582      +86     
  Branches     1470     1509      +39     
==========================================
+ Hits         3458     3554      +96     
+ Misses         37       27      -10     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asajjad2 asajjad2 marked this pull request as ready for review November 24, 2025 10:35
@martijnrusschen
Copy link
Member

It looks like our code coverage tool isn't too happy with the changes yet. Please check out the results and check how test coverage can be improved.

@martijnrusschen martijnrusschen merged commit 0b9c1e0 into Hacker0x01:main Nov 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants