fix: Hiding popper arrow should remove offset

[tejas-agravat-dev]

Fixes issue : #5969

name: Pull Request
about: Create a pull request to improve this repository
title: "Fix: Hiding popper arrow removes offset #5969"
labels: "bug"
assignees: ""

Description

Linked issue: #5969

Problem
withFloating applies a hard-coded 10px offset to make room for the popper arrow.
When showPopperArrow is set to false, this offset remains, causing the calendar to appear shifted downward.
Users expect that disabling the arrow should automatically remove the offset.

Changes

• Updated the offset logic to conditionally remove the 10px spacing when showPopperArrow is false.
• Ensured that the popper position resets correctly without requiring custom modifiers or negative offsets.
• Added tests verifying that the calendar is aligned as expected when the arrow is hidden.

Screenshots

To reviewers

• Please verify that the calendar opens without offset when showPopperArrow={false}.
• Check for regressions in default behavior where the arrow is displayed.

Contribution checklist

• I have followed the contributing guidelines.
• I have added sufficient test coverage for my changes.
• I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.22%. Comparing base (949cd8e) to head (41b9a85).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6071      +/-   ##
==========================================
+ Coverage   99.13%   99.22%   +0.08%     
==========================================
  Files          30       30              
  Lines        3594     3595       +1     
  Branches     1521     1539      +18     
==========================================
+ Hits         3563     3567       +4     
+ Misses         29       27       -2     
+ Partials        2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.