improve/fix check whether the cache returns always a miss

Author: m10x

pkg/deception.go

@@ -159,7 +159,7 @@ func webCacheDeceptionTemplate(repResult *reportResult, appendStr string) error
 	indicValue = strings.TrimSpace(strings.ToLower(resp.Header.Get(Config.Website.Cache.Indicator)))
 
 	// check if there's a cache hit and if the body didn't change (otherwise it could be a cached error page, for example)
-	if checkCacheHit(indicValue) && string(body) == Config.Website.Body {
+	if checkCacheHit(indicValue, "") && string(body) == Config.Website.Body {
 		repResult.Vulnerable = true
 		repRequest.Reason = "The response got cached due to Web Cache Deception"
 		msg = fmt.Sprintf("%s was successfully decepted! appended: %s\n", rUrl, appendStr)

pkg/recon.go

@@ -329,7 +329,7 @@ func checkIfAlwaysMiss(cache CacheStruct) (bool, error) {
 	}
 
 	indicValue := strings.TrimSpace(strings.ToLower(resp.Header.Get(cache.Indicator)))
-	if !checkCacheHit(indicValue) {
+	if !checkCacheHit(indicValue, cache.Indicator) {
 		addCachebusterMap("always-miss")
 
 		msg := "cache returns always miss"
@@ -470,7 +470,7 @@ func cachebusterCookie(cache *CacheStruct) []error {
 			}
 
 			indicValue := strings.TrimSpace(strings.ToLower(resp.Header.Get(cache.Indicator)))
-			if checkCacheHit(indicValue) {
+			if checkCacheHit(indicValue, cache.Indicator) {
 				// If there is a hit, the cachebuster didn't work
 				msg := fmt.Sprintf("%s was not successful (Cookie)\n", identifier)
 				PrintVerbose(msg, NoColor, 2)
@@ -520,7 +520,7 @@ func cachebusterCookie(cache *CacheStruct) []error {
 				}
 
 				indicValue = strings.TrimSpace(strings.ToLower(resp.Header.Get(cache.Indicator)))
-				if checkCacheHit(indicValue) {
+				if checkCacheHit(indicValue, cache.Indicator) {
 					// If there is a hit, the cachebuster didn't work
 					msg := fmt.Sprintf("%s was not successful (Cookie)\n", identifier)
 					PrintVerbose(msg, NoColor, 2)
@@ -687,7 +687,7 @@ func cachebusterHeader(cache *CacheStruct) []error {
 			}
 
 			indicValue := strings.TrimSpace(strings.ToLower(resp.Header.Get(cache.Indicator)))
-			if checkCacheHit(indicValue) {
+			if checkCacheHit(indicValue, cache.Indicator) {
 				// If there is a hit, the cachebuster didn't work
 				msg := fmt.Sprintf("%s was not successful (Header)\n", identifier)
 				PrintVerbose(msg, NoColor, 2)
@@ -742,7 +742,7 @@ func cachebusterHeader(cache *CacheStruct) []error {
 				}
 
 				indicValue = strings.TrimSpace(strings.ToLower(resp.Header.Get(cache.Indicator)))
-				if checkCacheHit(indicValue) {
+				if checkCacheHit(indicValue, cache.Indicator) {
 					// If there is a hit, the cachebuster didn't work
 					msg := fmt.Sprintf("%s was not successful (Header)\n", identifier)
 					PrintVerbose(msg, NoColor, 2)
@@ -879,7 +879,7 @@ func cachebusterParameter(cache *CacheStruct) error {
 		}
 
 		indicValue := strings.TrimSpace(strings.ToLower(resp.Header.Get(cache.Indicator)))
-		if checkCacheHit(indicValue) {
+		if checkCacheHit(indicValue, cache.Indicator) {
 			// If there is a hit, the cachebuster didn't work
 			msg := fmt.Sprintf("%s was not successful (Parameter)\n", identifier)
 			PrintVerbose(msg, NoColor, 2)
@@ -925,7 +925,7 @@ func cachebusterParameter(cache *CacheStruct) error {
 			}
 
 			indicValue = strings.TrimSpace(strings.ToLower(resp.Header.Get(cache.Indicator)))
-			if checkCacheHit(indicValue) {
+			if checkCacheHit(indicValue, cache.Indicator) {
 				// If there is a hit, the cachebuster didn't work
 				msg := fmt.Sprintf("%s was not successful (Parameter)\n", identifier)
 				PrintVerbose(msg, NoColor, 2)
@@ -1085,7 +1085,7 @@ func cachebusterHTTPMethod(cache *CacheStruct) []error {
 			}
 
 			indicValue := strings.TrimSpace(strings.ToLower(resp.Header.Get(cache.Indicator)))
-			if checkCacheHit(indicValue) {
+			if checkCacheHit(indicValue, cache.Indicator) {
 				// If there is a hit, the cachebuster didn't work
 				msg := fmt.Sprintf("%s was not successful (HTTP Method)\n", identifier)
 				PrintVerbose(msg, NoColor, 2)
@@ -1129,7 +1129,7 @@ func cachebusterHTTPMethod(cache *CacheStruct) []error {
 				}
 
 				indicValue = strings.TrimSpace(strings.ToLower(resp.Header.Get(cache.Indicator)))
-				if checkCacheHit(indicValue) {
+				if checkCacheHit(indicValue, cache.Indicator) {
 					// If there is a hit, the cachebuster didn't work
 					msg := fmt.Sprintf("%s was not successful (HTTP Method)\n", identifier)
 					PrintVerbose(msg, NoColor, 2)

pkg/techniques.go

@@ -680,7 +680,7 @@ func ScanParameterCloaking() reportResult {
 					m.Unlock()
 				}
 				indicValue := respHeader.Get(cache.Indicator)
-				if checkCacheHit(indicValue) {
+				if checkCacheHit(indicValue, cache.Indicator) {
 					m.Lock()
 					unkeyed_parameter = append(unkeyed_parameter, s)
 					m.Unlock()

pkg/utils.go

@@ -209,11 +209,13 @@ func searchBodyHeadersForString(cb string, body string, headers http.Header) boo
 }
 
 // check if cache was hit
-func checkCacheHit(value string) bool {
-	indicator := Config.Website.Cache.Indicator
+func checkCacheHit(value string, indicator string) bool {
+	if indicator == "" {
+		indicator = Config.Website.Cache.Indicator
+	}
 	if strings.EqualFold("age", indicator) {
 		value = strings.TrimSpace(value)
-		if value != "0" {
+		if value != "0" && value != "" {
 			return true
 		}
 	} else if strings.EqualFold("x-iinfo", indicator) {