From f4bd9b1f87a19d099cc2754c3262def8b206699c Mon Sep 17 00:00:00 2001 From: Hannes Papenberg Date: Fri, 8 Aug 2025 12:29:04 +0200 Subject: [PATCH 1/9] Change --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c655bf951700b..6b7442516d2c6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -68,12 +68,14 @@ jobs: path: libraries/vendor key: ${{ runner.os }}-composer-${{ hashFiles('composer.lock') }} - name: Check PHP code style + id: check-codestyle env: PHP_CS_FIXER_IGNORE_ENV: true run: | git config --global --add safe.directory $GITHUB_WORKSPACE ./libraries/vendor/bin/${{ matrix.command }} - uses: parkerbxyz/suggest-changes@v2 + if: failure() && steps.check-codestyle.outcome == 'failure' with: comment: 'Your code does not comply with our codestyle. Please commit the suggested changes.' From 480fb35a2112485038fe12c34eb13e14c7ef9cae Mon Sep 17 00:00:00 2001 From: Hannes Papenberg Date: Fri, 8 Aug 2025 12:33:22 +0200 Subject: [PATCH 2/9] More changes --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6b7442516d2c6..df228d0138c40 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -69,6 +69,7 @@ jobs: key: ${{ runner.os }}-composer-${{ hashFiles('composer.lock') }} - name: Check PHP code style id: check-codestyle + continue-on-error: true env: PHP_CS_FIXER_IGNORE_ENV: true run: | From b6dc7755341cdc38aee9563b20853b9cee65cdeb Mon Sep 17 00:00:00 2001 From: Hannes Papenberg Date: Fri, 8 Aug 2025 12:38:44 +0200 Subject: [PATCH 3/9] Break it --- .../com_banners/src/Controller/BannersController.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/api/components/com_banners/src/Controller/BannersController.php b/api/components/com_banners/src/Controller/BannersController.php index 4fb7c9d5fbfae..f81b7f8c2a68e 100644 --- a/api/components/com_banners/src/Controller/BannersController.php +++ b/api/components/com_banners/src/Controller/BannersController.php @@ -21,8 +21,7 @@ * * @since 4.0.0 */ -class BannersController extends ApiController -{ +class BannersController extends ApiController{ /** * The content type of the item. * From cd381735e05b3a51d4d25f2d8d6795bc62af884c Mon Sep 17 00:00:00 2001 From: Hannes Papenberg Date: Fri, 8 Aug 2025 12:43:40 +0200 Subject: [PATCH 4/9] More changes 2 --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index df228d0138c40..368b4542b43dd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -60,7 +60,7 @@ jobs: needs: [composer] strategy: matrix: - command: ['php-cs-fixer fix -vvv --dry-run --diff', 'phpcs --extensions=php -p --standard=ruleset.xml .'] + command: ['php-cs-fixer fix -vvv', 'phpcs --extensions=php -p --standard=ruleset.xml .'] steps: - uses: actions/checkout@v4 - uses: actions/cache/restore@v4 @@ -76,7 +76,6 @@ jobs: git config --global --add safe.directory $GITHUB_WORKSPACE ./libraries/vendor/bin/${{ matrix.command }} - uses: parkerbxyz/suggest-changes@v2 - if: failure() && steps.check-codestyle.outcome == 'failure' with: comment: 'Your code does not comply with our codestyle. Please commit the suggested changes.' From 0b7db5491587121560f6d58933de8fe6ec56bf40 Mon Sep 17 00:00:00 2001 From: Hannes Papenberg Date: Fri, 8 Aug 2025 12:55:38 +0200 Subject: [PATCH 5/9] More changes 3 --- .github/workflows/ci.yml | 1 + .../com_banners/src/Controller/BannersController.php | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 368b4542b43dd..1337e7d05b3c1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -78,6 +78,7 @@ jobs: - uses: parkerbxyz/suggest-changes@v2 with: comment: 'Your code does not comply with our codestyle. Please commit the suggested changes.' + event: 'REQUEST_CHANGES' code-style-js-css: name: Check Javascript & CSS code style diff --git a/api/components/com_banners/src/Controller/BannersController.php b/api/components/com_banners/src/Controller/BannersController.php index f81b7f8c2a68e..913dc6cf28b3c 100644 --- a/api/components/com_banners/src/Controller/BannersController.php +++ b/api/components/com_banners/src/Controller/BannersController.php @@ -21,7 +21,8 @@ * * @since 4.0.0 */ -class BannersController extends ApiController{ +class BannersController extends ApiController + { /** * The content type of the item. * From 1451977b4eab528aaadcffec667915c1314c94f2 Mon Sep 17 00:00:00 2001 From: Hannes Papenberg Date: Fri, 8 Aug 2025 13:05:29 +0200 Subject: [PATCH 6/9] More changes 4 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1337e7d05b3c1..b59400aa83835 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -75,7 +75,7 @@ jobs: run: | git config --global --add safe.directory $GITHUB_WORKSPACE ./libraries/vendor/bin/${{ matrix.command }} - - uses: parkerbxyz/suggest-changes@v2 + - uses: parkerbxyz/suggest-changes@v2.0.5 with: comment: 'Your code does not comply with our codestyle. Please commit the suggested changes.' event: 'REQUEST_CHANGES' From 6fe3ba97a30d901a211113c1f71846bc4900b6c4 Mon Sep 17 00:00:00 2001 From: Hannes Papenberg Date: Fri, 8 Aug 2025 13:05:57 +0200 Subject: [PATCH 7/9] More changes 5 --- .../com_banners/src/Controller/BannersController.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/api/components/com_banners/src/Controller/BannersController.php b/api/components/com_banners/src/Controller/BannersController.php index 913dc6cf28b3c..2f85d10280144 100644 --- a/api/components/com_banners/src/Controller/BannersController.php +++ b/api/components/com_banners/src/Controller/BannersController.php @@ -21,8 +21,7 @@ * * @since 4.0.0 */ -class BannersController extends ApiController - { +class BannersController extends ApiController { /** * The content type of the item. * @@ -38,4 +37,4 @@ class BannersController extends ApiController * @since 3.0 */ protected $default_view = 'banners'; -} + } From 1de2c0f7ac749c45e75c33ed8e9344ece2da72f2 Mon Sep 17 00:00:00 2001 From: Hannes Papenberg Date: Fri, 15 Aug 2025 10:46:44 +0200 Subject: [PATCH 8/9] Test --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b59400aa83835..73893e0c3af55 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -75,7 +75,7 @@ jobs: run: | git config --global --add safe.directory $GITHUB_WORKSPACE ./libraries/vendor/bin/${{ matrix.command }} - - uses: parkerbxyz/suggest-changes@v2.0.5 + - uses: parkerbxyz/suggest-changes@copilot/fix-86 with: comment: 'Your code does not comply with our codestyle. Please commit the suggested changes.' event: 'REQUEST_CHANGES' From 837f16ce1e7ee3fb84bbfc2ed442043a059657d2 Mon Sep 17 00:00:00 2001 From: Hannes Papenberg Date: Sun, 17 Aug 2025 09:52:20 +0200 Subject: [PATCH 9/9] Update ci.yml --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 89823c46f156d..82f5d63151fa9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -75,7 +75,7 @@ jobs: run: | git config --global --add safe.directory $GITHUB_WORKSPACE ./libraries/vendor/bin/${{ matrix.command }} - - uses: parkerbxyz/suggest-changes@copilot/fix-86 + - uses: parkerbxyz/suggest-changes@v2 with: comment: 'Your code does not meet our codestyle requirements. Please commit the suggested changes.' event: 'REQUEST_CHANGES'