constructor parameter migrations

Author: Haehnchen

src/controller/backtest_controller.ts

@@ -3,11 +3,8 @@ import { Backtest } from '../modules/backtest';
 import express from 'express';
 
 export class BacktestController extends BaseController {
-  private backtest: Backtest;
-
-  constructor(templateHelpers: TemplateHelpers, backtest: Backtest) {
+  constructor(templateHelpers: TemplateHelpers, private backtest: Backtest) {
     super(templateHelpers);
-    this.backtest = backtest;
   }
 
   registerRoutes(router: express.Router): void {

src/controller/base_controller.ts

@@ -15,11 +15,7 @@ export interface TemplateHelpers {
 }
 
 export abstract class BaseController implements Controller {
-  protected templateHelpers: TemplateHelpers;
-
-  constructor(templateHelpers: TemplateHelpers) {
-    this.templateHelpers = templateHelpers;
-  }
+  constructor(protected templateHelpers: TemplateHelpers) {}
 
   abstract registerRoutes(router: express.Router): void;
 

src/controller/candles_controller.ts

@@ -5,13 +5,8 @@ import { CandleImporter } from '../modules/system/candle_importer';
 import express from 'express';
 
 export class CandlesController extends BaseController {
-  private candleExportHttp: CandleExportHttp;
-  private candleImporter: CandleImporter;
-
-  constructor(templateHelpers: TemplateHelpers, candleExportHttp: CandleExportHttp, candleImporter: CandleImporter) {
+  constructor(templateHelpers: TemplateHelpers, private candleExportHttp: CandleExportHttp, private candleImporter: CandleImporter) {
     super(templateHelpers);
-    this.candleExportHttp = candleExportHttp;
-    this.candleImporter = candleImporter;
   }
 
   registerRoutes(router: express.Router): void {

src/controller/dashboard_controller.ts

@@ -4,13 +4,8 @@ import { SystemUtil } from '../modules/system/system_util';
 import express from 'express';
 
 export class DashboardController extends BaseController {
-  private ta: Ta;
-  private systemUtil: SystemUtil;
-
-  constructor(templateHelpers: TemplateHelpers, ta: Ta, systemUtil: SystemUtil) {
+  constructor(templateHelpers: TemplateHelpers, private ta: Ta, private systemUtil: SystemUtil) {
     super(templateHelpers);
-    this.ta = ta;
-    this.systemUtil = systemUtil;
   }
 
   registerRoutes(router: express.Router): void {

src/controller/desks_controller.ts

@@ -3,11 +3,8 @@ import { SystemUtil } from '../modules/system/system_util';
 import express from 'express';
 
 export class DesksController extends BaseController {
-  private systemUtil: SystemUtil;
-
-  constructor(templateHelpers: TemplateHelpers, systemUtil: SystemUtil) {
+  constructor(templateHelpers: TemplateHelpers, private systemUtil: SystemUtil) {
     super(templateHelpers);
-    this.systemUtil = systemUtil;
   }
 
   registerRoutes(router: express.Router): void {

src/controller/logs_controller.ts

@@ -3,11 +3,8 @@ import { LogsHttp } from '../modules/system/logs_http';
 import express from 'express';
 
 export class LogsController extends BaseController {
-  private logsHttp: LogsHttp;
-
-  constructor(templateHelpers: TemplateHelpers, logsHttp: LogsHttp) {
+  constructor(templateHelpers: TemplateHelpers, private logsHttp: LogsHttp) {
     super(templateHelpers);
-    this.logsHttp = logsHttp;
   }
 
   registerRoutes(router: express.Router): void {

src/controller/orders_controller.ts

@@ -4,13 +4,8 @@ import { ExchangeManager } from '../modules/exchange/exchange_manager';
 import express from 'express';
 
 export class OrdersController extends BaseController {
-  private ordersHttp: OrdersHttp;
-  private exchangeManager: ExchangeManager;
-
-  constructor(templateHelpers: TemplateHelpers, ordersHttp: OrdersHttp, exchangeManager: ExchangeManager) {
+  constructor(templateHelpers: TemplateHelpers, private ordersHttp: OrdersHttp, private exchangeManager: ExchangeManager) {
     super(templateHelpers);
-    this.ordersHttp = ordersHttp;
-    this.exchangeManager = exchangeManager;
   }
 
   registerRoutes(router: express.Router): void {

src/controller/pairs_controller.ts

@@ -3,11 +3,8 @@ import { PairsHttp } from '../modules/pairs/pairs_http';
 import express from 'express';
 
 export class PairsController extends BaseController {
-  private pairsHttp: PairsHttp;
-
-  constructor(templateHelpers: TemplateHelpers, pairsHttp: PairsHttp) {
+  constructor(templateHelpers: TemplateHelpers, private pairsHttp: PairsHttp) {
     super(templateHelpers);
-    this.pairsHttp = pairsHttp;
   }
 
   registerRoutes(router: express.Router): void {

src/controller/signals_controller.ts

@@ -3,11 +3,8 @@ import { SignalHttp } from '../modules/signal/signal_http';
 import express from 'express';
 
 export class SignalsController extends BaseController {
-  private signalHttp: SignalHttp;
-
-  constructor(templateHelpers: TemplateHelpers, signalHttp: SignalHttp) {
+  constructor(templateHelpers: TemplateHelpers, private signalHttp: SignalHttp) {
     super(templateHelpers);
-    this.signalHttp = signalHttp;
   }
 
   registerRoutes(router: express.Router): void {

src/controller/trades_controller.ts

@@ -6,15 +6,13 @@ import { OrderUtil } from '../utils/order_util';
 import express from 'express';
 
 export class TradesController extends BaseController {
-  private exchangeManager: ExchangeManager;
-  private ordersHttp: OrdersHttp;
-  private tickers: Tickers;
-
-  constructor(templateHelpers: TemplateHelpers, exchangeManager: ExchangeManager, ordersHttp: OrdersHttp, tickers: Tickers) {
+  constructor(
+    templateHelpers: TemplateHelpers,
+    private exchangeManager: ExchangeManager,
+    private ordersHttp: OrdersHttp,
+    private tickers: Tickers
+  ) {
     super(templateHelpers);
-    this.exchangeManager = exchangeManager;
-    this.ordersHttp = ordersHttp;
-    this.tickers = tickers;
   }
 
   registerRoutes(router: express.Router): void {