Skip to content

Commit 400e4fc

Browse files
committed
style/docs: fix lingering linting issues + add missing func doc strings
1 parent f8f6131 commit 400e4fc

File tree

17 files changed

+52
-13
lines changed

17 files changed

+52
-13
lines changed

horde_sdk/ai_horde_api/apimodels/alchemy/async_.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ class AlchemyAsyncRequestFormItem(HordeAPIData):
7575
"""The name of the form to request."""
7676

7777
@field_validator("name")
78-
def check_name(cls, v: KNOWN_ALCHEMY_TYPES | str) -> KNOWN_ALCHEMY_TYPES | str:
78+
def validate_name(cls, v: KNOWN_ALCHEMY_TYPES | str) -> KNOWN_ALCHEMY_TYPES | str:
79+
"""Validate the name of the form to request."""
7980
if isinstance(v, KNOWN_ALCHEMY_TYPES):
8081
return v
8182
if str(v) not in KNOWN_ALCHEMY_TYPES.__members__:
@@ -109,13 +110,15 @@ class AlchemyAsyncRequest(
109110
"""Whether to use the super slow workers."""
110111

111112
@field_validator("forms")
112-
def check_at_least_one_form(cls, v: list[AlchemyAsyncRequestFormItem]) -> list[AlchemyAsyncRequestFormItem]:
113+
def validate_at_least_one_form(cls, v: list[AlchemyAsyncRequestFormItem]) -> list[AlchemyAsyncRequestFormItem]:
114+
"""Ensure at least one form is provided."""
113115
if not v:
114116
raise ValueError("At least one form must be provided.")
115117
return v
116118

117119
@field_validator("source_image")
118-
def check_source_image(cls, v: str) -> str:
120+
def validate_source_image(cls, v: str) -> str:
121+
"""Validate the source image URL or base64 string."""
119122
if "http" in v:
120123
parsed_url = urllib.parse.urlparse(v)
121124
if parsed_url.scheme not in ["http", "https"]:

horde_sdk/ai_horde_api/apimodels/alchemy/pop.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ def get_api_model_name(cls) -> str | None:
6565

6666
@field_validator("form", mode="before")
6767
def validate_form(cls, v: str | KNOWN_ALCHEMY_TYPES) -> KNOWN_ALCHEMY_TYPES | str:
68+
"""Ensure that the form is a known alchemy type."""
6869
if isinstance(v, KNOWN_ALCHEMY_TYPES):
6970
return v
7071
if isinstance(v, str) and v not in KNOWN_ALCHEMY_TYPES.__members__:

horde_sdk/ai_horde_api/apimodels/alchemy/status.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ class AlchemyFormStatus(HordeAPIData):
8787

8888
@field_validator("form", mode="before")
8989
def validate_form(cls, v: str | KNOWN_ALCHEMY_TYPES) -> KNOWN_ALCHEMY_TYPES | str:
90+
"""Ensure that the form is a known alchemy type."""
9091
if isinstance(v, KNOWN_ALCHEMY_TYPES):
9192
return v
9293
if str(v) not in KNOWN_ALCHEMY_TYPES.__members__:
@@ -103,6 +104,7 @@ def validate_result(
103104
cls,
104105
v: dict[str, object],
105106
) -> dict[str, object] | None:
107+
"""Ensure that the result is valid and convert it to the correct type, if possible."""
106108
if "additionalProp1" in v:
107109
logger.debug("Found additionalProp1 in result, this is a dummy result. Ignoring.")
108110
return None
@@ -153,6 +155,7 @@ def all_upscale_results(self) -> list[AlchemyUpscaleResult]:
153155
"""Return all completed upscale results."""
154156
return [form.result for form in self.forms if form.done and isinstance(form.result, AlchemyUpscaleResult)]
155157

158+
@override
156159
@classmethod
157160
def get_api_model_name(cls) -> str | None:
158161
return "InterrogationStatus"

horde_sdk/ai_horde_api/apimodels/documents.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ class AIHordeDocumentRequestMixin(HordeAPIObjectBaseModel):
5050

5151
@field_validator("format")
5252
def validate_format(cls, value: DocumentFormat | str) -> DocumentFormat | str:
53+
"""Validate the format is a valid document format."""
5354
if isinstance(value, DocumentFormat):
5455
return value
5556

horde_sdk/ai_horde_api/apimodels/generate/async_.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,8 @@
1313
)
1414
from horde_sdk.ai_horde_api.apimodels.generate.check import ImageGenerateCheckRequest
1515
from horde_sdk.ai_horde_api.apimodels.generate.status import DeleteImageGenerateRequest, ImageGenerateStatusRequest
16-
from horde_sdk.ai_horde_api.apimodels.workers.messages import _ResponseModelMessageData
1716
from horde_sdk.ai_horde_api.endpoints import AI_HORDE_API_ENDPOINT_SUBPATH
18-
from horde_sdk.consts import _ANONYMOUS_MODEL, _MODEL_OVERLOADED, HTTPMethod, HTTPStatusCode
17+
from horde_sdk.consts import _ANONYMOUS_MODEL, HTTPMethod, HTTPStatusCode
1918
from horde_sdk.generation_parameters.image.consts import KNOWN_SOURCE_PROCESSING
2019
from horde_sdk.generic_api.apimodels import (
2120
APIKeyAllowedInRequestMixin,
@@ -52,6 +51,7 @@ class ImageGenerateAsyncResponse(
5251

5352
@model_validator(mode="after")
5453
def validate_warnings(self) -> ImageGenerateAsyncResponse:
54+
"""Log any warnings that were generated by the server or a serving worker."""
5555
if self.warnings is None:
5656
return self
5757

@@ -66,6 +66,7 @@ def get_follow_up_returned_params(self, *, as_python_field_name: bool = False) -
6666
return [{"id_": self.id_}]
6767
return [{"id": self.id_}]
6868

69+
@override
6970
@classmethod
7071
def get_follow_up_default_request_type(cls) -> type[ImageGenerateCheckRequest]:
7172
return ImageGenerateCheckRequest
@@ -130,6 +131,7 @@ def get_api_model_name(cls) -> str | None:
130131

131132
@field_validator("n", mode="before")
132133
def validate_n(cls, value: int) -> int:
134+
"""Ensure that n is at least 1."""
133135
if value == 0:
134136
logger.debug("n (number of images to generate) is not set; defaulting to 1")
135137
return 1
@@ -187,6 +189,7 @@ class ImageGenerateAsyncRequest(
187189

188190
@model_validator(mode="after")
189191
def validate_censor_nsfw(self) -> ImageGenerateAsyncRequest:
192+
"""Ensure that censor_nsfw is not set when nsfw is enabled."""
190193
if self.nsfw and self.censor_nsfw:
191194
raise ValueError("Cannot censor NSFW content when NSFW detection is enabled.")
192195
return self

horde_sdk/ai_horde_api/apimodels/generate/pop.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@
1515
ImageGenerateParamMixin,
1616
)
1717
from horde_sdk.ai_horde_api.apimodels.generate.submit import ImageGenerationJobSubmitRequest
18-
from horde_sdk.ai_horde_api.apimodels.workers.messages import _ResponseModelMessageData, ResponseModelMessage
18+
from horde_sdk.ai_horde_api.apimodels.workers.messages import _ResponseModelMessageData
1919
from horde_sdk.ai_horde_api.consts import (
2020
GENERATION_STATE,
2121
)
2222
from horde_sdk.ai_horde_api.endpoints import AI_HORDE_API_ENDPOINT_SUBPATH
2323
from horde_sdk.ai_horde_api.fields import GenerationID
24-
from horde_sdk.consts import _ANONYMOUS_MODEL, _MODEL_OVERLOADED, HTTPMethod
24+
from horde_sdk.consts import _MODEL_OVERLOADED, HTTPMethod
2525
from horde_sdk.generation_parameters.alchemy.consts import KNOWN_FACEFIXERS, KNOWN_UPSCALERS
2626
from horde_sdk.generation_parameters.image.consts import KNOWN_SOURCE_PROCESSING
2727
from horde_sdk.generic_api.apimodels import (
@@ -303,6 +303,7 @@ def source_processing_must_be_known(cls, v: str | KNOWN_SOURCE_PROCESSING) -> st
303303

304304
@field_validator("id_", mode="before")
305305
def validate_id(cls, v: str | GenerationID) -> GenerationID | str:
306+
"""Validate the ID is not an empty string."""
306307
if isinstance(v, str) and v == "":
307308
logger.warning("Job ID is empty")
308309
return GenerationID(root=uuid.uuid4())

horde_sdk/ai_horde_api/apimodels/generate/status.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ def get_api_model_name(self) -> str | None:
6969

7070
@field_validator("id_", mode="before")
7171
def validate_id(cls, v: str | GenerationID) -> GenerationID | str:
72+
"""Validate the ID is not an empty string."""
7273
if isinstance(v, str) and v == "":
7374
logger.warning("Job ID is empty")
7475
return GenerationID(root=uuid.uuid4())

horde_sdk/ai_horde_api/apimodels/generate/submit.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ class ImageGenerationJobSubmitRequest(
4343

4444
@model_validator(mode="after")
4545
def validate_generation(self) -> ImageGenerationJobSubmitRequest:
46+
"""Validate the generation field is not an empty string and warn if the seed is 0."""
4647
if self.generation == "":
4748
logger.error("Generation cannot be an empty string.")
4849
logger.error(self.log_safe_model_dump())

horde_sdk/ai_horde_api/apimodels/generate/text/async_.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ class TextGenerateAsyncResponse(
4747

4848
@model_validator(mode="after")
4949
def validate_warnings(self) -> TextGenerateAsyncResponse:
50+
"""Log any warnings that were generated by the server or a serving worker."""
5051
if self.warnings is None:
5152
return self
5253

@@ -61,6 +62,7 @@ def get_follow_up_returned_params(self, *, as_python_field_name: bool = False) -
6162
return [{"id_": self.id_}]
6263
return [{"id": self.id_}]
6364

65+
@override
6466
@classmethod
6567
def get_follow_up_default_request_type(cls) -> type[TextGenerateStatusRequest]:
6668
return TextGenerateStatusRequest

horde_sdk/ai_horde_api/apimodels/generate/text/pop.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ class TextGenerateJobPopResponse(
9090

9191
@field_validator("id_", mode="before")
9292
def validate_id(cls, v: str | GenerationID) -> GenerationID | str:
93+
"""Validate the ID is not an empty string."""
9394
if isinstance(v, str) and v == "":
9495
logger.warning("Job ID is empty")
9596
return GenerationID(root=uuid.uuid4())

0 commit comments

Comments
 (0)