Fix SIGABRT when bonding option is too long (#3210)

* Fix SIGABRT when bonding option is too long

* Move the UT to test_bonding.cpp

---------

Co-authored-by: Clément Gérouville <cgerouville@haivision.com>

Author: SPAleksey

srtcore/socketconfig.cpp

@@ -1092,7 +1092,7 @@ bool SRT_SocketOptionObject::add(SRT_SOCKOPT optname, const void* optval, size_t
     // needed - and it's better to not risk that alighment rules
     // will make these calculations result in less space than needed.
     const size_t headersize = sizeof(SingleOption);
-    const size_t payload = std::min(sizeof(uint32_t), optlen);
+    const size_t payload = std::max(sizeof(uint32_t), optlen);
     unsigned char* mem = new unsigned char[headersize + payload];
     SingleOption* option = reinterpret_cast<SingleOption*>(mem);
     option->option = optname;

test/test_bonding.cpp

@@ -1594,3 +1594,12 @@ TEST(Bonding, BackupPrioritySelection)
 }
 
 
+TEST(Bonding, ApiConfig)
+{
+    using namespace std;
+    SRT_SOCKOPT_CONFIG config;
+
+    string example = "example_long_excessively";
+
+    EXPECT_EQ(srt_config_add(&config, SRTO_BINDTODEVICE, (void*)example.data(), example.size()), 0);
+}

test/test_utilities.cpp

@@ -272,3 +272,4 @@ TEST(ConfigString, Setting)
     EXPECT_EQ(s.size(), 0U);
     EXPECT_TRUE(s.empty());
 }
+