Skip to content

Commit 048d211

Browse files
authored
Fix error when the min_n filter fails and results are None instead of a dictionary (#107)
1 parent 7d927a7 commit 048d211

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

clarite/modules/analyze/regression/glm_regression.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,8 @@ def run(self):
326326
)
327327
# TODO: Parallelize this loop
328328
for rv in rv_list:
329+
# Must define result to catch errors outside running individual variables
330+
result = None
329331
# Run in a try/except block to catch any errors specific to a regression variable
330332
try:
331333
# Take a copy of the data (ignoring other RVs)
@@ -395,6 +397,8 @@ def run(self):
395397

396398
except Exception as e:
397399
self.errors[rv] = str(e)
400+
if result is None:
401+
result = self.get_default_result_dict(rv)
398402
self.results.append(result)
399403

400404
click.echo(

clarite/modules/analyze/regression/weighted_glm_regression.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,10 +263,10 @@ def run(self):
263263
)
264264
# TODO: Parallelize this loop
265265
for rv in rv_list:
266+
# Must define result to catch errors outside running individual variables
267+
result = None
266268
# Run in a try/except block to catch any errors specific to a regression variable
267269
try:
268-
# Must define result to catch errors outside running individual variables
269-
result = None
270270
# Take a copy of the data (ignoring other RVs) and create a keep_rows mask
271271
keep_columns = [rv, self.outcome_variable] + self.covariates
272272
data = self.data[keep_columns]
@@ -360,6 +360,8 @@ def run(self):
360360

361361
except Exception as e:
362362
self.errors[rv] = str(e)
363+
if result is None:
364+
result = self.get_default_result_dict(rv)
363365
self.results.append(result)
364366

365367
click.echo(

0 commit comments

Comments
 (0)