Improved permission requests from settings panel

Author: Hamza417

app/build.gradle

@@ -50,7 +50,7 @@ android {
 
     compileSdkVersion 30
 
-    def appVersionCode = 138
+    def appVersionCode = 139
     def appVersionName = "positional_build_${appVersionCode}_final"
 
     defaultConfig {

app/src/main/java/app/simple/positional/ui/panels/AppSettings.kt

@@ -10,11 +10,13 @@ import android.content.res.ColorStateList
 import android.net.Uri
 import android.os.Bundle
 import android.provider.Settings
+import android.util.Log
 import android.view.*
 import android.widget.TextView
 import android.widget.Toast
+import androidx.activity.result.ActivityResultLauncher
+import androidx.activity.result.contract.ActivityResultContracts
 import androidx.appcompat.app.AppCompatDelegate
-import androidx.core.app.ActivityCompat
 import app.simple.positional.R
 import app.simple.positional.activities.fragment.ScopedFragment
 import app.simple.positional.activities.subactivity.AccentColorsActivity
@@ -81,6 +83,29 @@ class AppSettings : ScopedFragment(), CoordinatesCallback, PopupMenuCallback {
     private lateinit var currentLocationProvider: TextView
     private lateinit var foundIssues: TextView
 
+    private lateinit var permissionContracts: ActivityResultLauncher<Array<String>>
+    private var opened = false
+
+    override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+
+        permissionContracts = registerForActivityResult(ActivityResultContracts.RequestMultiplePermissions()) { mutableMap ->
+            mutableMap.entries.forEach {
+                if (it.value) {
+                    Log.d("Permissions", "${it.key} : ${it.value}")
+                } else {
+                    if (!opened) {
+                        startActivity(Intent(Settings.ACTION_APPLICATION_DETAILS_SETTINGS).apply {
+                            data = Uri.fromParts("package", requireActivity().packageName, null)
+                        })
+
+                        opened = true
+                    }
+                }
+            }
+        }
+    }
+
     override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
         val view = inflater.inflate(R.layout.fragment_settings, container, false)
 
@@ -283,16 +308,13 @@ class AppSettings : ScopedFragment(), CoordinatesCallback, PopupMenuCallback {
         }
 
         permission.setOnClickListener {
-            if (ActivityCompat.shouldShowRequestPermissionRationale(requireActivity(), Manifest.permission.ACCESS_FINE_LOCATION) &&
-                    ActivityCompat.shouldShowRequestPermissionRationale(requireActivity(), Manifest.permission.ACCESS_COARSE_LOCATION)) {
-                ActivityCompat.requestPermissions(requireActivity(), arrayOf(
-                        Manifest.permission.ACCESS_COARSE_LOCATION,
-                        Manifest.permission.ACCESS_FINE_LOCATION
-                ), 123)
+            if (PermissionUtils.checkPermission(requireContext())) {
+                permissionNotification()
             } else {
-                startActivity(Intent(Settings.ACTION_APPLICATION_DETAILS_SETTINGS).apply {
-                    data = Uri.fromParts("package", requireActivity().packageName, null)
-                })
+                permissionContracts.launch(
+                        arrayOf(
+                                Manifest.permission.ACCESS_COARSE_LOCATION,
+                                Manifest.permission.ACCESS_FINE_LOCATION))
             }
         }
     }
@@ -407,6 +429,7 @@ class AppSettings : ScopedFragment(), CoordinatesCallback, PopupMenuCallback {
         super.onResume()
         toggleCustomLocation.isChecked = MainPreferences.isCustomCoordinate()
         permissionNotification()
+        opened = false
     }
 
     override fun onSharedPreferenceChanged(sharedPreferences: SharedPreferences?, key: String?) {

app/src/main/java/app/simple/positional/ui/subpanels/CustomLocation.kt

@@ -27,6 +27,7 @@ import app.simple.positional.activities.fragment.ScopedFragment
 import app.simple.positional.activities.subactivity.WebPageViewerActivity
 import app.simple.positional.adapters.settings.LocationsAdapter
 import app.simple.positional.database.instances.LocationDatabase
+import app.simple.positional.decorations.padding.PaddingAwareLinearLayout
 import app.simple.positional.decorations.popup.PopupLinearLayout
 import app.simple.positional.decorations.ripple.DynamicRippleImageButton
 import app.simple.positional.model.Locations
@@ -53,7 +54,7 @@ class CustomLocation : ScopedFragment() {
     private lateinit var addressInputEditText: EditText
     private lateinit var latitudeInputEditText: EditText
     private lateinit var longitudeInputEditText: EditText
-    private lateinit var inputLayoutsContainer: LinearLayout
+    private lateinit var inputLayoutsContainer: PaddingAwareLinearLayout
 
     private lateinit var locationsAdapter: LocationsAdapter
     private lateinit var itemTouchHelper: ItemTouchHelper

app/src/main/res/layout/fragment_custom_location.xml

@@ -1,12 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
-<app.simple.positional.decorations.padding.PaddingAwareLinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:orientation="vertical">
 
-    <LinearLayout
+    <app.simple.positional.decorations.padding.PaddingAwareLinearLayout
         android:id="@+id/custom_location_input_container"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
@@ -177,7 +177,7 @@
             android:layout_marginTop="10dp"
             android:background="@color/dividerColor" />
 
-    </LinearLayout>
+    </app.simple.positional.decorations.padding.PaddingAwareLinearLayout>
 
     <FrameLayout
         android:layout_width="match_parent"
@@ -203,4 +203,4 @@
 
     </FrameLayout>
 
-</app.simple.positional.decorations.padding.PaddingAwareLinearLayout>
+</LinearLayout>

app/src/main/res/layout/fragment_settings.xml

@@ -84,7 +84,7 @@
                     android:layout_marginEnd="16dp"
                     android:layout_weight="1"
                     android:fontFamily="@font/medium"
-                    android:text="@string/location_permission_denied"
+                    android:text="@string/no_location_permission_alert"
                     android:textColor="@android:color/white"
                     android:textSize="@dimen/settings_secondary_text_size" />