Incorrect if statement

[robbanl]

https://github.com/HandmadeWeb/statamic-cloudflare/blob/main/src/Listeners/PurgeEntryUrl.php#L16

Isn't that IF-statement wrong? If will always trigger and prevent for flushing? (PHP 8.2)

[imacrayon]

Can confirm that the if statement is wrong, it should be:

if (! $event instanceof EntrySaved && ! $event instanceof EntryDeleted)

The same is true for https://github.com/HandmadeWeb/statamic-cloudflare/blob/main/src/Listeners/PurgeTermUrl.php#L16

These guard statements also seem redundant, because the listeners are explicitly defined here:

statamic-cloudflare/src/ServiceProvider.php

Lines 15 to 28 in 573db1e

	protected $listen = [
	\Statamic\Events\EntrySaved::class => [
	\HandmadeWeb\StatamicCloudflare\Listeners\PurgeEntryUrl::class,
	],
	\Statamic\Events\EntryDeleted::class => [
	\HandmadeWeb\StatamicCloudflare\Listeners\PurgeEntryUrl::class,
	],
	\Statamic\Events\TermSaved::class => [
	\HandmadeWeb\StatamicCloudflare\Listeners\PurgeTermUrl::class,
	],
	\Statamic\Events\TermDeleted::class => [
	\HandmadeWeb\StatamicCloudflare\Listeners\PurgeTermUrl::class,
	],
	];

The workaround is to use the cloudflare cache strategy, because that appears to side-step the event listeners altogether:

statamic-cloudflare/src/ServiceProvider.php

Lines 34 to 37 in 573db1e

	// If the static cache strategy is set to the Cloudflare Cacher, then remove listeners as the cacher will handle purges.
	if (config("statamic.static_caching.strategies.{$static_cacher}.driver") === 'cloudflare') {
	$this->listen = [];
	}