Skip to content

Commit ebe6ec4

Browse files
EcljpseB0Tjukzi
authored andcommitted
use ScreenshotOnFailure TestWatcher
1 parent 1bae704 commit ebe6ec4

File tree

3 files changed

+7
-15
lines changed

3 files changed

+7
-15
lines changed

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_StyledText.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,8 @@ public class Test_org_eclipse_swt_custom_StyledText extends Test_org_eclipse_swt
103103
private boolean listenerCalled;
104104
private boolean listener2Called;
105105

106-
@Rule public TestWatcher screenshotRule = new TestWatcher() {
107-
@Override
108-
protected void failed(Throwable e, org.junit.runner.Description description) {
109-
super.failed(e, description);
110-
Screenshots.takeScreenshot(description.getTestClass(), description.getMethodName());
111-
}
112-
};
106+
@Rule
107+
public TestWatcher screenshotRule = Screenshots.onFailure();
113108

114109
@Override
115110
@Before

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_StyledText_multiCaretsSelections.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,7 @@
4040
public class Test_org_eclipse_swt_custom_StyledText_multiCaretsSelections {
4141

4242
@Rule
43-
public TestWatcher screenshotRule = new TestWatcher() {
44-
@Override
45-
protected void failed(Throwable e, org.junit.runner.Description description) {
46-
super.failed(e, description);
47-
Screenshots.takeScreenshot(description.getTestClass(), description.getMethodName());
48-
}
49-
};
43+
public TestWatcher screenshotRule = Screenshots.onFailure();
5044

5145
Shell shell;
5246
StyledText text;

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Tree.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
import org.junit.Rule;
3939
import org.junit.Test;
4040
import org.junit.rules.TestName;
41+
import org.junit.rules.TestWatcher;
4142

4243
/**
4344
* Automated Test Suite for class org.eclipse.swt.widgets.Tree
@@ -915,6 +916,9 @@ public void test_disposeItemNotTriggerSelection() {
915916
assertFalse(selectionCalled[0]);
916917
}
917918

919+
@Rule
920+
public TestWatcher screenshotRule = Screenshots.onFailure();
921+
918922
@Test
919923
public void test_Virtual() {
920924
tree.dispose();
@@ -964,7 +968,6 @@ public void test_Virtual() {
964968
}
965969
// temp code to capture screenshot
966970
if (SwtTestUtil.isCocoa) {
967-
Screenshots.takeScreenshot(getClass(), testName.getMethodName());
968971
// check if setData is called for root item
969972
assertTrue("SetData not called for top item", top[0] != null);
970973
}

0 commit comments

Comments
 (0)