change name

isEditingCell -> isCellEditing

Author: huangshuwei

packages/ve-table/src/editor/edit-input.jsx

@@ -49,7 +49,7 @@ export default {
             required: true,
         },
         // is editing cell
-        isEditingCell: {
+        isCellEditing: {
             type: Boolean,
             required: true,
         },
@@ -218,7 +218,7 @@ export default {
             immediate: true,
         },
         // is editing cell
-        isEditingCell: {
+        isCellEditing: {
             handler: function (val) {
                 if (val) {
                     this.showTextarea();
@@ -385,9 +385,9 @@ export default {
 
         // textarea add new line
         textareaAddNewLine() {
-            const { isEditingCell, editingCell } = this;
+            const { isCellEditing, editingCell } = this;
 
-            if (isEditingCell) {
+            if (isCellEditing) {
                 const textareaInputEl = this.$refs[this.textareaInputRef];
 
                 const caretPosition = getCaretPosition(textareaInputEl);
@@ -426,7 +426,7 @@ export default {
             containerStyle,
             textareaClass,
             rawCellValue,
-            isEditingCell,
+            isCellEditing,
         } = this;
 
         const containerProps = {
@@ -451,7 +451,7 @@ export default {
             },
             on: {
                 input: (e) => {
-                    if (isEditingCell) {
+                    if (isCellEditing) {
                         this.textareaValueChange(e.target.value);
                         this.rawCellValue = e.target.value;
                     }

packages/ve-table/src/index.jsx

@@ -430,7 +430,7 @@ export default {
                 [clsName("virtual-scroll")]: isVirtualScroll,
                 [clsName("container-left-scrolling")]: isLeftScrolling,
                 [clsName("container-right-scrolling")]: isRightScrolling,
-                [clsName("is-cell-editing")]: this.isEditingCell,
+                [clsName("is-cell-editing")]: this.isCellEditing,
             };
         },
         // table body class
@@ -477,7 +477,7 @@ export default {
             return this.colgroups.some((x) => x.fixed === "right");
         },
         // is editing cell
-        isEditingCell() {
+        isCellEditing() {
             const { editingCell } = this;
 
             return (
@@ -697,7 +697,7 @@ export default {
                 colgroups,
                 cellSelectionKeyData,
                 enableStopEditing,
-                isEditingCell,
+                isCellEditing,
             } = this;
 
             const { keyCode, ctrlKey, shiftKey, altKey } = event;
@@ -809,7 +809,7 @@ export default {
                         break;
                     }
                     case KEY_CODES.SPACE: {
-                        if (!isEditingCell) {
+                        if (!isCellEditing) {
                             // start editing and enter a space
                             this[INSTANCE_METHODS.START_EDITING_CELL]({
                                 rowKey,
@@ -822,7 +822,7 @@ export default {
                         break;
                     }
                     case KEY_CODES.BACK_SPACE: {
-                        if (!isEditingCell) {
+                        if (!isCellEditing) {
                             // start editing and clear value
                             this[INSTANCE_METHODS.START_EDITING_CELL]({
                                 rowKey,
@@ -835,7 +835,7 @@ export default {
                         break;
                     }
                     case KEY_CODES.DELETE: {
-                        if (!isEditingCell) {
+                        if (!isCellEditing) {
                             // delete selection cell value
                             this.deleteCellValue();
                             event.preventDefault();
@@ -844,7 +844,7 @@ export default {
                         break;
                     }
                     case KEY_CODES.F2: {
-                        if (!isEditingCell) {
+                        if (!isCellEditing) {
                             if (currentColumn.edit) {
                                 // start editing cell and don't allow stop eidting by direction key
                                 this.enableStopEditing = false;
@@ -1470,12 +1470,12 @@ export default {
                 rowKeyFieldName,
                 editOption,
                 editingCell,
-                isEditingCell,
+                isCellEditing,
             } = this;
 
             const { cellValueChange } = editOption;
 
-            if (isEditingCell) {
+            if (isCellEditing) {
                 const { rowKey, colKey } = editingCell;
 
                 let currentRow = this.tableData.find(
@@ -1560,7 +1560,7 @@ export default {
         editCellByClick({ isDblclick }) {
             const {
                 editOption,
-                isEditingCell,
+                isCellEditing,
                 hasEditColumn,
                 editingCell,
                 cellSelectionKeyData,
@@ -1589,7 +1589,7 @@ export default {
                 return false;
             }
 
-            if (isEditingCell) {
+            if (isCellEditing) {
                 this[INSTANCE_METHODS.STOP_EDITING_CELL]();
             }
 
@@ -1788,13 +1788,13 @@ export default {
         },
         // stop editing cell
         [INSTANCE_METHODS.STOP_EDITING_CELL]() {
-            const { editOption, isEditingCell } = this;
+            const { editOption, isCellEditing } = this;
 
             if (!editOption) {
                 return false;
             }
 
-            if (isEditingCell) {
+            if (isCellEditing) {
                 this.saveCellWhenStopEditing();
             }
         },
@@ -2058,7 +2058,7 @@ export default {
                 cellSelectionKeyData,
                 colgroups,
                 editingCell: this.editingCell,
-                isEditingCell: this.isEditingCell,
+                isCellEditing: this.isCellEditing,
                 allRowKeys: this.allRowKeys,
                 hasXScrollBar: this.hasXScrollBar,
                 hasYScrollBar: this.hasYScrollBar,

tests/unit/specs/ve-table-cell-edit.spec.js

@@ -159,7 +159,7 @@ describe("veTable cell edit", () => {
 
         await later();
 
-        expect(wrapper.vm.isEditingCell).toEqual(true);
+        expect(wrapper.vm.isCellEditing).toEqual(true);
 
         expect(wrapper.vm.editingCell.rowKey).toEqual(1);
         expect(wrapper.vm.editingCell.colKey).toEqual("date");