Skip to content

Commit f7ba867

Browse files
author
huangshuwei
committed
update row expand unit test
1 parent d800e1f commit f7ba867

File tree

2 files changed

+54
-71
lines changed

2 files changed

+54
-71
lines changed

‎tests/unit/specs/__snapshots__/ve-table-row-expand.spec.js.snap‎

Lines changed: 24 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,11 @@ exports[`veTable row expand expandOption expandedRowKeys(controllable attr) 1`]
3838
<!---->No.1 Century Avenue, Shanghai
3939
</td>
4040
</tr>
41-
<tr class="ve-table-expand-tr ve-table-expand-tr-show">
41+
<tr class="ve-table-expand-tr">
4242
<td colspan="4" class="ve-table-expand-td">
43-
<p>My name is<span style="color: rgb(24, 144, 255);">John</span>,I'm living in No.1 Century Avenue, Shanghai</p>
43+
<div class="ve-table-expand-td-content">
44+
<p>My name is<span style="color: rgb(24, 144, 255);">John</span>,I'm living in No.1 Century Avenue, Shanghai</p>
45+
</div>
4446
</td>
4547
</tr>
4648
<tr row-key="1002" class="ve-table-body-tr">
@@ -55,9 +57,11 @@ exports[`veTable row expand expandOption expandedRowKeys(controllable attr) 1`]
5557
<!---->No.1 Century Avenue, Beijing
5658
</td>
5759
</tr>
58-
<tr class="ve-table-expand-tr ve-table-expand-tr-show">
60+
<tr class="ve-table-expand-tr">
5961
<td colspan="4" class="ve-table-expand-td">
60-
<p>My name is<span style="color: rgb(24, 144, 255);">Dickerson</span>,I'm living in No.1 Century Avenue, Beijing</p>
62+
<div class="ve-table-expand-td-content">
63+
<p>My name is<span style="color: rgb(24, 144, 255);">Dickerson</span>,I'm living in No.1 Century Avenue, Beijing</p>
64+
</div>
6165
</td>
6266
</tr>
6367
<tr row-key="1003" class="ve-table-body-tr">
@@ -72,9 +76,11 @@ exports[`veTable row expand expandOption expandedRowKeys(controllable attr) 1`]
7276
<!---->No.1 Century Avenue, Chongqing
7377
</td>
7478
</tr>
75-
<tr class="ve-table-expand-tr ve-table-expand-tr-show">
79+
<tr class="ve-table-expand-tr">
7680
<td colspan="4" class="ve-table-expand-td">
77-
<p>My name is<span style="color: rgb(24, 144, 255);">Larsen</span>,I'm living in No.1 Century Avenue, Chongqing</p>
81+
<div class="ve-table-expand-td-content">
82+
<p>My name is<span style="color: rgb(24, 144, 255);">Larsen</span>,I'm living in No.1 Century Avenue, Chongqing</p>
83+
</div>
7884
</td>
7985
</tr>
8086
<tr row-key="1004" class="ve-table-body-tr">
@@ -89,11 +95,7 @@ exports[`veTable row expand expandOption expandedRowKeys(controllable attr) 1`]
8995
<!---->No.1 Century Avenue, Xiamen
9096
</td>
9197
</tr>
92-
<tr class="ve-table-expand-tr">
93-
<td colspan="4" class="ve-table-expand-td">
94-
<p>My name is<span style="color: rgb(24, 144, 255);">Geneva</span>,I'm living in No.1 Century Avenue, Xiamen</p>
95-
</td>
96-
</tr>
98+
<!---->
9799
<tr row-key="1005" class="ve-table-body-tr">
98100
<td rowspan="1" colspan="1" class="ve-table-body-td" style="text-align: center;"><span class="ve-table-row-expand-icon"><i class="ve-icon iconfont-vet icon-vet-right-arrow"></i></span></td>
99101
<td rowspan="1" colspan="1" class="ve-table-body-td" style="text-align: left;">
@@ -106,11 +108,7 @@ exports[`veTable row expand expandOption expandedRowKeys(controllable attr) 1`]
106108
<!---->No.1 Century Avenue, Shenzhen
107109
</td>
108110
</tr>
109-
<tr class="ve-table-expand-tr">
110-
<td colspan="4" class="ve-table-expand-td">
111-
<p>My name is<span style="color: rgb(24, 144, 255);">Jami</span>,I'm living in No.1 Century Avenue, Shenzhen</p>
112-
</td>
113-
</tr>
111+
<!---->
114112
</tbody>
115113
<tfoot class="ve-table-fixed-footer ve-table-footer"></tfoot>
116114
</table>
@@ -156,8 +154,10 @@ exports[`veTable row expand render 1`] = `
156154
<!---->No.1 Century Avenue, Shanghai
157155
</td>
158156
</tr>
159-
<tr class="ve-table-expand-tr ve-table-expand-tr-show">
160-
<td colspan="4" class="ve-table-expand-td"></td>
157+
<tr class="ve-table-expand-tr">
158+
<td colspan="4" class="ve-table-expand-td">
159+
<div class="ve-table-expand-td-content"></div>
160+
</td>
161161
</tr>
162162
<tr row-key="1002" class="ve-table-body-tr">
163163
<td rowspan="1" colspan="1" class="ve-table-body-td" style="text-align: center;"></td>
@@ -177,8 +177,10 @@ exports[`veTable row expand render 1`] = `
177177
<!---->No.1 Century Avenue, Chongqing
178178
</td>
179179
</tr>
180-
<tr class="ve-table-expand-tr ve-table-expand-tr-show">
181-
<td colspan="4" class="ve-table-expand-td"></td>
180+
<tr class="ve-table-expand-tr">
181+
<td colspan="4" class="ve-table-expand-td">
182+
<div class="ve-table-expand-td-content"></div>
183+
</td>
182184
</tr>
183185
<tr row-key="1004" class="ve-table-body-tr">
184186
<td rowspan="1" colspan="1" class="ve-table-body-td" style="text-align: center;"><span class="ve-table-row-expand-icon"><i class="ve-icon iconfont-vet icon-vet-right-arrow"></i></span></td>
@@ -192,9 +194,7 @@ exports[`veTable row expand render 1`] = `
192194
<!---->No.1 Century Avenue, Xiamen
193195
</td>
194196
</tr>
195-
<tr class="ve-table-expand-tr">
196-
<td colspan="4" class="ve-table-expand-td"></td>
197-
</tr>
197+
<!---->
198198
<tr row-key="1005" class="ve-table-body-tr">
199199
<td rowspan="1" colspan="1" class="ve-table-body-td" style="text-align: center;"><span class="ve-table-row-expand-icon"><i class="ve-icon iconfont-vet icon-vet-right-arrow"></i></span></td>
200200
<td rowspan="1" colspan="1" class="ve-table-body-td" style="text-align: left;">
@@ -207,9 +207,7 @@ exports[`veTable row expand render 1`] = `
207207
<!---->No.1 Century Avenue, Shenzhen
208208
</td>
209209
</tr>
210-
<tr class="ve-table-expand-tr">
211-
<td colspan="4" class="ve-table-expand-td"></td>
212-
</tr>
210+
<!---->
213211
</tbody>
214212
<tfoot class="ve-table-fixed-footer ve-table-footer"></tfoot>
215213
</table>

‎tests/unit/specs/ve-table-row-expand.spec.js‎

Lines changed: 30 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -116,13 +116,8 @@ describe("veTable row expand", () => {
116116
}
117117
});
118118

119-
expect(
120-
wrapper
121-
.findAll(".ve-table-expand-tr")
122-
.at(0)
123-
.find(".ve-table-expand-tr-show")
124-
.exists()
125-
).toBe(false);
119+
// 默认不渲染节点
120+
expect(wrapper.find(".ve-table-expand-tr").exists()).toBe(false);
126121

127122
wrapper
128123
.findAll(".ve-table-body-tr")
@@ -136,9 +131,20 @@ describe("veTable row expand", () => {
136131
wrapper
137132
.findAll(".ve-table-expand-tr")
138133
.at(0)
139-
.find(".ve-table-expand-tr-show")
134+
.find(".ve-table-expand-td .ve-table-expand-td-content")
140135
.exists()
141136
).toBe(true);
137+
138+
wrapper
139+
.findAll(".ve-table-body-tr")
140+
.at(0)
141+
.find(".ve-table-row-expand-icon")
142+
.trigger("click");
143+
144+
await later();
145+
146+
// 折叠后销毁节点
147+
expect(wrapper.find(".ve-table-expand-tr").exists()).toBe(false);
142148
});
143149

144150
it("trigger type:cell", async () => {
@@ -162,14 +168,6 @@ describe("veTable row expand", () => {
162168
}
163169
});
164170

165-
expect(
166-
wrapper
167-
.findAll(".ve-table-expand-tr")
168-
.at(0)
169-
.find(".ve-table-expand-tr-show")
170-
.exists()
171-
).toBe(false);
172-
173171
wrapper
174172
.findAll(".ve-table-body-tr")
175173
.at(0)
@@ -183,12 +181,12 @@ describe("veTable row expand", () => {
183181
wrapper
184182
.findAll(".ve-table-expand-tr")
185183
.at(0)
186-
.find(".ve-table-expand-tr-show")
184+
.find(".ve-table-expand-td .ve-table-expand-td-content")
187185
.exists()
188186
).toBe(true);
189187
});
190188

191-
it("trigger type:cell", async () => {
189+
it("trigger type:row", async () => {
192190
const wrapper = mount(veTable, {
193191
propsData: {
194192
columns: COLUMNS,
@@ -209,14 +207,6 @@ describe("veTable row expand", () => {
209207
}
210208
});
211209

212-
expect(
213-
wrapper
214-
.findAll(".ve-table-expand-tr")
215-
.at(0)
216-
.find(".ve-table-expand-tr-show")
217-
.exists()
218-
).toBe(false);
219-
220210
wrapper
221211
.findAll(".ve-table-body-tr")
222212
.at(0)
@@ -228,7 +218,7 @@ describe("veTable row expand", () => {
228218
wrapper
229219
.findAll(".ve-table-expand-tr")
230220
.at(0)
231-
.find(".ve-table-expand-tr-show")
221+
.find(".ve-table-expand-td .ve-table-expand-td-content")
232222
.exists()
233223
).toBe(true);
234224
});
@@ -262,7 +252,7 @@ describe("veTable row expand", () => {
262252
wrapper
263253
.findAll(".ve-table-body-tr")
264254
.at(1)
265-
.find(".ve-table-expand-tr")
255+
.find(".ve-table-row-expand-icon")
266256
.exists()
267257
).toBe(false);
268258
});
@@ -290,17 +280,17 @@ describe("veTable row expand", () => {
290280

291281
expect(
292282
wrapper
293-
.findAll(".ve-table-expand-tr")
283+
.findAll(".ve-table-body-tr")
294284
.at(0)
295-
.find(".ve-table-expand-tr-show")
285+
.find(".ve-table-row-expand-icon")
296286
.exists()
297287
).toBe(true);
298288

299289
expect(
300290
wrapper
301-
.findAll(".ve-table-expand-tr")
291+
.findAll(".ve-table-body-tr")
302292
.at(2)
303-
.find(".ve-table-expand-tr-show")
293+
.find(".ve-table-row-expand-icon")
304294
.exists()
305295
).toBe(true);
306296
});
@@ -326,7 +316,7 @@ describe("veTable row expand", () => {
326316
}
327317
});
328318

329-
expect(wrapper.findAll(".ve-table-expand-tr-show").length).toBe(5);
319+
expect(wrapper.findAll(".ve-table-row-expand-icon").length).toBe(5);
330320
});
331321

332322
it("expandOption beforeExpandRowChange event", async () => {
@@ -373,13 +363,7 @@ describe("veTable row expand", () => {
373363
expect(mockFn).toHaveBeenCalledWith(false);
374364

375365
await later();
376-
expect(
377-
wrapper
378-
.findAll(".ve-table-expand-tr")
379-
.at(0)
380-
.find(".ve-table-expand-tr-show")
381-
.exists()
382-
).toBe(false);
366+
expect(wrapper.findAll(".ve-table-expand-tr").exists()).toBe(false);
383367

384368
wrapper
385369
.findAll(".ve-table-body-tr")
@@ -393,8 +377,9 @@ describe("veTable row expand", () => {
393377
expect(
394378
wrapper
395379
.findAll(".ve-table-expand-tr")
396-
.at(1)
397-
.find(".ve-table-expand-tr-show")
380+
// 只要一行
381+
.at(0)
382+
.find(".ve-table-expand-td .ve-table-expand-td-content")
398383
.exists()
399384
).toBe(true);
400385
});
@@ -499,7 +484,7 @@ describe("veTable row expand", () => {
499484
wrapper
500485
.findAll(".ve-table-expand-tr")
501486
.at(0)
502-
.find(".ve-table-expand-tr-show")
487+
.find(".ve-table-expand-td .ve-table-expand-td-content")
503488
.exists()
504489
).toBe(true);
505490

@@ -510,8 +495,8 @@ describe("veTable row expand", () => {
510495
expect(
511496
wrapper
512497
.findAll(".ve-table-expand-tr")
513-
.at(2)
514-
.find(".ve-table-expand-tr-show")
498+
.at(1)
499+
.find(".ve-table-expand-td .ve-table-expand-td-content")
515500
.exists()
516501
).toBe(true);
517502

0 commit comments

Comments
 (0)