Merge pull request #59 from ArjinAlbay/main

refactor: Unused functions and comments were deleted

Author: ArjinAlbay

src/app/dashboard/page.tsx

@@ -19,7 +19,11 @@ import { useSearchStore, useActionItemsStore } from '@/stores'
 import { ThemeToggle } from '@/components/theme/ThemeToggle'
 import RefreshButton from "@/components/Refresh/RefreshButton";
 
+const VALID_PRIORITIES = ['urgent', 'high', 'medium', 'low'] as const;
 function mapActionItemToGitHubIssue(item: any): GitHubIssue {
+  if (!item) {
+    throw new Error('Invalid item provided to mapActionItemToGitHubIssue');
+  }
   return {
     id: item.id,
     title: item.title,
@@ -29,14 +33,14 @@ function mapActionItemToGitHubIssue(item: any): GitHubIssue {
     labels: (item.labels || []).map((name: string) => ({ name, color: '999999' })),
     created_at: item.createdAt || '',
     updated_at: item.updatedAt || '',
-    difficulty: item.difficulty || 'medium', // Don't assume all items are 'easy'
+    difficulty: item.difficulty || 'medium',
     language: item.language || 'unknown',
     stars: 0,
     author: { login: item.author || '', avatar_url: '' },
     comments: 0,
     state: 'open',
     assignee: null,
-    priority: ['urgent', 'high', 'medium', 'low'].includes(item.priority) ? item.priority : 'low',
+    priority: VALID_PRIORITIES.includes(item.priority) ? item.priority : 'low',
   }
 }
 
@@ -53,7 +57,7 @@ interface ActionItem {
 }
 
 export default function DashboardPage() {
-  const { isLoading, orgData, isAuthenticated } = useRequireAuth()
+  const { isLoading, orgData } = useRequireAuth()
   const { setSearchModalOpen } = useSearchStore()
   const {
     assignedItems,

src/components/layout/Sidebar.tsx

@@ -1,11 +1,8 @@
 'use client'
 
-import { useEffect } from 'react'
 import Link from 'next/link'
-import { usePathname,  useSearchParams } from 'next/navigation'
+import { usePathname,   useSearchParams } from 'next/navigation'
 import { Button } from '@/components/ui/button'
-
-
 import { useSidebarState, useAuthStore, useStoreHydration, useActionItemsStore } from '@/stores'
 import { ChevronRight, Clock,  LogOut, MessageSquare, Sparkles, Star, Target, Zap, } from 'lucide-react'
 import { Badge } from '../ui/badge'
@@ -20,10 +17,10 @@ export function Sidebar() {
 
   // Auth state
   const hasHydrated = useStoreHydration()
-  const { isConnected, orgData, logout } = useAuthStore()
+  const { isConnected, logout } = useAuthStore()
 
   // Action items state
-  const { getCountByType, getTotalCount, loading, refreshData } = useActionItemsStore()
+  const { getCountByType, getTotalCount, loading } = useActionItemsStore()
 
   // Get current tab from URL params
   const currentTab = searchParams.get('tab') || 'assigned'
@@ -39,15 +36,11 @@ export function Sidebar() {
     return getBadgeCount(type)
   }
 
-  const router = useRouter()
 
-  // Hangi bölümün açık olduğunu kontrol etmek için
+
   const isQuickWinsTab = currentTab === 'quick-wins' || currentTab === 'good-first-issues' || currentTab === 'easy-fixes'
   const isActionRequiredTab = !isQuickWinsTab && isDashboardPage
 
-  const navigationItems = [
-    { href: '/dashboard', label: 'Dashboard', icon: Flame }
-  ]
 
   const handleLogout = () => {
     logout() 

src/components/quick-wins/QuickWinsTable.tsx

@@ -34,7 +34,6 @@ import {
     ChevronRight,
     ChevronsLeft,
     ChevronsRight,
-    Search,
     Filter,
     RefreshCw,
     AlertCircle

src/lib/api/github-api-client.ts

@@ -73,25 +73,48 @@ class GitHubAPIClient {
     }
 
     const trimmedToken = token.trim()
+    
+ 
+    if (process.env.NODE_ENV === 'development') {
+      console.log('🔍 Token validation debug:', {
+        tokenLength: trimmedToken.length,
+        tokenPrefix: trimmedToken.substring(0, 10) + '...',
+        tokenPattern: trimmedToken.substring(0, 4)
+      })
+    }
 
 
     const isClassicToken = /^ghp_[A-Za-z0-9]{36}$/.test(trimmedToken)
     const isFineGrainedToken = /^github_pat_[A-Za-z0-9_]{82}$/.test(trimmedToken)
     const isGitHubAppToken = /^ghs_[A-Za-z0-9]{36}$/.test(trimmedToken)
-    
     const isLegacyToken = /^[a-f0-9]{40}$/.test(trimmedToken)
+    
+
+    const isOAuthToken = /^gho_[A-Za-z0-9_-]{16,}$/.test(trimmedToken) ||
+                        (!isClassicToken && !isFineGrainedToken && !isGitHubAppToken && !isLegacyToken && 
+                         /^[A-Za-z0-9_-]{20,255}$/.test(trimmedToken))
+
+    if (process.env.NODE_ENV === 'development') {
+      console.log('🔍 Token type checks:', {
+        isClassicToken,
+        isFineGrainedToken,
+        isGitHubAppToken,
+        isLegacyToken,
+        isOAuthToken
+      })
+    }
 
-    if (!isClassicToken && !isFineGrainedToken && !isGitHubAppToken && !isLegacyToken) {
+    if (!isClassicToken && !isFineGrainedToken && !isGitHubAppToken && !isLegacyToken && !isOAuthToken) {
       throw new Error(
         'Invalid GitHub token format. Expected:\n' +
         '- Classic token: ghp_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx (40 chars)\n' +
         '- Fine-grained token: github_pat_xxxxxxxxxx... (94 chars)\n' +
         '- GitHub App token: ghs_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx (40 chars)\n' +
+        '- OAuth token: 20-255 character alphanumeric string\n' +
         '- Legacy token: 40 character hexadecimal string'
       )
     }
 
-    // Additional length validation
     if (trimmedToken.length < 40) {
       throw new Error('GitHub token is too short. Minimum length is 40 characters.')
     }
@@ -103,16 +126,12 @@ class GitHubAPIClient {
     this.githubToken = trimmedToken
   }
 
-  /**
-   * Check if a valid GitHub token is currently set
-   */
+ 
   hasValidToken(): boolean {
-    return this.githubToken.length >= 40
+    return this.githubToken.length >= 20
   }
 
-  /**
-   * Clear the current GitHub token
-   */
+ 
   clearToken(): void {
     this.githubToken = ''
   }
@@ -131,7 +150,6 @@ class GitHubAPIClient {
         'User-Agent': 'GitHubMon/1.0'
       }
 
-      // Add GitHub token if available for authenticated requests
       if (useGithub && this.githubToken) {
         headers['Authorization'] = `token ${this.githubToken}`
       }
@@ -143,32 +161,27 @@ class GitHubAPIClient {
         if (response.status === 403) {
           console.warn('GitHub API rate limit exceeded')
         }
-        // Return fallback data on error
         return this.getFallbackData(endpoint) as T
       }
 
       const data = await response.json()
 
-      // GitHub API response
       this.cache.set(cacheKey, { data, timestamp: Date.now() })
       return data
 
     } catch (error) {
       console.error(`API request failed for ${endpoint}:`, error)
 
-      // Return cached data if available
       if (cached) {
         console.log('Returning stale cached data due to error')
         return cached.data as T
       }
 
-      // Fallback to mock data
       return this.getFallbackData(endpoint) as T
     }
   }
 
   private getFallbackData(endpoint: string): unknown {
-    // Return mock trending repositories if the real API fails
     if (endpoint.includes('search/repositories')) {
       return {
         items: [
@@ -406,6 +419,60 @@ async getAssignedItems(username?: string): Promise<unknown[]> {
     }
   }
 
+  async getGoodFirstIssues(): Promise<unknown[]> {
+    try {
+      const endpoint = `/search/issues?q=label:"good first issue"+state:open+type:issue&sort=updated&order=desc&per_page=50`
+      const response = await this.fetchWithCache<GitHubSearchResponse<GitHubIssueResponse>>(endpoint, true)
+      
+      return response.items?.map((item: GitHubIssueResponse) => ({
+        id: item.id,
+        title: item.title,
+        repo: item.repository_url 
+          ? item.repository_url.split('/').slice(-2).join('/')
+          : 'unknown/unknown',
+        type: 'issue',
+        priority: this.calculatePriority(item),
+        url: item.html_url,
+        createdAt: item.created_at,
+        updatedAt: item.updated_at,
+        author: item.user?.login,
+        labels: item.labels?.map((l: { name: string }) => l.name) || [],
+        daysOld: Math.floor((Date.now() - new Date(item.created_at).getTime()) / (1000 * 60 * 60 * 24))
+      })) || []
+    } catch (error) {
+      console.error('Failed to fetch good first issues:', error)
+      return []
+    }
+  }
+
+  async getEasyFixes(): Promise<unknown[]> {
+    try {
+      const labels = ['easy', 'easy fix', 'beginner', 'starter', 'help wanted']
+      const labelQuery = labels.map(label => `label:"${label}"`).join(' OR ')
+      const endpoint = `/search/issues?q=(${labelQuery})+state:open+type:issue&sort=updated&order=desc&per_page=50`
+      const response = await this.fetchWithCache<GitHubSearchResponse<GitHubIssueResponse>>(endpoint, true)
+      
+      return response.items?.map((item: GitHubIssueResponse) => ({
+        id: item.id,
+        title: item.title,
+        repo: item.repository_url 
+          ? item.repository_url.split('/').slice(-2).join('/')
+          : 'unknown/unknown',
+        type: 'issue',
+        priority: this.calculatePriority(item),
+        url: item.html_url,
+        createdAt: item.created_at,
+        updatedAt: item.updated_at,
+        author: item.user?.login,
+        labels: item.labels?.map((l: { name: string }) => l.name) || [],
+        daysOld: Math.floor((Date.now() - new Date(item.created_at).getTime()) / (1000 * 60 * 60 * 24))
+      })) || []
+    } catch (error) {
+      console.error('Failed to fetch easy fixes:', error)
+      return []
+    }
+  }
+
   private calculatePriority(item: GitHubIssueResponse): 'low' | 'medium' | 'high' | 'urgent' {
     const labels = item.labels?.map((l: { name: string }) => l.name.toLowerCase()) || []
     const commentCount = item.comments || 0

src/lib/api/github.ts

@@ -2,14 +2,7 @@ import { GitHubIssue } from '@/types/quickWins';
 
 const GITHUB_API_URL = 'https://api.github.com';
 
-// İsteğe bağlı: Token'ı .env veya config dosyasından alınabilir
-// Eğer .env yoksa buraya kendi token'ınızı yazabilirsiniz
-// Token artık parametre ile alınacak, default olarak boş
-
-
-
-// Basit bir in-memory cache
-const CACHE_DURATION = 1000 * 60 * 60 * 12; // 12 saat (günde 2 defa güncellenir)
+const CACHE_DURATION = 1000 * 60 * 60 * 12; 
 const issuesCache: Record<string, { timestamp: number; data: GitHubIssue[] }> = {};
 
 async function fetchIssuesFromGitHub({