Merge pull request #68 from ArjinAlbay/main

ArjinAlbay · web-flow · commit 788756450fd5 · 2025-08-08T18:03:58.000+03:00
refactor: stargazer type can be null
diff --git a/src/app/api/search/route.ts b/src/app/api/search/route.ts
@@ -0,0 +1,72 @@
+import { NextRequest, NextResponse } from 'next/server'
+import { githubAPIClient } from '@/lib/api/github-api-client'
+
+export async function GET(request: NextRequest) {
+  try {
+    const { searchParams } = new URL(request.url)
+    const query = searchParams.get('q')
+    const type = searchParams.get('type') || 'repos'
+    const limit = parseInt(searchParams.get('limit') || '20')
+
+    if (!query) {
+      return NextResponse.json(
+        { error: 'Query parameter "q" is required' },
+        { status: 400 }
+      )
+    }
+
+    let results
+    if (type === 'users') {
+      results = await githubAPIClient.searchUsers(query, 'all', limit)
+    } else {
+      results = await githubAPIClient.searchRepositories(query, 'stars', limit)
+    }
+
+    return NextResponse.json({
+      query,
+      type,
+      results,
+      total: results.length
+    })
+  } catch (error) {
+    console.error('Search API error:', error)
+    return NextResponse.json(
+      { error: 'Internal server error' },
+      { status: 500 }
+    )
+  }
+}
+
+export async function POST(request: NextRequest) {
+  try {
+    const body = await request.json()
+    const { query, type = 'repos', limit = 20 } = body
+
+    if (!query) {
+      return NextResponse.json(
+        { error: 'Query is required in request body' },
+        { status: 400 }
+      )
+    }
+
+    let results
+    if (type === 'users') {
+      results = await githubAPIClient.searchUsers(query, 'all', limit)
+    } else {
+      results = await githubAPIClient.searchRepositories(query, 'stars', limit)
+    }
+
+    return NextResponse.json({
+      query,
+      type,
+      results,
+      total: results.length
+    })
+  } catch (error) {
+    console.error('Search API error:', error)
+    return NextResponse.json(
+      { error: 'Internal server error' },
+      { status: 500 }
+    )
+  }
+}
diff --git a/src/app/api/user/[username]/route.ts b/src/app/api/user/[username]/route.ts
diff --git a/src/app/search/page.tsx b/src/app/search/page.tsx
@@ -108,6 +108,44 @@ export default function SearchPage() {
   );
   const [loadingAnalytics, setLoadingAnalytics] = useState<boolean>(false);
 
+  const loadUserAnalytics = useCallback(async () => {
+    if (!userParam) return;
+
+    setLoadingAnalytics(true);
+    try {
+      const analytics = await githubAPIClient.getUserAnalytics(userParam);
+      if (analytics) {
+        // Convert GitHubUserDetailed to the expected profile format
+        const convertedAnalytics: UserAnalytics = {
+          profile: analytics.profile ? {
+            avatar_url: analytics.profile.avatar_url,
+            login: analytics.profile.login,
+            type: analytics.profile.type,
+            bio: analytics.profile.bio,
+            public_repos: analytics.profile.public_repos,
+            followers: analytics.profile.followers,
+            following: analytics.profile.following,
+            location: analytics.profile.location,
+            company: analytics.profile.company,
+            html_url: analytics.profile.html_url
+          } : undefined,
+          overview: analytics.overview,
+          languages: analytics.languages,
+          behavior: analytics.behavior
+        };
+        setUserAnalytics(convertedAnalytics);
+      } else {
+        setUserAnalytics(null);
+      }
+    } catch (error) {
+      console.error("Analytics error:", error);
+      // Fallback to null if API fails
+      setUserAnalytics(null);
+    } finally {
+      setLoadingAnalytics(false);
+    }
+  }, [userParam]);
+
   const throttle = useCallback(
     <T extends (...args: unknown[]) => void>(
       func: T,
@@ -202,7 +240,7 @@ export default function SearchPage() {
         loadUserAnalytics();
       }
     }
-  }, [userParam, repoParam, setCurrentQuery, setCurrentSearchType]);
+  }, [userParam, repoParam, setCurrentQuery, setCurrentSearchType, loadUserAnalytics]);
   const performSearch = async (query: string, type: "users" | "repos") => {
     setSearchResults((prev) => ({ ...prev, loading: true, error: null }));
 
@@ -239,22 +277,6 @@ export default function SearchPage() {
     }
   };
 
-  const loadUserAnalytics = async () => {
-    if (!userParam) return;
-
-    setLoadingAnalytics(true);
-    try {
-      const analytics = await githubAPIClient.getUserAnalytics(userParam);
-      setUserAnalytics(analytics);
-    } catch (error) {
-      console.error("Analytics error:", error);
-      // Fallback to null if API fails
-      setUserAnalytics(null);
-    } finally {
-      setLoadingAnalytics(false);
-    }
-  };
-
   // Dispatch active section to sidebar
   useEffect(() => {
     const event = new CustomEvent("activeSectionChange", {
diff --git a/src/components/quick-wins/hooks/useQuickWins.ts b/src/components/quick-wins/hooks/useQuickWins.ts
@@ -48,7 +48,7 @@ export function useQuickWins() {
             ])
         }
         isInitialized.current = true
-    }, [loadFromCache, isQuickWinsCacheExpired, goodIssues.length, easyFixes.length, fetchGoodIssues, fetchEasyFixes])
+    }, [loadFromCache, isQuickWinsCacheExpired, fetchGoodIssues, fetchEasyFixes])
 
     useEffect(() => {
         if (goodIssues.length > 0) {
diff --git a/src/lib/api/github-api-client.ts b/src/lib/api/github-api-client.ts
@@ -2,6 +2,10 @@ import type {
   TrendingRepo,
   TopContributor
 } from '@/types/oss-insight'
+import type {
+  GitHubUserDetailed,
+  GitHubRepositoryDetailed
+} from '@/types/github'
 
 interface GitHubSearchResponse<T> {
   items: T[]
@@ -558,32 +562,54 @@ async getEasyFixes(): Promise<MappedIssue[]> {
 
   // ============ USER ANALYTICS API METHODS ============
 
-  async getUserProfile(username: string): Promise<any> {
+  async getUserProfile(username: string): Promise<GitHubUserDetailed | null> {
     try {
       const endpoint = `/users/${username}`
       return await this.fetchWithCache(endpoint, true)
     } catch (error) {
       console.error('Failed to fetch user profile:', error)
       // Return fallback profile data
       return {
-        avatar_url: `https://github.com/${username}.png`,
+        id: 0,
         login: username,
-        type: 'User',
-        bio: null,
+        node_id: '',
+        avatar_url: `https://github.com/${username}.png`,
+        gravatar_id: '',
+        url: '',
+        html_url: `https://github.com/${username}`,
+        followers_url: '',
+        following_url: '',
+        gists_url: '',
+        starred_url: '',
+        subscriptions_url: '',
+        organizations_url: '',
+        repos_url: '',
+        events_url: '',
+        received_events_url: '',
+        type: 'User' as const,
+        site_admin: false,
+        name: undefined,
+        company: undefined,
+        blog: undefined,
+        location: undefined,
+        email: undefined,
+        hireable: undefined,
+        bio: undefined,
+        twitter_username: undefined,
         public_repos: 0,
+        public_gists: 0,
         followers: 0,
         following: 0,
-        location: null,
-        company: null,
-        html_url: `https://github.com/${username}`
+        created_at: new Date().toISOString(),
+        updated_at: new Date().toISOString()
       }
     }
   }
 
-  async getUserRepositories(username: string, limit = 100): Promise<any[]> {
+  async getUserRepositories(username: string, limit = 100): Promise<GitHubRepositoryDetailed[]> {
     try {
       const endpoint = `/users/${username}/repos?per_page=${limit}&sort=updated`
-      const repos = await this.fetchWithCache<any[]>(endpoint, true)
+      const repos = await this.fetchWithCache<GitHubRepositoryDetailed[]>(endpoint, true)
 
       // Ensure we always return an array
       if (Array.isArray(repos)) {
@@ -631,7 +657,7 @@ async getEasyFixes(): Promise<MappedIssue[]> {
   }
 
   async getUserAnalytics(username: string): Promise<{
-    profile: any
+    profile: GitHubUserDetailed | null
     overview: Array<{ name: string; commits: number; stars: number; repos: number }>
     languages: Array<{ name: string; value: number }>
     behavior: Array<{ day: string; commits: number; prs: number; issues: number }>
@@ -653,7 +679,7 @@ async getEasyFixes(): Promise<MappedIssue[]> {
 
       // Generate real overview data from repos
       const overview = Array.isArray(repos) && repos.length > 0
-        ? repos.slice(0, 10).map((repo: any) => ({
+        ? repos.slice(0, 10).map((repo: GitHubRepositoryDetailed) => ({
           name: repo?.name?.length > 15 ? repo.name.substring(0, 15) + '...' : (repo?.name || 'Unknown'),
           commits: Math.max(1, Math.floor(Math.random() * 50) + 10), // GitHub API doesn't provide commit counts easily
           stars: repo?.stargazers_count || 0,
@@ -695,24 +721,51 @@ async getEasyFixes(): Promise<MappedIssue[]> {
     keysToDelete.forEach(key => this.cache.delete(key));
   }
 
-  private getDemoAnalytics(username: string) {
+  private getDemoAnalytics(username: string): {
+    profile: GitHubUserDetailed | null
+    overview: Array<{ name: string; commits: number; stars: number; repos: number }>
+    languages: Array<{ name: string; value: number }>
+    behavior: Array<{ day: string; commits: number; prs: number; issues: number }>
+  } {
     const isRealUser = ['torvalds', 'octocat', 'gaearon', 'sindresorhus', 'tj', 'defunkt'].includes(username.toLowerCase());
 
     const baseData = {
       profile: {
-        avatar_url: `https://github.com/${username}.png`, // GitHub always provides avatar for any username
+        id: 0,
         login: username,
-        type: 'User',
+        node_id: '',
+        avatar_url: `https://github.com/${username}.png`, // GitHub always provides avatar for any username
+        gravatar_id: '',
+        url: '',
+        html_url: `https://github.com/${username}`,
+        followers_url: '',
+        following_url: '',
+        gists_url: '',
+        starred_url: '',
+        subscriptions_url: '',
+        organizations_url: '',
+        repos_url: '',
+        events_url: '',
+        received_events_url: '',
+        type: 'User' as const,
+        site_admin: false,
+        name: undefined,
+        company: isRealUser ? 'Open Source' : 'Demo Company',
+        blog: undefined,
+        location: isRealUser ? 'Global' : 'Demo Location',
+        email: undefined,
+        hireable: undefined,
         bio: isRealUser
           ? `Real GitHub user ${username} - Limited data due to API constraints`
           : `Demo profile for ${username}`,
+        twitter_username: undefined,
         public_repos: isRealUser ? Math.floor(Math.random() * 50) + 20 : 25,
+        public_gists: 0,
         followers: isRealUser ? Math.floor(Math.random() * 5000) + 500 : 150,
         following: isRealUser ? Math.floor(Math.random() * 200) + 50 : 75,
-        location: isRealUser ? 'Global' : 'Demo Location',
-        company: isRealUser ? 'Open Source' : 'Demo Company',
-        html_url: `https://github.com/${username}`
-      },
+        created_at: new Date().toISOString(),
+        updated_at: new Date().toISOString()
+      } satisfies GitHubUserDetailed,
       overview: isRealUser ? [
         { name: 'linux', commits: 145, stars: 150000, repos: 1 },
         { name: 'subsurface', commits: 95, stars: 2500, repos: 1 },
diff --git a/src/lib/api/github-graphql-client.ts b/src/lib/api/github-graphql-client.ts
@@ -35,7 +35,7 @@ interface Issue {
   repository: {
     name: string
     nameWithOwner: string
-    stargazerCount: number
+    stargazerCount: number | null
     primaryLanguage: { name: string } | null
     owner: {
       login: string
@@ -169,7 +169,7 @@ class GitHubGraphQLClient {
       })
 
       const filteredIssues = result.data.search.nodes
-        .filter(issue => issue.repository.stargazerCount >= 5)
+        .filter(issue => issue.repository?.stargazerCount && issue.repository.stargazerCount >= 5)
         .map(issue => this.mapIssueToGitHubIssue(issue))
 
       return filteredIssues
@@ -259,7 +259,7 @@ class GitHubGraphQLClient {
     )
     
     const filteredIssues = uniqueIssues
-        .filter(issue => issue.repository?.stargazerCount >= 5)
+        .filter(issue => issue.repository?.stargazerCount && issue.repository.stargazerCount >= 5)
         .map(issue => this.mapIssueToGitHubIssue(issue))
 
     return filteredIssues
@@ -279,7 +279,7 @@ class GitHubGraphQLClient {
       updated_at: issue.updatedAt,
       difficulty: 'easy' as const, 
       language: issue.repository.primaryLanguage?.name || 'unknown',
-      stars: issue.repository.stargazerCount,
+      stars: issue.repository.stargazerCount || 0,
       author: {
         login: issue.author?.login || 'unknown',
         avatar_url: issue.author?.avatarUrl || ''

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ export function useQuickWins() {`
`48`	`48`	`])`
`49`	`49`	`}`
`50`	`50`	`isInitialized.current = true`
`51`		`- }, [loadFromCache, isQuickWinsCacheExpired, goodIssues.length, easyFixes.length, fetchGoodIssues, fetchEasyFixes])`
	`51`	`+ }, [loadFromCache, isQuickWinsCacheExpired, fetchGoodIssues, fetchEasyFixes])`
`52`	`52`
`53`	`53`	`useEffect(() => {`
`54`	`54`	`if (goodIssues.length > 0) {`