Randomizer: N64 Rando fishing enhancements

[AndyNPC]

OoTR N64 randomizer makes a few changes for faster and easier fishing. The fish have a 100% chance to bite and almost everything in the pond should be the size needed for the check.

[jbodner09]

This was already added to vanilla in https://github.com/HarbourMasters/Shipwright/blob/develop-zhora/libultraship/libultraship/ImGuiImpl.cpp#L1077-L1086. Is that what you're looking for?

[AndyNPC]

It's a bit different still. There's many fish in the pond that aren't large enough for the check even if you lower the required weight to the lowest it can go. You still have to do some searching even if you set them to 6 and 8. N64 rando sets everything in the pond (or at least everything on the outside edges) to be the required weight, so the first fish you catch should always work.

[PurpleHato]

The fast fishing options that @jbodner09 showed you already does that by allowing you to change the weight of all fishes in the pounds to a minimal desired value, if you set the slider to the maximum position, it will be a valid fish and first try

[AndyNPC]

That option doesn't lower the weight of the fishes, only the weight required to receive the reward and the setting doesn't go low enough to cover most fish. I've attached a video demonstrating this. Catching this same fish on N64 rando would give you an 8 pounder.
2022-07-21 13-43-31.webm

[jbodner09]

Oh yeah, they did do something to always spawn the fish in deterministic places, didn't they?

[aMannus]

I think N64 rando changes either all fish or atleast the one in the left side of the pond to the minimum weight required, not sure which.

So even with the fishing enhancement, we'd definitely also have to change the weight values of the fish themselves if we want true parity with the other randos.

That said, I would vote for only changing the fish weight to a minimum of 6/8 pounds for child/adult respectively (in rando only of course), and leaving it up to the player if they actually want to change the fishing requirements in the enhancement menu.